Unify Python3_Development_FOUND checks#662
Merged
Conversation
The value of this variable may change if other code paths call find_package(Python3), so move the warning to be co-located with the add_subdirectory call. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-math8 #662 +/- ##
============================================
+ Coverage 95.71% 95.73% +0.01%
============================================
Files 150 151 +1
Lines 10390 10429 +39
============================================
+ Hits 9945 9984 +39
Misses 445 445 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 10, 2025
scpeters
commented
Feb 10, 2025
src/CMakeLists.txt
Outdated
| @@ -20,6 +20,8 @@ add_subdirectory(graph) | |||
| # Bindings subdirectories | |||
| if (Python3_Development_FOUND AND NOT SKIP_PYBIND11) | |||
Member
Author
There was a problem hiding this comment.
I should nest this logic like is done in gazebosim/gz-transport#565
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
j-rivero
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes hidden warnings when python development libraries are not found, port of gazebosim/gz-transport#565
Summary
The value of
Python3_Development_FOUNDmay change if other code paths callfind_package(Python3), so move the warning to be co-located with the add_subdirectory call. Otherwise python bindings may be silently ignored.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.