Skip to content

Merge 6 -> 7 as of pybind11 GaussMarkovProcess#379

Merged
scpeters merged 17 commits intogazebosim:mainfrom
scpeters:merge_6_7
Feb 25, 2022
Merged

Merge 6 -> 7 as of pybind11 GaussMarkovProcess#379
scpeters merged 17 commits intogazebosim:mainfrom
scpeters:merge_6_7

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Feb 25, 2022

➡️ Forward port

Port ign-math6 to main as of #315.

Branch comparison: main...7717f49

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 15 commits December 23, 2021 22:56
@ahcorde
Added Quaternion pybind11 interface (gazebosim#324)
9ab392a 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Added Line3 pybind11 interface (gazebosim#317)
8b5f3dc 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Added MovingWindowFilter pybind11 interface (gazebosim#321)
1cac654 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde @chapulina
Added Matrix3 pybind11 interface (gazebosim#325)
abd66cf 
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@ahcorde
Added SemanticVersion pybind11 interface (gazebosim#331)
f3a0390 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Added Filter pybind11 interface (gazebosim#336)
939b551 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Added Spline pybind11 interface (gazebosim#332)
c5e32b4 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde @chapulina
Added Triangle pybind11 interface (gazebosim#333)
2a4cb8b 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@ahcorde
Added Pose3 pybind11 interface (gazebosim#334)
f6c26bf 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Added Triangle3 pybind11 interface (gazebosim#335)
76ffa87 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde @chapulina
Added Kmeans pybind11 interface (gazebosim#341)
bb43b30 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@ahcorde @chapulina
Added Material pybind11 interface (gazebosim#340)
a0be19f 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@ahcorde @chapulina
Added RotationSpline pybind11 interface (gazebosim#339)
9085401 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@ahcorde @chapulina
Add GaussMarkovProcess pybind11 interface and examples (gazebosim#315)
7717f49 
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
@scpeters
Merge commit '7717f4913fb407f8e4a69203aace0a2b47799956' into merge_6_7
132f7e2
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 25, 2022
scpeters added a commit to scpeters/gz-math that referenced this pull request Feb 25, 2022
@scpeters
pybind11: use new method names and fix tests (gazebosim#379)
70ea4f4 
This replaces deprecated method names with the new names.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
pybind11: use new method names and fix tests (gazebosim#379)
d0ed5be 
This replaces deprecated method names with the new names.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2022 •
edited
Loading

Codecov Report

Merging #379 (d0ed5be) into main (04028c9) will not change coverage.
The diff coverage is n/a.

❗ Current head d0ed5be differs from pull request most recent head 56b896c. Consider uploading reports for the commit 56b896c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          65       65           
  Lines        6111     6111           
=======================================
  Hits         6089     6089           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04028c9...56b896c. Read the comment docs.

ahcorde
ahcorde requested changes Feb 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a warning related with Quaternion<int> I don't know if does make sense or not to have a class like this. Few can only represents with this class a few angles.

@scpeters
Quaternion.hh fix warning with /2 instead of *0.5
56b896c 
Originally from gazebosim#361.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Feb 25, 2022

we have a warning related with Quaternion<int> I don't know if does make sense or not to have a class like this. Few can only represents with this class a few angles.

I agree it doesn't make much sense, but it might be needed for Matrix3i due to the coupling between Matrix3 and Quaternion

I've cherry-picked the fix for the warning from part of #361

@scpeters scpeters requested a review from ahcorde February 25, 2022 18:49
@scpeters scpeters merged commit 27de5e0 into gazebosim:main Feb 25, 2022
@scpeters scpeters deleted the merge_6_7 branch February 25, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

🌱 garden Ignition Garden

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scpeters @ahcorde @j-rivero @osrf-triage