Skip to content

Fix pybind11 issues with macOS#361

Merged
chapulina merged 11 commits intoign-math6from
ci_matching_branch/math_scripting
Jan 26, 2022
Merged

Fix pybind11 issues with macOS#361
chapulina merged 11 commits intoign-math6from
ci_matching_branch/math_scripting

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Jan 5, 2022

This fixes a test failure and compiler error when running the pybind11 tests on macOS. This pull request has a matching branch name with osrf/homebrew-simulation#1793, so the CI is using pybind11 and is now clean.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jan 5, 2022
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2022

Codecov Report

Merging #361 (29868b1) into ign-math6 (5be7da9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #361   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22           
Impacted Files Coverage Δ
include/ignition/math/Quaternion.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be7da9...29868b1. Read the comment docs.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters changed the title testing CI Fix pybind11 issues with macOS Jan 26, 2022
@scpeters scpeters requested review from ahcorde and chapulina January 26, 2022 08:37
@scpeters scpeters marked this pull request as ready for review January 26, 2022 08:37
@scpeters scpeters mentioned this pull request Jan 26, 2022
7 tasks
@chapulina chapulina merged commit ceab8c7 into ign-math6 Jan 26, 2022
@chapulina chapulina deleted the ci_matching_branch/math_scripting branch January 26, 2022 16:58
scpeters added a commit to scpeters/gz-math that referenced this pull request Feb 25, 2022
Originally from gazebosim#361.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@osrf-triage
Copy link
Copy Markdown

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants