Skip to content

🎈 6.10.0#369

Merged
chapulina merged 3 commits intoign-math6from
chapulina/6.10.0
Jan 26, 2022
Merged

🎈 6.10.0#369
chapulina merged 3 commits intoign-math6from
chapulina/6.10.0

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

@chapulina chapulina commented Jan 25, 2022

🎈 Release

Prepare for 6.10.0 release.

Comparison to 6.9.2: ignition-math6_6.9.2...ign-math6

This follows the 6.9.3~pre2 pre-release:

Various updates have been made to packaging too:

I think we're in a good point to call our Python interfaces a feature, that's why I bumped the minor instead of the patch version.

Required by

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@chapulina
🎈 6.10.0
9f0c9f4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jan 25, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #369 (b758f70) into ign-math6 (ceab8c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #369   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceab8c7...b758f70. Read the comment docs.

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Jan 25, 2022

I just did a quick test of ign-math6 on macOS with osrf/homebrew-simulation#1776 and I'm seeing just one python test failure and several ruby test failures. I think it will be pretty easy to fix the python test failures and enable the pybind11 dependency in homebrew and revisit the ruby failures later

@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Jan 25, 2022

I think it will be pretty easy to fix the python test failures and enable the pybind11 dependency in homebrew and revisit the ruby failures later

Nice! Do you want to tackle the test failure before the release? It would be great to get this release out today or tomorrow, so that we can merge the ign-gazebo PR by the end of the week 🙏

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Jan 25, 2022

I think it will be pretty easy to fix the python test failures and enable the pybind11 dependency in homebrew and revisit the ruby failures later

Nice! Do you want to tackle the test failure before the release? It would be great to get this release out today or tomorrow, so that we can merge the ign-gazebo PR by the end of the week 🙏

I'll open a pull request today to support pybind11

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Jan 26, 2022

I think it will be pretty easy to fix the python test failures and enable the pybind11 dependency in homebrew and revisit the ruby failures later

Nice! Do you want to tackle the test failure before the release? It would be great to get this release out today or tomorrow, so that we can merge the ign-gazebo PR by the end of the week 🙏

I'll open a pull request today to support pybind11

#361 and osrf/homebrew-simulation#1793

@chapulina
Merge branch 'ign-math6' into chapulina/6.10.0
5d29a29 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Update changelog
b758f70 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Jan 26, 2022

#361 and osrf/homebrew-simulation#1793

Thanks, @scpeters . #361 is in and I updated the changelog.

scpeters
scpeters reviewed Jan 26, 2022
View reviewed changes
Changelog.md
* [Pull request #317](https://github.com/ignitionrobotics/ign-math/pull/317)
1. Quaternion
* [Pull request #324](https://github.com/ignitionrobotics/ign-math/pull/324)
* [Pull request #361](https://github.com/ignitionrobotics/ign-math/pull/361)
Copy link
Copy Markdown
Member

@scpeters scpeters Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in two places?

Copy link
Copy Markdown
Contributor Author

@chapulina chapulina Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah because that PR affected both Quaternion and PID

scpeters
scpeters approved these changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we can go ahead and make the release, but let's wait to build bottle until we've merged osrf/homebrew-simulation#1793

@chapulina chapulina merged commit 286a5d4 into ign-math6 Jan 26, 2022
@chapulina chapulina deleted the chapulina/6.10.0 branch January 26, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@scpeters scpeters scpeters approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @scpeters @ahcorde @j-rivero @osrf-triage