Skip to content

ignition-math6,7: depend on pybind11 and swig#1776

Closed
chapulina wants to merge 5 commits intomasterfrom
chapulina/math_scripting
Closed

ignition-math6,7: depend on pybind11 and swig#1776
chapulina wants to merge 5 commits intomasterfrom
chapulina/math_scripting

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

The goal is to enable testing with these dependencies on our CI.

If this is acceptable, I think the next step would be to add --with-pybind11 and --with-swig to PROJECT_ARGS here:

https://github.com/ignition-tooling/release-tools/blob/master/jenkins-scripts/lib/project-default-devel-homebrew-amd64.bash#L77

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters January 5, 2022 01:49
@scpeters
Copy link
Copy Markdown
Member

scpeters commented Jan 5, 2022

brew doesn't really support optional dependencies very well anymore. I think we're better off adding these as regular dependencies. I'd like to test CI first though. The easiest way to do that is with a ci_matching_branch/, so I'll try creating an identical branch with that name

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters changed the title ign-math6: optional dependencies: pybind11 and swig ignition-math6,7: depend on pybind11 and swig Jan 5, 2022
@scpeters
Copy link
Copy Markdown
Member

scpeters commented Jan 5, 2022

brew doesn't really support optional dependencies very well anymore. I think we're better off adding these as regular dependencies. I'd like to test CI first though. The easiest way to do that is with a ci_matching_branch/, so I'll try creating an identical branch with that name

testing with gazebosim/gz-math#361

@scpeters
Copy link
Copy Markdown
Member

scpeters commented Jan 5, 2022

I see a cmake warning and several failed scripting tests, though the failed tests don't show up in jenkins because they don't generate junit files

The following tests FAILED:
	119 - PID_TEST.py (Failed)
	139 - Angle_TEST.rb (Failed)
	140 - GaussMarkovProcess_TEST.rb (Failed)
	141 - Rand_TEST.rb (Failed)
	142 - Vector2_TEST.rb (Failed)
	143 - Vector3_TEST.rb (Failed)
	144 - Vector4_TEST.rb (Failed)
	145 - ruby_TEST.rb (Failed)

@chapulina
Copy link
Copy Markdown
Contributor Author

I see a cmake warning and several failed scripting tests

Ah that's unfortunate, I was hoping it would just work. I won't have time to look into those, we could ticket an issue to see if someone volunteers.

@scpeters
Copy link
Copy Markdown
Member

closed in favor of #1793

@scpeters scpeters closed this Jan 27, 2022
@scpeters scpeters deleted the chapulina/math_scripting branch January 27, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants