Cherry-pick #285, #280 to main#327
Merged
scpeters merged 3 commits intogazebosim:mainfrom Jan 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 99.30% 99.53% +0.23%
==========================================
Files 68 68
Lines 6290 6275 -15
==========================================
Hits 6246 6246
+ Misses 44 29 -15
Continue to review full report at Codecov.
|
Contributor
|
Cherry-picking will make the commits still show up when we see the branch comparison. Can we do it as a merge forward like previous PRs? |
Member
Author
the idea was to help expedite a fix for the test failures in #283, but if there's not a rush, then I'll just continue merging forward incrementally |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
f77b588 to
4ffbc4e
Compare
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe #280 and #285 will help resolve some issues in #283.
Remember to use rebase-and-merge