Modified cmake target name for Ruby interfaces#285
Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #285 +/- ##
=============================================
+ Coverage 99.41% 99.65% +0.23%
=============================================
Files 67 67
Lines 6374 6359 -15
=============================================
Hits 6337 6337
+ Misses 37 22 -15
Continue to review full report at Codecov.
|
scpeters
approved these changes
Nov 22, 2021
scpeters
pushed a commit
to scpeters/gz-math
that referenced
this pull request
Dec 22, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
scpeters
pushed a commit
to scpeters/gz-math
that referenced
this pull request
Jan 10, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
scpeters
pushed a commit
that referenced
this pull request
Jan 10, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
this PR blocks this other PR https://github.com/ignitionrobotics/ign-math/pull/280/files
pybind11 requires to call the target with the same name of the exported module. We would like to use
import gazebo.mathwith Python interfaces. We are using this target name for the Ruby SWIG modules, SWIG allows to set some variable to call the module with the desired name.This is just a change of the target name should not affect behaviour.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge