Vector2, 3 and 4 with pybind11#280
Merged
Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Contributor
Author
|
I made some changes:
|
Contributor
Author
|
@scpeters or @chapulina this is ready for a initial review. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #280 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6359 6359
==========================================
Hits 6337 6337
Misses 22 22
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
8 tasks
chapulina
previously requested changes
Nov 22, 2021
Contributor
chapulina
left a comment
There was a problem hiding this comment.
This works seamlessly with the ign-gazebo PR, great work!
If we're going to switch from SWIG to pybind11, I think we need to:
- Remove the Python SWIG bindings as we port them to pybind11. We shouldn't end up maintaining both
- Make sure the pybind11 bindings are being installed correctly when we create debs
- It would be nice not to waste all the effort we did to create SWIG bindings. How much effort do you think it would be to move them to the Ruby folder? We don't need to add tests, I think that would be too much work, right?
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…botics/ign-math into ahcorde/math/pybind11
Contributor
Author
|
@scpeters this is ready for another review |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
scpeters
reviewed
Dec 15, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
scpeters
reviewed
Dec 15, 2021
Member
scpeters
left a comment
There was a problem hiding this comment.
just some minor comments related to comments and doc-strings, looks good!
| "Return the absolute dot product of this vector and " | ||
| "another vector. This is similar to the Dot function, except the " | ||
| "absolute value of each component of the vector is used.") | ||
| .def("abs", &Class::Abs, " Get the absolute value of the vector") |
Member
There was a problem hiding this comment.
nit: leading whitespace in doc-string
scpeters
approved these changes
Dec 16, 2021
Member
scpeters
left a comment
There was a problem hiding this comment.
looks great!
please edit the commit message when squash+merging, thanks!
scpeters
added a commit
to scpeters/gz-math
that referenced
this pull request
Dec 22, 2021
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/gz-math
that referenced
this pull request
Jan 10, 2022
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jan 10, 2022
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
This is a draft PR tothat create wrappers for Vector2, 3 and 4 with pybind11
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge