Skip to content

Migrate modes into parsetree#1

Closed
freemagma wants to merge 61 commits intoparsetree.migrate-modalityfrom
parsetree.migrate-modes
Closed

Migrate modes into parsetree#1
freemagma wants to merge 61 commits intoparsetree.migrate-modalityfrom
parsetree.migrate-modes

Conversation

@freemagma
Copy link
Copy Markdown
Owner

No description provided.

@freemagma freemagma marked this pull request as ready for review May 17, 2024 20:28
Charlie Gunn and others added 4 commits May 22, 2024 15:16
* Add mixed block docs

* Reword

* Update ocaml/jane/doc/extensions/unboxed-types/index.md

Co-authored-by: Xavier Clerc <xclerc@users.noreply.github.com>

* Suggestions from review

* Fix from @TheNumbat's review

---------

Co-authored-by: Xavier Clerc <xclerc@users.noreply.github.com>
mshinwell and others added 27 commits June 13, 2024 19:35
Revert "Fix CSE equations on params (oxcaml#2628)"

This reverts commit 7676c07.
(cherry picked from commit 70ec392)
* Stop using exceptions for control flow in camlinternalOO

* @lthls review comment
* Advise against new bytecode instrs

* Work around the script that parses instruct.h
…ed compiler (oxcaml#2695)

* Add `opnames.h` to caml directory of installed compiler

* Add  to caml directory, and put  in the proper caml directory instead of top-level
* Small simplification to the new add_gadt_equation

* Add backtracking

* Add tests for mcomp

* Check kinds in mcomp

* Chris's suggestions
Migrate modality annotations (on label declarations / constructor fields) away from Jane_syntax and into the parsetree proper

---------

Co-authored-by: Charlie Gunn <cgunn@janestreet.com>
Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
Add the ability to compile a module declaring that it is suitable to pass as the argument to a module taking a given parameter. Essentially the module is now checked against two different signatures (its own .mli and the parameter, which of course must be a supertype).
This ensures that we don't forget to join head types when several
parameters are all aliases of each other without a common alias
in the environment at fork
* Fix line number directives in stdlib

* Add missing directive from thread.mli

* Update tests due to line number change
* fix modes in typecore

* fix tests
@freemagma
Copy link
Copy Markdown
Owner Author

I responded to all your feedback (either by doing the suggestion and resolving, or leaving a comment), but I'm going to close this PR so I can open one in the main repo against main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.