Migrate modes into parsetree#1
Closed
freemagma wants to merge 61 commits intoparsetree.migrate-modalityfrom
Closed
Migrate modes into parsetree#1freemagma wants to merge 61 commits intoparsetree.migrate-modalityfrom
freemagma wants to merge 61 commits intoparsetree.migrate-modalityfrom
Conversation
added 11 commits
April 18, 2024 11:15
… parsetree.migrate-modes
… parsetree.migrate-modes
riaqn
reviewed
Apr 30, 2024
added 9 commits
May 1, 2024 17:34
… in some cases in the parser
… parsetree.migrate-modes
… parsetree.migrate-modes
… parsetree.migrate-modes
* Add mixed block docs * Reword * Update ocaml/jane/doc/extensions/unboxed-types/index.md Co-authored-by: Xavier Clerc <xclerc@users.noreply.github.com> * Suggestions from review * Fix from @TheNumbat's review --------- Co-authored-by: Xavier Clerc <xclerc@users.noreply.github.com>
… parsetree.migrate-modes
riaqn
reviewed
Jun 9, 2024
riaqn
reviewed
Jun 9, 2024
riaqn
reviewed
Jun 9, 2024
riaqn
reviewed
Jun 9, 2024
ocaml/testsuite/tests/parsetree/locations_test.compilers.reference
Outdated
Show resolved
Hide resolved
Revert "Fix CSE equations on params (oxcaml#2628)" This reverts commit 7676c07.
(cherry picked from commit 70ec392)
* Stop using exceptions for control flow in camlinternalOO * @lthls review comment
* Advise against new bytecode instrs * Work around the script that parses instruct.h
…ed compiler (oxcaml#2695) * Add `opnames.h` to caml directory of installed compiler * Add to caml directory, and put in the proper caml directory instead of top-level
* Small simplification to the new add_gadt_equation * Add backtracking * Add tests for mcomp * Check kinds in mcomp * Chris's suggestions
Migrate modality annotations (on label declarations / constructor fields) away from Jane_syntax and into the parsetree proper --------- Co-authored-by: Charlie Gunn <cgunn@janestreet.com> Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com>
Add the ability to compile a module declaring that it is suitable to pass as the argument to a module taking a given parameter. Essentially the module is now checked against two different signatures (its own .mli and the parameter, which of course must be a supertype).
…lot in common, but not all (oxcaml#2649)
…xcaml#2683) * Regression test with bad output * Fix
This ensures that we don't forget to join head types when several parameters are all aliases of each other without a common alias in the environment at fork
This reverts commit 7c8b3dc.
* Fix line number directives in stdlib * Add missing directive from thread.mli * Update tests due to line number change
* fix modes in typecore * fix tests
Owner
Author
|
I responded to all your feedback (either by doing the suggestion and resolving, or leaving a comment), but I'm going to close this PR so I can open one in the main repo against main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.