Conversation
2e0b10a to
f915bf6
Compare
f915bf6 to
d04c027
Compare
Collaborator
|
@gretay-js will review this one. |
gretay-js
requested changes
May 23, 2024
Contributor
gretay-js
left a comment
There was a problem hiding this comment.
I compared Cfg_polling to Polling and they do the same thing, as far as I can tell, assuming correctness of Cfg_loop_infos.compute_back_edges, except on exceptional return from a function (easy fix, see comments).
- Can you please rebase this PR? The old diff confusingly includes #1927 that has been merged.
- Reminder about #2228. It becomes important for performance with runtime5 when we turn on poll insertion, as far as I remember from an upstream discussion (can't find the link, sorry). A small change around
Cfg_to_linear.needs_starting_labelis probably enough for backedges to implement it. If it's not obvious, we should at least have a comment there. We will of course do more benchmarking later, and if it turns out that this optimization is not significant, we can removereturn_labelfromIPolland simplifyemit.mlphandling ofIPoll. - Please port comments such as this from
polling.mltocfg_polling.ml - Does error handling need to be ported? I'm mostly worried about forgetting to copy
report_errorandregister_error_of_exnover if we removePolling. Maybe it's okay as is if there is a test that would fail. Alternatively, this PR can just move the shared code, includingreport_error, fromPollingover toCfg_polling.
Contributor
Author
It is not necessary because the exception in |
gretay-js
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Early draft, with very little testing so far.)