Skip to content

Reapply "Fix CSE equations on params" (#2690)#2707

Merged
Ekdohibs merged 1 commit intooxcaml:mainfrom
Ekdohibs:cse-equations
Jun 24, 2024
Merged

Reapply "Fix CSE equations on params" (#2690)#2707
Ekdohibs merged 1 commit intooxcaml:mainfrom
Ekdohibs:cse-equations

Conversation

@Ekdohibs
Copy link
Copy Markdown
Contributor

Reopening the pull request, now that #2705 is merged.

Copy link
Copy Markdown
Contributor

@lthls lthls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, and the new test from #2705 is passing.

@lthls
Copy link
Copy Markdown
Contributor

lthls commented Jun 21, 2024

Note: the commit reads as "Reapply ... #2690", I think it should be "Reapply ... #2628" (Or "Revert #2690").

@Ekdohibs
Copy link
Copy Markdown
Contributor Author

Interesting, it seems like git revert did something strange. I'll fix the title when merging.

@Ekdohibs Ekdohibs merged commit 998f12e into oxcaml:main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants