Fix a bug in slot_offsets when two separate sets of closures have a slot in common, but not all#2649
Merged
Ekdohibs merged 1 commit intooxcaml:mainfrom Jun 19, 2024
Merged
Conversation
…lot in common, but not all
Collaborator
|
Please add a test for this... |
Contributor
Author
|
I'm not sure how to add a test, given it's something that isn't generated by the compiler as of now, and this can't be tested by flexpect either. |
Contributor
Author
|
So, this fixes a bug, but there are other remaining. Indeed, we cannot put space between function slots in set of closures, as |
Gbury
approved these changes
Jun 10, 2024
Contributor
|
I'll look at the problem with consecutive slots as soon as I have the time. |
Contributor
Author
|
The consecutive slots problem has been addressed in #2674. |
TheNumbat
pushed a commit
that referenced
this pull request
Jun 21, 2024
…lot in common, but not all (#2649)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #2642.