Add [Deleted_code] case for code ids in set of closures.#2642
Merged
mshinwell merged 9 commits intooxcaml:mainfrom Jul 2, 2024
Merged
Add [Deleted_code] case for code ids in set of closures.#2642mshinwell merged 9 commits intooxcaml:mainfrom
mshinwell merged 9 commits intooxcaml:mainfrom
Conversation
lthls
reviewed
Jun 3, 2024
be04378 to
8f5531c
Compare
Gbury
requested changes
Jun 20, 2024
lthls
reviewed
Jun 25, 2024
lthls
reviewed
Jun 25, 2024
lthls
reviewed
Jun 25, 2024
Gbury
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for #2213. It adds a way to specify that some code ids in a set of closures have been deleted, and the closure therefore does not need a code pointer (but the function slot is still used for projections, and the closure still exists). For now, we do not change the layout and simply put a zero instead of the code id; in the future we can make slot_offsets share the slot as much as possible.