Merged
Conversation
cb08d12 to
3c3d621
Compare
47dd842 to
3101f13
Compare
57f6ee1 to
b996581
Compare
5a38036 to
88d75d1
Compare
Ekdohibs
commented
Jul 12, 2024
Ekdohibs
commented
Oct 10, 2024
Ekdohibs
commented
Oct 10, 2024
Ekdohibs
commented
Oct 10, 2024
Ekdohibs
commented
Oct 10, 2024
Ekdohibs
commented
Oct 10, 2024
Ekdohibs
commented
Oct 10, 2024
Ekdohibs
commented
Oct 11, 2024
mshinwell
approved these changes
Oct 30, 2024
Collaborator
mshinwell
left a comment
There was a problem hiding this comment.
As discussed, we're going to merge this - everything outside the reaper/ directory is fully reviewed, and we will continue with the code review of that directory separately. This should make testing easier; we think this is in a pretty good state, in any case.
bclement-ocp
added a commit
to bclement-ocp/oxcaml
that referenced
this pull request
Jul 15, 2025
Since the reaper (oxcaml#2213) has been merged, the `-dfexpr` flag accidentally prints twice. Fix the logic to only print it once (after the reaper if enabled, to mimic the `-dflambda` flag).
bclement-ocp
added a commit
that referenced
this pull request
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, written with @chambart, adds a first version of a global pass executed after simplify, used to perform some cleanup work made possible when we look at a compilation unit globally.
While the code is not production-ready yet and can be improved (and the code produced can be further improved as well), it should be ready for a first round of testing.