Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Feb 28, 2022

test-exempt: configuration

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 8b95cd6 into master Mar 1, 2022
@fluttergithubbot fluttergithubbot deleted the CaseyHillers-patch-2 branch March 1, 2022 00:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
renyou pushed a commit to renyou/flutter that referenced this pull request Mar 7, 2022
renyou added a commit that referenced this pull request Mar 7, 2022
* Cherrypick engine d04a8a50dabd4e65e8296443db8b178fb628af85

* [cirrus] Refresh GCP service account (#99301)

Co-authored-by: Casey Hillers <chillers@google.com>
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
CaseyHillers pushed a commit that referenced this pull request Mar 25, 2022
* manual update of engine version

* [cirrus] Refresh GCP service account (#99301)

* Upgrade android sdk for ci.yaml tests to 31 (#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
leandro-pereira added a commit to leandro-pereira/flutter that referenced this pull request Apr 20, 2022
…er#100664)

* manual update of engine version

* [cirrus] Refresh GCP service account (flutter#99301)

* Upgrade android sdk for ci.yaml tests to 31 (flutter#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutter#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
devoarm pushed a commit to devoarm/flutter that referenced this pull request May 11, 2022
…er#100664)

* manual update of engine version

* [cirrus] Refresh GCP service account (flutter#99301)

* Upgrade android sdk for ci.yaml tests to 31 (flutter#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutter#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants