Skip to content

Remove gradle_plugin_light_apk_test tasks that are irrelevant #100087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 14, 2022
Merged

Remove gradle_plugin_light_apk_test tasks that are irrelevant #100087

fluttergithubbot merged 1 commit into from
Mar 14, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Mar 14, 2022

Fixes #97956 by removing the task on Windows.
Also, on macOS.

keyonghan
keyonghan approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit b7a64b7 into flutter:master Mar 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
5cf5fd0 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
cbe8ce6 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
6f3b05c 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
0f500bf 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
91552d4 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
71725da 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
c4ee44c 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
7c6dcba 
…flutter/flutter#100087)
godofredoc added a commit that referenced this pull request Mar 15, 2022
@godofredoc
Roll version 1e773244d1cbd28fe9adf4d5fff5d9b6f458b8fb (#100100)
db5b5c7 
* Roll version 1e773244d1cbd28fe9adf4d5fff5d9b6f458b8fb

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (#100087)

Co-authored-by: Emmanuel Garcia <egarciad@google.com>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
c23e65a 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
a425b08 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
8db43fa 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
97d20a1 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
c322874 
…flutter/flutter#100087)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
b7a64b7 Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
9b8e2c5 
…flutter/flutter#100087)
XilaiZhang pushed a commit to XilaiZhang/flutter that referenced this pull request Mar 16, 2022
@XilaiZhang
Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutte…
b8e17c7 
…r#100087)
XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Mar 16, 2022
@XilaiZhang
Revert "Remove gradle_plugin_light_apk_test tasks that are irrelevant (…
4a47d86 
…flutter#100087)"

This reverts commit b8e17c7.
XilaiZhang pushed a commit to XilaiZhang/flutter that referenced this pull request Mar 16, 2022
@XilaiZhang
Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutte…
c319b0d 
…r#100087)
XilaiZhang added a commit that referenced this pull request Mar 16, 2022
@XilaiZhang
[flutter_releases] Flutter beta 2.12.0-4.1.pre Framework Cherrypicks (#…
680962a 
…100192)

* 'Update Engine revision to e9f57b5d0f56ea3288c7206f56717ca19ffe5358 for beta release 2.12.0-4.1.pre'

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (#100087)

* an empty commit

Co-authored-by: Emmanuel Garcia <egarciad@google.com>
CaseyHillers pushed a commit that referenced this pull request Mar 25, 2022
@itsjustkevin @GaryQian
[flutter_releases] Flutter stable 2.10.4 Framework Cherrypicks (#100664)
c860cba 
* manual update of engine version

* [cirrus] Refresh GCP service account (#99301)

* Upgrade android sdk for ci.yaml tests to 31 (#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
leandro-pereira added a commit to leandro-pereira/flutter that referenced this pull request Apr 20, 2022
@leandro-pereira @GaryQian
[flutter_releases] Flutter stable 2.10.4 Framework Cherrypicks (flutt…
d2ca195 
…er#100664)

* manual update of engine version

* [cirrus] Refresh GCP service account (flutter#99301)

* Upgrade android sdk for ci.yaml tests to 31 (flutter#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutter#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
devoarm pushed a commit to devoarm/flutter that referenced this pull request May 11, 2022
@itsjustkevin @GaryQian @610112230006
[flutter_releases] Flutter stable 2.10.4 Framework Cherrypicks (flutt…
935f8ea 
…er#100664)

* manual update of engine version

* [cirrus] Refresh GCP service account (flutter#99301)

* Upgrade android sdk for ci.yaml tests to 31 (flutter#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutter#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows gradle_plugin_light_apk_test is 2.00% flaky

3 participants

@blasten @keyonghan @fluttergithubbot