Skip to content

Conversation

@itsjustkevin
Copy link
Contributor

Flutter stable 2.10.3 Framework

Scheduled Cherrypicks

  • none

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Mar 24, 2022
@itsjustkevin itsjustkevin requested a review from godofredoc March 24, 2022 01:21
@itsjustkevin itsjustkevin reopened this Mar 24, 2022
@CaseyHillers
Copy link
Contributor

Before merging, we need to wait for https://flutter-review.googlesource.com/c/recipes/+/28280 to be merged

@CaseyHillers
Copy link
Contributor

Landing this as the Mac tool_integration_tests_3_4, flaked, and this rerun failed to get an update from GitHub.

@CaseyHillers CaseyHillers merged commit c860cba into flutter:flutter-2.8-candidate.16 Mar 25, 2022
@itsjustkevin itsjustkevin deleted the cherrypicks-flutter-2.8-candidate.16 branch March 25, 2022 12:22
leandro-pereira added a commit to leandro-pereira/flutter that referenced this pull request Apr 20, 2022
…er#100664)

* manual update of engine version

* [cirrus] Refresh GCP service account (flutter#99301)

* Upgrade android sdk for ci.yaml tests to 31 (flutter#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutter#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
devoarm pushed a commit to devoarm/flutter that referenced this pull request May 11, 2022
…er#100664)

* manual update of engine version

* [cirrus] Refresh GCP service account (flutter#99301)

* Upgrade android sdk for ci.yaml tests to 31 (flutter#98638)

* Remove gradle_plugin_light_apk_test tasks that are irrelevant (flutter#100087)

Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Gary Qian <garyq@google.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants