-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Reattempt: Restores surface size and view configuration in the postTest of test binding #87297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reattempt: Restores surface size and view configuration in the postTest of test binding #87297
Conversation
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this blank line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove a blank line?
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Probably needs a rebase to make the check happy)
…flutter#87240)" (flutter#87258)" This reverts commit ccf6f03. New impl Remove temp Format
42b50fa to
f9a0be8
Compare
… binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293) This reverts commit 91f8b6b.
… of test binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293)" This reverts commit 31d0787.
… of test binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293)" This reverts commit 31d0787.
This is a reattempt to fix #87194.
The previous attempt #87240 was reverted because many internal tests was written in a way that sets the view configuration at the beginning of a file and expect to use it throughout the file, which was broken by the previous method.
This PR restores the surface size and the view configuration in the following strategy:
postTest, since the surface size can not be changed out of tests.reset(the pre-test hook), and is restored to that value atpostTest.I tested this change against some previously failing tests and they have been passing.
This PR also removes the temporary teardown cleanup in
viewport_test.dart.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.