Restores surface size in the postTest of test binding #87240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dkwingsmt
added a commit
that referenced
this pull request
Jul 29, 2021
This reverts commit 7707f42.
dkwingsmt
added a commit
that referenced
this pull request
Jul 29, 2021
Merged
8 tasks
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Aug 4, 2021
…flutter#87240)" (flutter#87258)" This reverts commit ccf6f03. New impl Remove temp Format
dkwingsmt
added a commit
that referenced
this pull request
Aug 11, 2021
dkwingsmt
added a commit
that referenced
this pull request
Aug 16, 2021
dkwingsmt
added a commit
that referenced
this pull request
Aug 16, 2021
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Aug 19, 2021
… binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293) This reverts commit 91f8b6b.
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Sep 8, 2021
… of test binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293)" This reverts commit 31d0787.
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jul 20, 2022
… of test binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293)" This reverts commit 31d0787.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #87194 by setting the surfaceSize to null as well as recreating the view configuration during
postTest.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.