Skip to content

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jul 29, 2021

Reverts #87240 due to internal breakage.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 29, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jul 29, 2021
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt merged commit ccf6f03 into master Jul 29, 2021
@dkwingsmt dkwingsmt deleted the revert-87240-restore-surface-size branch July 29, 2021 08:50
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Aug 4, 2021
dkwingsmt added a commit that referenced this pull request Aug 11, 2021
dkwingsmt added a commit that referenced this pull request Aug 16, 2021
dkwingsmt added a commit that referenced this pull request Aug 16, 2021
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Sep 8, 2021
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants