Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 21, 2020

Another attempt at #59009.

  1. Reverted the corruption to the microbenchmark workspace Revert "Build iOS apps using Swift Packages" #68546
  2. Ran migrator on complex_layout, platform_views_layout, and platform_views_layout_hybrid_composition
  3. Update EFQRCode version in the ios_app_with_extensions Podfile.
  4. I was able to reproduce the issue from Revert "Build iOS apps using Swift Packages" #59025 on Xcode 11 which caused the first revert. Confirm it passes on this PR.

Description

Swift packages cannot be added to a newly created Flutter iOS app due to the Xcode project settings (not workspace) being set to the "legacy" build location. Update to the "default" Xcode build location.
73312223-10950180-41dd-11ea-9a66-98d3a140f0fd

Screen Shot 2020-06-02 at 1 56 59 PM

Update templates, add tool migrator, let tool upgrade all examples and integration tests.

Related Issues

Fixes #57083
Related to #49654
Unblocks #72482

Redux of #59009

Tests

  • Migrator tests

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Dec 21, 2020
@jmagman jmagman self-assigned this Dec 21, 2020
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 21, 2020
@google-cla google-cla bot added the cla: yes label Dec 21, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 28db5a0 into flutter:master Jan 6, 2021
@jmagman jmagman deleted the spm-legacy branch January 6, 2021 21:54
jmagman added a commit that referenced this pull request Jan 6, 2021
jmagman added a commit that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

2 participants