Skip to content

Revert "Build iOS apps using Swift Packages" #73437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jan 6, 2021
Merged

Revert "Build iOS apps using Swift Packages" #73437

jmagman merged 1 commit into from
Jan 6, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 6, 2021

Reverts #72761

ios_app_with_extensions_test failed

stdout:     [!] CocoaPods could not find compatible versions for pod "EFQRCode":
stdout:       In Podfile:
stdout:         EFQRCode (= 6.0)
stdout: 
stdout:     None of your spec sources contain a spec satisfying the dependency: `EFQRCode (= 6.0)`.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 6, 2021
@google-cla google-cla bot added the cla: yes label Jan 6, 2021
@jmagman jmagman merged commit 74d5810 into master Jan 6, 2021
@jmagman jmagman deleted the revert-72761-spm-legacy branch January 6, 2021 23:04
@jmagman
Copy link
Member Author

jmagman commented Jan 6, 2021

Green the tree.

christopherfujino
christopherfujino reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jan 7, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @christopherfujino