Skip to content

Revert "Build iOS apps using Swift Packages" #59025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jun 8, 2020
Merged

Revert "Build iOS apps using Swift Packages" #59025

jmagman merged 1 commit into from
Jun 8, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 8, 2020

Reverts #59009

So perplexing, ios_app_with_extensions_test fails in devicelab and works fine on my machine.

2020-06-08T14:04:18.766494: stdout: Building io.flutter.extensionTest for device (ios-release)...
2020-06-08T14:04:19.802439: stderr: 
2020-06-08T14:04:19.808189: stderr: Oops; flutter has exited unexpectedly: "ProcessException: Process exited abnormally:
stderr: xcodebuild: error: Could not resolve package dependencies:
stderr:   Packages are not supported when using legacy build locations, but the current project has them enabled.
stderr:   Command: /usr/bin/xcodebuild -list".
2020-06-08T14:04:22.869059: stderr: A crash report has been written to /private/var/folders/mv/lj_4rn9d1499dlqfgvd0x0080000gn/T/ios_app_with_extensions_testFlAJtP/app_with_extensions/flutter_01.log.

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 8, 2020
@jmagman jmagman merged commit 023532d into master Jun 8, 2020
@jmagman jmagman deleted the revert-59009-spm-build-loc branch June 8, 2020 22:45
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
@jmagman @zljj0818
Revert "Build iOS apps using Swift Packages (flutter#59009)" (flutter…
e80bc9b 
…#59025)

This reverts commit 43e2808.
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Revert "Build iOS apps using Swift Packages (flutter#59009)" (flutter…
c847da9 
…#59025)

This reverts commit 43e2808.
@jmagman jmagman mentioned this pull request Dec 21, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @googlebot @fluttergithubbot