Re-enable the Dart Development Service (DDS)#64671
Merged
Merged
Conversation
bkonyi
commented
Aug 26, 2020
Contributor
|
what remains to be done after this PR? Just web support? |
Contributor
Author
Yup, that should be it. DDS has SSE support now, so it's just a matter of wiring things up hopefully. |
This change re-enables DDS and outputs the DDS URI in place of the VM service URI on the console. If --disable-dds is not provided, --host-vmservice-port will be used to determine the port for DDS rather than the host port for the VM service, which will instead be randomly chosen.
bkonyi
added a commit
that referenced
this pull request
Aug 28, 2020
bkonyi
added a commit
that referenced
this pull request
Aug 28, 2020
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 29, 2020
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 29, 2020
bkonyi
added a commit
that referenced
this pull request
Aug 31, 2020
mehmetf
added a commit
that referenced
this pull request
Aug 31, 2020
mehmetf
added a commit
that referenced
this pull request
Aug 31, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This change re-enables DDS and outputs the DDS URI in place of the VM service URI on the console. If --disable-dds is not provided, --host-vmservice-port will be used to determine the port for DDS rather than the host port for the VM service, which will instead be randomly chosen.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…flutter#64797) This reverts commit d7d1241.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…flutter#64802) * Reland "Re-enable the Dart Development Service (DDS) (flutter#64671)" This reverts commit 2ae25cc. * Fix MDNS building Observatory URI with port 0 instead of forwarding the device port * Added MDNS test
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…#64671)" (flutter#64802)" (flutter#64845) This reverts commit eef0050.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…flutter#64847) This reverts commit 2436de1.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…#64671)" (flutter#64847)" (flutter#64981) This reverts commit c8f234d.
bkonyi
added a commit
that referenced
this pull request
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change re-enables DDS and outputs the DDS URI in place of the VM service URI on the console. If --disable-dds is not provided, --host-vmservice-port will be used to determine the port for DDS rather than the host port for the VM service, which will instead be randomly chosen.