Reland "Re-enable the Dart Development Service (DDS) (#64671)"#64802
Merged
Conversation
This reverts commit 2ae25cc.
jonahwilliams
left a comment
Contributor
There was a problem hiding this comment.
could you add some unit test coverage for the mdns change, or something that would have otherwise caught that error on presubmit?
Contributor
Author
Sure, let me take a look. Shouldn't be an issue. |
Contributor
Author
Done. |
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 29, 2020
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 29, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…flutter#64802) * Reland "Re-enable the Dart Development Service (DDS) (flutter#64671)" This reverts commit 2ae25cc. * Fix MDNS building Observatory URI with port 0 instead of forwarding the device port * Added MDNS test
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…#64671)" (flutter#64802)" (flutter#64845) This reverts commit eef0050.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS device lab bots were failing since the MDNS code was relying on
hostVmServicePortbeing null to actually forward the device port, causing DDS to attempt to connect tohttp://localhost:0. When DDS is enabled,hostVmServicePortis set to 0 to represent that the VM service should be forwarded to any port.