Whitelist adb.exe heap corruption exit code. #33951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In android platform tools 29.0.0 adb.exe shell seems to be exiting with heap corruption exit code, otherwise producing results as expected. This PR whitelists this exit code on Windows. Fixes flutter#33938.
jason-simmons
approved these changes
Jun 6, 2019
|
|
||
| bool allowHeapCorruptionOnWindows(int exitCode) { | ||
| // In platform tools 29.0.0 adb.exe seems to be ending with this heap | ||
| // corruption error code onseemingly successful termination. |
zanderso
reviewed
Jun 6, 2019
| return exitCode == -1073740940 && platform.isWindows; | ||
| } | ||
|
|
||
| String runMostlyCheckedSync( |
Member
There was a problem hiding this comment.
These wrappers are only used to run adb, so how about renaming something like 'runAdbSync' and 'runAdbAsync'. You could also fold in the otherwise repeated calls to adbCommandForDevice
zanderso
reviewed
Jun 6, 2019
| return <String>[getAdbPath(androidSdk), '-s', id]..addAll(args); | ||
| } | ||
|
|
||
| String runAdbMostlyCheckedSync( |
Member
There was a problem hiding this comment.
runAdbMostlyChecked -> runAdbChecked to avoid a rename when the whitelist is no longer needed.
zanderso
approved these changes
Jun 6, 2019
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 7, 2019
* master: (25 commits) Increase daemon protocol version for getSupportedPlatforms (flutter#33980) skip web test on crazy import (flutter#34017) Compatibility pass on flutter/foundation tests for JavaScript compilation. (1) (flutter#33349) 0602dbb Roll src/third_party/dart 9dcb026b26..6e0d978505 (72 commits) (flutter#34027) Add chrome stable to dockerfile and web shard (flutter#33787) Codegen an entrypoint for flutter web applications (flutter#33956) Revert "Reland "Text inline widgets, TextSpan rework" (flutter#33946)" (flutter#34002) Revert "Re-add deprecated method for plugin migration compatibility. (flutter#34006)" (flutter#34022) Remove print (flutter#34004) Manual roll the engine to land the timing API (flutter#33989) Make plugins Swift-first on macOS (flutter#33997) Re-add deprecated method for plugin migration compatibility. (flutter#34006) make sure version check includes hotfixes (flutter#33459) Respond to AndroidView focus events. (flutter#33901) Add 'doctor' support for Windows (flutter#33872) Add use_frameworks to macOS Podfile template (flutter#33987) [Material] Create a themable Range Slider (continuous and discrete) (flutter#31681) Updating names to correct versioning convention (flutter#33865) Whitelist adb.exe heap corruption exit code. (flutter#33951) [flutter_tool] Fix 'q' for Fuchsia profile/debug mode (flutter#33846) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With android platform tools 29.0.0 adb.exe(so on Windows only) seems to be exiting with heap corruption exit code -1073740940 (0xc0000374), otherwise producing results as expected. This PR whitelists this exit code on Windows.