Reland "Text inline widgets, TextSpan rework" #33946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// The [textDirection], if null, defaults to the ambient [Directionality], | ||
| /// which in that case must not be null. | ||
| const RichText({ | ||
| RichText({ |
Contributor
There was a problem hiding this comment.
This is a breaking change
Contributor
Author
There was a problem hiding this comment.
Yeah, this was announced already.
Contributor
Author
There was a problem hiding this comment.
Should be able to replace instances of RichText with Text.rich to migrate.
Contributor
|
Removing the |
Contributor
Author
|
Yes, breaking change procedure has been followed, about 2 weeks ago. #30069 has more history on this change. |
goderbauer
approved these changes
Jun 5, 2019
| // specified. | ||
| void _layoutChildren(BoxConstraints constraints) { | ||
| RenderBox child = firstChild; | ||
| if (childCount == 0) { |
Member
There was a problem hiding this comment.
Why not do this as the first thing in the method?
Contributor
Author
There was a problem hiding this comment.
Oops that's what I meant it to do.
GaryQian
added a commit
to GaryQian/flutter
that referenced
this pull request
Jun 6, 2019
This reverts commit 14414f3.
GaryQian
added a commit
that referenced
this pull request
Jun 7, 2019
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 7, 2019
* master: (25 commits) Increase daemon protocol version for getSupportedPlatforms (flutter#33980) skip web test on crazy import (flutter#34017) Compatibility pass on flutter/foundation tests for JavaScript compilation. (1) (flutter#33349) 0602dbb Roll src/third_party/dart 9dcb026b26..6e0d978505 (72 commits) (flutter#34027) Add chrome stable to dockerfile and web shard (flutter#33787) Codegen an entrypoint for flutter web applications (flutter#33956) Revert "Reland "Text inline widgets, TextSpan rework" (flutter#33946)" (flutter#34002) Revert "Re-add deprecated method for plugin migration compatibility. (flutter#34006)" (flutter#34022) Remove print (flutter#34004) Manual roll the engine to land the timing API (flutter#33989) Make plugins Swift-first on macOS (flutter#33997) Re-add deprecated method for plugin migration compatibility. (flutter#34006) make sure version check includes hotfixes (flutter#33459) Respond to AndroidView focus events. (flutter#33901) Add 'doctor' support for Windows (flutter#33872) Add use_frameworks to macOS Podfile template (flutter#33987) [Material] Create a themable Range Slider (continuous and discrete) (flutter#31681) Updating names to correct versioning convention (flutter#33865) Whitelist adb.exe heap corruption exit code. (flutter#33951) [flutter_tool] Fix 'q' for Fuchsia profile/debug mode (flutter#33846) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the previous versions of this change: #30069 and #33794
This reland version includes minor performance fixes in
TextPainter.setPlaceholderDimensions(). We now ignore placeholderDimensions when there are no placeholders in the textspan tree.