feat: linux_analyze in a workflow by jtmcdole · Pull Request #187889 · flutter/flutter

jtmcdole · 2026-06-11T21:09:29Z

Will run the same as a LUCI recipe, but in GitHub actions
Updated composite-flutter-setup to install/cache ktlint.
Should detect and wait for engine builds before running

Successful run: https://github.com/flutter/flutter/actions/runs/27382050611/job/80920878955?pr=187889#annotation:15:3

Pre-launch Checklist

- Will run the same LUCI recipie in an action - Should detect and wait for engine builds before running

gemini-code-assist · 2026-06-11T21:09:37Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

- location of engin.realm. - better file checking for engine files

gemini-code-assist

Code Review

This pull request adds steps to cache, download, and install ktlint 1.5.0 in the composite Flutter setup action. Feedback recommends installing ktlint into a temporary directory outside the workspace to avoid introducing untracked files that could fail CI checks, and using the -f flag with curl to prevent silent download failures.

jtmcdole · 2026-06-12T18:34:01Z

Nice: cause the license headers before I ever added the CICD label. Good bot.

jtmcdole · 2026-06-12T20:28:34Z

Removed from the merge queue:

Waiting on an engine build worked - 👍🏻
Immediately setting engine.realm for a non-checked out tree: 👎🏻
The realm should not have been touched for a MQ build.

Run echo "flutter_archives_v2" > bin/cache/engine.realm
  echo "flutter_archives_v2" > bin/cache/engine.realm
  shell: /usr/bin/bash -e {0}

Will fix.

jtmcdole · 2026-06-12T21:53:43Z

Moving to draft so I can test a couple of scenarios without having CICD automatically kicked off.

jtmcdole · 2026-06-12T21:54:53Z

No Engine Test: https://github.com/flutter/flutter/actions/runs/27445095107/job/81128144323?pr=187889

Next up; I'll just touch an engine file and watch it wait.

For testing with ACT in a non-worktree environment. Worktrees have to do a hack: ```bash # From inside /Users/codefu/src/flutter/linux_analyze # 1. Remove the worktree pointer file rm .git # 2. Copy the objects from the bare repository to be the new .git folder cp -R ../.bare .git # 3. Overlay your specific worktree state (index, HEAD, branch info) cp -a .git/worktrees/linux_analyze/. .git/ # 4. Clean up worktree-specific files so Git treats it as a normal repo rm -rf .git/worktrees rm -f .git/commondir rm -f .git/gitdir # 5. Turn off the bare repository flag git config core.bare false # 6. Verify your uncommitted changes and branch are safe! git status ```

jtmcdole · 2026-06-12T23:04:07Z

We no longer set the engine.realm; that's already done based on an environment variable.
We do set FLUTTER_REALM if we're a pull request AND the engine files changed

flutter/flutter@5827d5f...3a0420c 2026-06-16 Rusino@users.noreply.github.com Implement font fallback (flutter/flutter#187520) 2026-06-16 amhurtado@protonmail.com Add FlatBuffers Verifier checks to Impeller asset loading (flutter/flutter#187878) 2026-06-16 engine-flutter-autoroll@skia.org Roll Packages from aa964a3 to 8286d39 (1 revision) (flutter/flutter#188067) 2026-06-16 engine-flutter-autoroll@skia.org Roll Skia from 9c2b83788409 to d7196b0b4939 (1 revision) (flutter/flutter#188066) 2026-06-16 engine-flutter-autoroll@skia.org Roll Skia from ef17057bb776 to 9c2b83788409 (1 revision) (flutter/flutter#188061) 2026-06-16 engine-flutter-autoroll@skia.org Roll Skia from 500025456bb5 to ef17057bb776 (1 revision) (flutter/flutter#188058) 2026-06-16 engine-flutter-autoroll@skia.org Roll Skia from cb1035ff14bf to 500025456bb5 (5 revisions) (flutter/flutter#188057) 2026-06-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TbB86Po_HDe1dvXvT... to VeLhhlDcod09NR4Hb... (flutter/flutter#188055) 2026-06-16 engine-flutter-autoroll@skia.org Roll Skia from 70acf6a5e7c9 to cb1035ff14bf (3 revisions) (flutter/flutter#188054) 2026-06-16 41930132+hellohuanlin@users.noreply.github.com [pv]skip non-tappable web view workaround on ios 26.4 (flutter/flutter#185424) 2026-06-16 mdebbar@google.com [web] RenderParagraph needs paint after a DPR change (flutter/flutter#186968) 2026-06-16 30870216+gaaclarke@users.noreply.github.com Adds gamma correction to windows text. (flutter/flutter#187871) 2026-06-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a platform view test to android_hardware_smoke_test (#187913)" (flutter/flutter#188051) 2026-06-15 awolff@google.com Add a platform view test to android_hardware_smoke_test (flutter/flutter#187913) 2026-06-15 codefu@google.com feat: linux_analyze in a workflow (flutter/flutter#187889) 2026-06-15 mdebbar@google.com [web] Changes to WebParagraph configuration (flutter/flutter#187188) 2026-06-15 matt.boetger@gmail.com Fail gracefully on Android AVD lock errors during startup (flutter/flutter#187200) 2026-06-15 bkonyi@google.com [flutter_tools] Fix flakiness in widget_preview_detection_test (flutter/flutter#187938) 2026-06-15 jason-simmons@users.noreply.github.com Exclude fuchsia-sdk/sdk/.build-id from the builder cache archive (flutter/flutter#187826) 2026-06-15 engine-flutter-autoroll@skia.org Roll Skia from c8d9f80f13e4 to 70acf6a5e7c9 (4 revisions) (flutter/flutter#188020) 2026-06-15 engine-flutter-autoroll@skia.org Roll Packages from b78ad83 to aa964a3 (7 revisions) (flutter/flutter#188021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fixes flutter#187817 - Will run the same as a LUCI recipe, but in GitHub actions - Updated composite-flutter-setup to install/cache ktlint. - Should detect and wait for engine builds before running Successful run: https://github.com/flutter/flutter/actions/runs/27382050611/job/80920878955?pr=187889#annotation:15:3 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.

feat: linux_analyze in a workflow

d88622a

- Will run the same LUCI recipie in an action - Should detect and wait for engine builds before running

flutter-dashboard Bot added the CICD Run CI/CD label Jun 11, 2026

jtmcdole marked this pull request as draft June 11, 2026 21:29

rename action to not stomp

b9185d8

github-actions Bot removed the CICD Run CI/CD label Jun 11, 2026

fix diff

c2820e5

flutter-dashboard Bot added the CICD Run CI/CD label Jun 11, 2026

Use SHA, not BASE - we don't want to test against a moving ref

474fe6f

github-actions Bot removed the CICD Run CI/CD label Jun 11, 2026

one more go ... who loves git?

574bb49

flutter-dashboard Bot added the CICD Run CI/CD label Jun 11, 2026

add ktlint

cb179fa

github-actions Bot removed the CICD Run CI/CD label Jun 11, 2026

jtmcdole added the CICD Run CI/CD label Jun 11, 2026

fix engine.realm

7b7819e

- location of engin.realm. - better file checking for engine files

github-actions Bot removed the CICD Run CI/CD label Jun 11, 2026

jtmcdole marked this pull request as ready for review June 11, 2026 23:44

jtmcdole added the CICD Run CI/CD label Jun 11, 2026

jtmcdole requested review from jmagman and zanderso June 11, 2026 23:45

gemini-code-assist Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread .github/actions/composite-flutter-setup/action.yml Outdated

zanderso reviewed Jun 12, 2026

View reviewed changes

Comment thread .github/actions/composite-flutter-setup/action.yml Outdated

Comment thread .github/workflows/tree-analyze.yml Outdated

jtmcdole added 2 commits June 12, 2026 10:40

update actions/cache sha; move ktlint to temp and check sha

3a41157

Extract some scripts

7830a75

github-actions Bot removed the CICD Run CI/CD label Jun 12, 2026

jtmcdole requested a review from zanderso June 12, 2026 18:30

Add headers

945eec7

flutter-dashboard Bot added the CICD Run CI/CD label Jun 12, 2026

jmagman reviewed Jun 12, 2026

View reviewed changes

Comment thread .github/actions/composite-flutter-setup/action.yml

jmagman reviewed Jun 12, 2026

View reviewed changes

Comment thread .github/workflows/tree-analyze.yml Outdated

jmagman reviewed Jun 12, 2026

View reviewed changes

Comment thread .github/actions/composite-flutter-setup/action.yml

jtmcdole removed this pull request from the merge queue due to a manual request Jun 12, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2026

don't write or use flutter_realm in the mq

a92c80e

jtmcdole dismissed zanderso’s stale review via a92c80e June 12, 2026 21:50

flutter-dashboard Bot added the CICD Run CI/CD label Jun 12, 2026

jtmcdole removed the CICD Run CI/CD label Jun 12, 2026

flutter-dashboard Bot added the CICD Run CI/CD label Jun 12, 2026

jtmcdole requested review from jmagman and zanderso June 12, 2026 23:02

jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2026

zanderso approved these changes Jun 15, 2026

View reviewed changes

auto-submit Bot added this pull request to the merge queue Jun 15, 2026

Merged via the queue into flutter:master with commit 69410eb Jun 15, 2026
174 of 175 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: linux_analyze in a workflow#187889

feat: linux_analyze in a workflow#187889
auto-submit[bot] merged 12 commits into
flutter:masterfrom
jtmcdole:linux_analyze

jtmcdole commented Jun 11, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jun 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jtmcdole commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot commented Jun 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

jtmcdole commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jtmcdole commented Jun 11, 2026 •

edited

Loading