[CP beta] Updates DEPS + cherry-picks required changes for 3.45.0-0.2.pre release#187872
Conversation
…gine (flutter#187268)" (flutter#187378) Includes: * a manual Dart roll to 3cdc25e8ffe98c61b36af485573639dc833b75cb * updates to `run_verify_binaries_codesigned_tests.dart` that match the current state of the Dart SDK binaries --------- Co-authored-by: Jacob MacDonald <jakemac@google.com> Co-authored-by: Alexander Aprelev <aam@google.com>
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the dependency override path for dart_mcp in engine/src/flutter/pubspec.yaml from ./third_party/dart/third_party/pkg/ai/pkgs/dart_mcp to ./third_party/ai/pkgs/dart_mcp. There are no review comments, and I have no feedback to provide.
…lutter#187013) - Don't pass VM snapshot to Dart_Initialize. - Don't expect kDart{Vm,Isolate}Snapshot{Data,Instructions} symbols defined. - Replace 4-symbol Dart_LoadELF with 2-symbol Dart_LoadELF2. Blocking: https://dart-review.googlesource.com/c/sdk/+/502780
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . I'm mostly looking at this at a high level as I'm not familiar with how the changes relate to the Dart beta. Thanks for listing out all of the commits in the description.
It looks like the CICD label check is stuck so you may need to push another commit unfortunately.
c03457b
into
flutter:flutter-3.45-candidate.0
Updates DEPS to update the Dart revision to aad8be4ce3077a809f0b4f3325c6d8a6908aad54 and makes the following changes that Dart version update (this list includes all of the commits in this PR!!):
airepository from their internal DEPS in dart-lang/sdk@06bdbd7 (cherry pick of #187378)unawaited_return_in_try_blockanalyzer errors caused by new Dart version (part of #186690)All of these fixes are included in this PR because their causes are a consequence of updating the Dart revision to the latest Dart beta (3.13.0-167.1.beta).
Part of #187787.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.