Manual Dart roll from 66873d2da857 to 84220a34788e#186812
Conversation
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the requiredSymbols list in AppleTestUtils by adding _kDartSnapshotData and _kDartSnapshotText. Feedback indicates that the old symbols _kDartIsolateSnapshotData and _kDartIsolateSnapshotInstructions should be removed to reflect renaming in the Dart SDK, and that _kDartSnapshotText is likely a typo for _kDartSnapshotInstructions.
|
autosubmit label was removed for flutter/flutter/186812, because - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)
….pre release (#187872) Updates DEPS to update the Dart revision to aad8be4ce3077a809f0b4f3325c6d8a6908aad54 and makes the following changes that Dart version update (this list includes all of the commits in this PR!!): | Commit | Reasoning | | ------------- | ------------- | |9cddb59 | New Dart version removed `ai` repository from their internal DEPS in dart-lang/sdk@06bdbd7 (cherry pick of #187378) | | a6fb7ec | Actual commit that updates Dart version 🎯 | | 527ebc7 | Required to compile the engine with the new Dart version (cherry pick of #187013) | | 37c44d7 | Also required to compile the engine with the new Dart version (cherry pick of #187091) | | aafb985 | Ignore; reverted in 03b6bf1 | | dc91998 | Update LICENSES according to new Dart version | | 2cd036e | Ignore; reverted in 03b6bf1 | | 50a3ace | Formats engine Dart files according to updated formatter in new version of Dart SDK (part of #186690) | | ec37bf7 | Updated snapshot symbol assertions as a consequence of dart-lang/sdk@d36adba (cherry pick of #186812) | | a46d1e8 | Same as above | | 5a21bc3 | Fixes new `unawaited_return_in_try_block` analyzer errors caused by new Dart version (part of #186690) | |03b6bf1 | Reverts unnecessary analysis errors I added earlier } All of these fixes are included in this PR because their causes are a consequence of updating the Dart revision to the latest Dart beta (3.13.0-167.1.beta). Part of #187787. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)