Remove use of deprecated API related to removal of the VM isolate.#187013
Conversation
45c0dea to
cb5002d
Compare
cb5002d to
17c646e
Compare
17c646e to
ad29d1a
Compare
|
This is a narrower change just to removed the deprecated APIs. I have a bigger clean up change in progress: #186407. |
There was a problem hiding this comment.
Code Review
This pull request refactors Dart VM and isolate snapshot handling by consolidating snapshot symbols and replacing the separate VM and isolate snapshot data/instructions with unified snapshot symbols (such as kDartSnapshotData and kDartSnapshotText). It updates the GN build files, C++ runtime sources, Fuchsia runner configurations, and Devicelab tests to align with these changes, including replacing Dart_LoadELF with Dart_LoadELF2. There are no review comments to address, and I have no additional feedback to provide.
|
autosubmit label was removed for flutter/flutter/187013, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
ad29d1a to
6da5400
Compare
|
autosubmit label was removed for flutter/flutter/187013, because - The status or check suite Linux linux_host_engine_ddm has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/flutter@b05a9d7...54e199a 2026-06-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jMR_VXQi07kAk8vbR... to q27k7_um1GvVrySZS... (flutter/flutter#187338) 2026-06-01 rmacnak@google.com Remove use of deprecated API related to removal of the VM isolate. (flutter/flutter#187013) 2026-06-01 116356835+AbdeMohlbi@users.noreply.github.com Improve `dependOnInheritedWidgetOfExactType` documentation to explain why it is bad to use it in initState (flutter/flutter#186216) 2026-06-01 chris@bracken.jp Revert "Move dart-lang/ai to a top level third party dependency in en… (flutter/flutter#187370) 2026-05-30 jakemac@google.com Move dart-lang/ai to a top level third party dependency in engine (flutter/flutter#187268) 2026-05-30 evanwall@buffalo.edu add sdf golden variants for OpenGL (flutter/flutter#187246) 2026-05-30 engine-flutter-autoroll@skia.org Roll Skia from dc01525ac468 to 0aee4675e0ad (6 revisions) (flutter/flutter#187334) 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from c480ba2eb2eb to dc01525ac468 (4 revisions) (flutter/flutter#187317) 2026-05-29 jason-simmons@users.noreply.github.com Remove the Y coordinate flip workaround in the Material stretch effect shader now that it is no longer required by the Impeller GLES back end (flutter/flutter#187247) 2026-05-29 bkonyi@google.com [flutter_tools, devicelab] Fix filesystem safety guard for symlinked temp directories (flutter/flutter#187320) 2026-05-29 30870216+gaaclarke@users.noreply.github.com Brings linux tests out of bringup. (flutter/flutter#187271) 2026-05-29 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187321) 2026-05-29 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from SEfYx3xgueX3aFAY3... to oOAcFhkoE2_-Sy67z... (flutter/flutter#187310) 2026-05-29 36861262+QuncCccccc@users.noreply.github.com Fix mismatch between hit-test tree and traversal tree (flutter/flutter#186826) 2026-05-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that the TextureGLES destructor cleans up all objects that it holds including the sync fence (flutter/flutter#187216) 2026-05-29 engine-flutter-autoroll@skia.org Roll Packages from 10cbdc5 to e930ced (3 revisions) (flutter/flutter#187306) 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from d9d6b440c4e7 to c480ba2eb2eb (1 revision) (flutter/flutter#187305) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#11816) flutter/flutter@b05a9d7...54e199a 2026-06-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jMR_VXQi07kAk8vbR... to q27k7_um1GvVrySZS... (flutter/flutter#187338) 2026-06-01 rmacnak@google.com Remove use of deprecated API related to removal of the VM isolate. (flutter/flutter#187013) 2026-06-01 116356835+AbdeMohlbi@users.noreply.github.com Improve `dependOnInheritedWidgetOfExactType` documentation to explain why it is bad to use it in initState (flutter/flutter#186216) 2026-06-01 chris@bracken.jp Revert "Move dart-lang/ai to a top level third party dependency in en… (flutter/flutter#187370) 2026-05-30 jakemac@google.com Move dart-lang/ai to a top level third party dependency in engine (flutter/flutter#187268) 2026-05-30 evanwall@buffalo.edu add sdf golden variants for OpenGL (flutter/flutter#187246) 2026-05-30 engine-flutter-autoroll@skia.org Roll Skia from dc01525ac468 to 0aee4675e0ad (6 revisions) (flutter/flutter#187334) 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from c480ba2eb2eb to dc01525ac468 (4 revisions) (flutter/flutter#187317) 2026-05-29 jason-simmons@users.noreply.github.com Remove the Y coordinate flip workaround in the Material stretch effect shader now that it is no longer required by the Impeller GLES back end (flutter/flutter#187247) 2026-05-29 bkonyi@google.com [flutter_tools, devicelab] Fix filesystem safety guard for symlinked temp directories (flutter/flutter#187320) 2026-05-29 30870216+gaaclarke@users.noreply.github.com Brings linux tests out of bringup. (flutter/flutter#187271) 2026-05-29 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187321) 2026-05-29 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from SEfYx3xgueX3aFAY3... to oOAcFhkoE2_-Sy67z... (flutter/flutter#187310) 2026-05-29 36861262+QuncCccccc@users.noreply.github.com Fix mismatch between hit-test tree and traversal tree (flutter/flutter#186826) 2026-05-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that the TextureGLES destructor cleans up all objects that it holds including the sync fence (flutter/flutter#187216) 2026-05-29 engine-flutter-autoroll@skia.org Roll Packages from 10cbdc5 to e930ced (3 revisions) (flutter/flutter#187306) 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from d9d6b440c4e7 to c480ba2eb2eb (1 revision) (flutter/flutter#187305) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#187013) - Don't pass VM snapshot to Dart_Initialize. - Don't expect kDart{Vm,Isolate}Snapshot{Data,Instructions} symbols defined. - Replace 4-symbol Dart_LoadELF with 2-symbol Dart_LoadELF2. Blocking: https://dart-review.googlesource.com/c/sdk/+/502780
…lutter#187013) - Don't pass VM snapshot to Dart_Initialize. - Don't expect kDart{Vm,Isolate}Snapshot{Data,Instructions} symbols defined. - Replace 4-symbol Dart_LoadELF with 2-symbol Dart_LoadELF2. Blocking: https://dart-review.googlesource.com/c/sdk/+/502780
….pre release (#187872) Updates DEPS to update the Dart revision to aad8be4ce3077a809f0b4f3325c6d8a6908aad54 and makes the following changes that Dart version update (this list includes all of the commits in this PR!!): | Commit | Reasoning | | ------------- | ------------- | |9cddb59 | New Dart version removed `ai` repository from their internal DEPS in dart-lang/sdk@06bdbd7 (cherry pick of #187378) | | a6fb7ec | Actual commit that updates Dart version 🎯 | | 527ebc7 | Required to compile the engine with the new Dart version (cherry pick of #187013) | | 37c44d7 | Also required to compile the engine with the new Dart version (cherry pick of #187091) | | aafb985 | Ignore; reverted in 03b6bf1 | | dc91998 | Update LICENSES according to new Dart version | | 2cd036e | Ignore; reverted in 03b6bf1 | | 50a3ace | Formats engine Dart files according to updated formatter in new version of Dart SDK (part of #186690) | | ec37bf7 | Updated snapshot symbol assertions as a consequence of dart-lang/sdk@d36adba (cherry pick of #186812) | | a46d1e8 | Same as above | | 5a21bc3 | Fixes new `unawaited_return_in_try_block` analyzer errors caused by new Dart version (part of #186690) | |03b6bf1 | Reverts unnecessary analysis errors I added earlier } All of these fixes are included in this PR because their causes are a consequence of updating the Dart revision to the latest Dart beta (3.13.0-167.1.beta). Part of #187787. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
…lutter#187013) - Don't pass VM snapshot to Dart_Initialize. - Don't expect kDart{Vm,Isolate}Snapshot{Data,Instructions} symbols defined. - Replace 4-symbol Dart_LoadELF with 2-symbol Dart_LoadELF2. Blocking: https://dart-review.googlesource.com/c/sdk/+/502780
Blocking: https://dart-review.googlesource.com/c/sdk/+/502780