Cleanups from the removal of the VM isolate.#186407
Draft
rmacnak-google wants to merge 1 commit into
Draft
Conversation
fe5609d to
ce1f2f1
Compare
ce1f2f1 to
557ef5c
Compare
557ef5c to
91285ef
Compare
91285ef to
5d79a1c
Compare
5d79a1c to
05681f1
Compare
05681f1 to
93bae86
Compare
93bae86 to
c9f853b
Compare
c9f853b to
4c5f747
Compare
4c5f747 to
7d74207
Compare
7d74207 to
3b7787b
Compare
3b7787b to
28c75b6
Compare
28c75b6 to
ebb5c11
Compare
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
ebb5c11 to
8c4e16b
Compare
8c4e16b to
7694f84
Compare
7694f84 to
b31c82e
Compare
Old snapshot symbols: - kDartVmSnapshotData - kDartVmSnapshotInstructions - kDartIsolateSnapshotData - kDartIsolateSnapshotInstructions New snapshot symbols: - kDartSnapshotData - kDartSnapshotText As a transitional measure, gen_snapshot is generating the old symbols as aliases and the VM is accepting and ignoring the VM isolate's snapshot parameters to Dart_Initialize.
b31c82e to
e02d224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old snapshot symbols:
New snapshot symbols:
As a transitional measure, gen_snapshot is generating the old symbols as aliases and the VM is accepting and ignoring the VM isolate's snapshot parameters to Dart_Initialize.