Skip to content

[Impeller] Remove the texture coordinate system Y-flip workaround#187686

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
bdero:bdero/remove-texture-coordinate-system
Jun 9, 2026
Merged

[Impeller] Remove the texture coordinate system Y-flip workaround#187686
auto-submit[bot] merged 2 commits into
flutter:masterfrom
bdero:bdero/remove-texture-coordinate-system

Conversation

@bdero

@bdero bdero commented Jun 8, 2026

Copy link
Copy Markdown
Member

Follow-up to #186556, which fixed the GLES Y-flip by flipping at the vertex stage.

Removes the leftover texture coordinate system plumbing. This was part of the old GLES Y-flip workaround: A texture's "coordinate system" was still being set and propagated in a handful of places, but nothing reads it to flip anything anymore, so it was all dead code.

This removes TextureCoordinateSystem and Texture.coordinateSystem from the experimental Flutter GPU API.

Pre-launch Checklist

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 8, 2026
@github-actions github-actions Bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests team-android Owned by Android platform team flutter-gpu team-fluttergpu Owned by Flutter GPU team labels Jun 8, 2026
@github-project-automation github-project-automation Bot moved this to 🤔 Needs Triage in Flutter GPU Jun 8, 2026
@bdero bdero marked this pull request as ready for review June 8, 2026 18:13
@bdero bdero requested a review from a team as a code owner June 8, 2026 18:13
@bdero bdero requested review from gaaclarke and jesswrd and removed request for a team June 8, 2026 18:13
@bdero

bdero commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Another fun one for you @gaaclarke

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the TextureCoordinateSystem enum and all associated APIs, fields, and methods from the Impeller texture classes across C++, Dart, and platform-specific implementations. This includes removing coordinate system configuration from texture creation, blit commands, external textures, and related unit tests. There are no review comments, and I have no feedback to provide.

gaaclarke
gaaclarke previously approved these changes Jun 8, 2026

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, sir!

…ure-coordinate-system

# Conflicts:
#	engine/src/flutter/lib/gpu/lib/src/formats.dart
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 8, 2026
@bdero bdero added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 8, 2026
@bdero bdero requested a review from gaaclarke June 9, 2026 19:59
@bdero

bdero commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Had to fix some merge conflicts.

@auto-submit auto-submit Bot added this pull request to the merge queue Jun 9, 2026
Merged via the queue into flutter:master with commit 2e8d57a Jun 9, 2026
206 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2026
@github-project-automation github-project-automation Bot moved this from 🤔 Needs Triage to ✅ Done in Flutter GPU Jun 9, 2026
@bdero bdero deleted the bdero/remove-texture-coordinate-system branch June 10, 2026 00:32
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 11, 2026
flutter/flutter@66aaa9a...c0a1129

2026-06-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187740)
2026-06-09 burak.karahan@mail.ru Remove Material import from view chrome style test (flutter/flutter#186994)
2026-06-09 jason-simmons@users.noreply.github.com [Impeller] Remove unused DeviceHolderVK reference from CommandBufferVK (flutter/flutter#187705)
2026-06-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KNe93cf5wU4xG2d-m... to 8azSyvz57mKcPqTwk... (flutter/flutter#187745)
2026-06-09 1063596+reidbaker@users.noreply.github.com Add android-agent agent.json and update reidbaker-agent skills (flutter/flutter#187746)
2026-06-09 engine-flutter-autoroll@skia.org Roll Skia from aeed11c35004 to 9f02102df298 (9 revisions) (flutter/flutter#187744)
2026-06-09 bdero@google.com [Impeller] Remove the texture coordinate system Y-flip workaround (flutter/flutter#187686)
2026-06-09 41687333+rlueders@users.noreply.github.com [Impeller] Retry uncompressed when fixed-rate compression is exhausted (flutter/flutter#187586)
2026-06-09 burak.karahan@mail.ru Remove Material import from implicit animation tests (flutter/flutter#186673)
2026-06-09 engine-flutter-autoroll@skia.org Roll Packages from 13b49f4 to bd297cf (4 revisions) (flutter/flutter#187739)
2026-06-09 30870216+gaaclarke@users.noreply.github.com Updates dia_dll.py to support vs2026 (flutter/flutter#187714)
2026-06-09 bdero@google.com [Flutter GPU] Allow attaching specific texture mip levels and slices for rendering (flutter/flutter#187685)
2026-06-09 engine-flutter-autoroll@skia.org Roll Dart SDK from 39f1c44e294f to f3441f2067ae (1 revision) (flutter/flutter#187711)
2026-06-09 bdero@google.com [flutter_tools] Hot reload Flutter GPU shader bundles (flutter/flutter#187654)
2026-06-09 katelovett@google.com Update triage links (flutter/flutter#187709)
2026-06-09 engine-flutter-autoroll@skia.org Roll Skia from 43f135735152 to aeed11c35004 (11 revisions) (flutter/flutter#187721)
2026-06-09 jason-simmons@users.noreply.github.com Use workspace resolution for the meta package in dev/integration_tests/record_use_test_package (flutter/flutter#187733)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
…utter#187686)

Follow-up to flutter#186556, which fixed
the GLES Y-flip by flipping at the vertex stage.

Removes the leftover texture coordinate system plumbing. This was part
of the old GLES Y-flip workaround: A texture's "coordinate system" was
still being set and propagated in a handful of places, but nothing reads
it to flip anything anymore, so it was all dead code.

This removes `TextureCoordinateSystem` and `Texture.coordinateSystem`
from the experimental Flutter GPU API.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. flutter-gpu platform-android Android applications specifically team-android Owned by Android platform team team-fluttergpu Owned by Flutter GPU team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants