Remove Material import from view chrome style test#186994
Merged
auto-submit[bot] merged 2 commits intoJun 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the dependency on the Material library within view_chrome_style_test.dart by replacing references to Colors.blue and Colors.green with local private constants. Consequently, the test file has been removed from the cross-import exclusion list in check_tests_cross_imports.dart. Feedback was provided to add documentation comments to the new constants to comply with the repository style guide and explain their purpose in avoiding cross-layer dependencies.
Comment on lines
+9
to
+10
| const Color _materialBlue500 = Color(0xFF2196F3); | ||
| const Color _materialGreen500 = Color(0xFF4CAF50); |
Contributor
There was a problem hiding this comment.
The repository style guide specifies that all members should have documentation, including private ones, using ///. Please add doc comments to these constants to explain their purpose and that they are local copies of Material color values intended to avoid a cross-layer dependency in this rendering test.
/// The color value for Material blue 500, used here to avoid a dependency on
/// the Material library.
const Color _materialBlue500 = Color(0xFF2196F3);
/// The color value for Material green 500, used here to avoid a dependency on
/// the Material library.
const Color _materialGreen500 = Color(0xFF4CAF50);References
- All public members should have documentation... Use
///for public-quality documentation, even on private members. (link)
7e292c6 to
7dd9ab2
Compare
Contributor
Author
|
Addressed the Gemini documentation feedback for the local Material color constants. Re-verified with format, cross-import checker, analyze, flutter analyze, targeted test, and git diff --check. |
victorsanni
approved these changes
Jun 2, 2026
AbdeMohlbi
approved these changes
Jun 2, 2026
d183a65 to
5970f12
Compare
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 11, 2026
flutter/flutter@66aaa9a...c0a1129 2026-06-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187740) 2026-06-09 burak.karahan@mail.ru Remove Material import from view chrome style test (flutter/flutter#186994) 2026-06-09 jason-simmons@users.noreply.github.com [Impeller] Remove unused DeviceHolderVK reference from CommandBufferVK (flutter/flutter#187705) 2026-06-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KNe93cf5wU4xG2d-m... to 8azSyvz57mKcPqTwk... (flutter/flutter#187745) 2026-06-09 1063596+reidbaker@users.noreply.github.com Add android-agent agent.json and update reidbaker-agent skills (flutter/flutter#187746) 2026-06-09 engine-flutter-autoroll@skia.org Roll Skia from aeed11c35004 to 9f02102df298 (9 revisions) (flutter/flutter#187744) 2026-06-09 bdero@google.com [Impeller] Remove the texture coordinate system Y-flip workaround (flutter/flutter#187686) 2026-06-09 41687333+rlueders@users.noreply.github.com [Impeller] Retry uncompressed when fixed-rate compression is exhausted (flutter/flutter#187586) 2026-06-09 burak.karahan@mail.ru Remove Material import from implicit animation tests (flutter/flutter#186673) 2026-06-09 engine-flutter-autoroll@skia.org Roll Packages from 13b49f4 to bd297cf (4 revisions) (flutter/flutter#187739) 2026-06-09 30870216+gaaclarke@users.noreply.github.com Updates dia_dll.py to support vs2026 (flutter/flutter#187714) 2026-06-09 bdero@google.com [Flutter GPU] Allow attaching specific texture mip levels and slices for rendering (flutter/flutter#187685) 2026-06-09 engine-flutter-autoroll@skia.org Roll Dart SDK from 39f1c44e294f to f3441f2067ae (1 revision) (flutter/flutter#187711) 2026-06-09 bdero@google.com [flutter_tools] Hot reload Flutter GPU shader bundles (flutter/flutter#187654) 2026-06-09 katelovett@google.com Update triage links (flutter/flutter#187709) 2026-06-09 engine-flutter-autoroll@skia.org Roll Skia from 43f135735152 to aeed11c35004 (11 revisions) (flutter/flutter#187721) 2026-06-09 jason-simmons@users.noreply.github.com Use workspace resolution for the meta package in dev/integration_tests/record_use_test_package (flutter/flutter#187733) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
Part of flutter#177412 Refs flutter#177028 Removes the Material import from the rendering view chrome style test by preserving the previous Material color values as local Color constants. Also removes the test from the rendering cross-import allowlist. This is an import/color cleanup only; it does not change runtime behavior, test expectations, or golden output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #177412
Refs #177028
Removes the Material import from the rendering view chrome style test by preserving the previous Material color values as local Color constants. Also removes the test from the rendering cross-import allowlist.
This is an import/color cleanup only; it does not change runtime behavior, test expectations, or golden output.