Remove Material import from implicit animation tests by MarlonJD · Pull Request #186673 · flutter/flutter

MarlonJD · 2026-05-18T12:14:46Z

This removes the package:flutter/material.dart dependency from the widgets implicit animation tests by replacing the Material Switch toggle with a widgets-only gesture target and using explicit Color values.

It also moves the Material-specific AnimatedTheme onEnd coverage into packages/flutter/test/material/animated_theme_test.dart, keeping widgets/implicit_animations_test.dart free of Material dependencies.

Validation:

bin/cache/dart-sdk/bin/dart --enable-asserts dev/bots/check_tests_cross_imports.dart
dart analyze packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart dev/bots/check_tests_cross_imports.dart
./bin/flutter test packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart

gemini-code-assist

Code Review

This pull request refactors the testing infrastructure for implicit animations by introducing a helper method for toggling widgets and consolidating test structures. It includes the addition of a new test file for AnimatedTheme, updates to existing tests in implicit_animations_test.dart, and the use of explicit color constants throughout the test suite to improve consistency and performance.

MarlonJD · 2026-05-18T18:24:20Z

Re-checked the const-color feedback: the referenced literals are already in a const widget tree, and adding explicit const there produces unnecessary_const. Re-verified locally with dart analyze packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart and ./bin/flutter test on both files.

victorsanni

do we need to remove widgets/implicit_animations_test.dart from dev/bots/check_tests_cross_imports.dart?

…ns-no-material

MarlonJD · 2026-05-20T00:52:38Z

Thanks for the review! I inlined the tap sequence into the test and removed the single-use helper in 101d088.

For the cross-import allowlist: yes, removing widgets/implicit_animations_test.dart is needed because it no longer imports Material, and the checker reports fixed allowlist entries if they are left behind.

Re-verified locally:

dart analyze packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart
dart --enable-asserts dev/bots/check_tests_cross_imports.dart
./bin/flutter test packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart

All passed.

MarlonJD · 2026-05-22T12:24:47Z

@victorsanni This should be ready for re-review.

Since your last review:

Removed widgets/implicit_animations_test.dart from the widgets cross-import allowlist as requested.
Removed the single-use helper.
Re-ran the cross-import checker, analyze, and the targeted tests; they pass.

Validation:

bin/cache/dart-sdk/bin/dart --enable-asserts dev/bots/check_tests_cross_imports.dart
dart analyze packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart dev/bots/check_tests_cross_imports.dart
./bin/flutter test packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart

auto-submit · 2026-06-07T13:57:41Z

autosubmit label was removed for flutter/flutter/186673, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

…ns-no-material # Conflicts: # dev/bots/check_tests_cross_imports.dart

MarlonJD · 2026-06-07T18:11:17Z

Updated the branch by merging the latest upstream/master in dcc0b22501f.

The merge conflict in dev/bots/check_tests_cross_imports.dart was resolved by:

Keeping implicit_animations_test.dart out of the widgets cross-import allowlist.
Removing navigator_replacement_test.dart too, since the checker now reports it as fixed.

Validation run locally:

bin/cache/dart-sdk/bin/dart --enable-asserts dev/bots/check_tests_cross_imports.dart
bin/cache/dart-sdk/bin/dart analyze packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart packages/flutter/test/widgets/navigator_replacement_test.dart dev/bots/check_tests_cross_imports.dart
./bin/flutter test packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart

I also tried to restore the autosubmit label, but GitHub rejected it with AddLabelsToLabelable permission denied for my account, so a maintainer will need to re-add it.

rkishan516

Re-LGTM

flutter/flutter@66aaa9a...c0a1129 2026-06-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187740) 2026-06-09 burak.karahan@mail.ru Remove Material import from view chrome style test (flutter/flutter#186994) 2026-06-09 jason-simmons@users.noreply.github.com [Impeller] Remove unused DeviceHolderVK reference from CommandBufferVK (flutter/flutter#187705) 2026-06-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KNe93cf5wU4xG2d-m... to 8azSyvz57mKcPqTwk... (flutter/flutter#187745) 2026-06-09 1063596+reidbaker@users.noreply.github.com Add android-agent agent.json and update reidbaker-agent skills (flutter/flutter#187746) 2026-06-09 engine-flutter-autoroll@skia.org Roll Skia from aeed11c35004 to 9f02102df298 (9 revisions) (flutter/flutter#187744) 2026-06-09 bdero@google.com [Impeller] Remove the texture coordinate system Y-flip workaround (flutter/flutter#187686) 2026-06-09 41687333+rlueders@users.noreply.github.com [Impeller] Retry uncompressed when fixed-rate compression is exhausted (flutter/flutter#187586) 2026-06-09 burak.karahan@mail.ru Remove Material import from implicit animation tests (flutter/flutter#186673) 2026-06-09 engine-flutter-autoroll@skia.org Roll Packages from 13b49f4 to bd297cf (4 revisions) (flutter/flutter#187739) 2026-06-09 30870216+gaaclarke@users.noreply.github.com Updates dia_dll.py to support vs2026 (flutter/flutter#187714) 2026-06-09 bdero@google.com [Flutter GPU] Allow attaching specific texture mip levels and slices for rendering (flutter/flutter#187685) 2026-06-09 engine-flutter-autoroll@skia.org Roll Dart SDK from 39f1c44e294f to f3441f2067ae (1 revision) (flutter/flutter#187711) 2026-06-09 bdero@google.com [flutter_tools] Hot reload Flutter GPU shader bundles (flutter/flutter#187654) 2026-06-09 katelovett@google.com Update triage links (flutter/flutter#187709) 2026-06-09 engine-flutter-autoroll@skia.org Roll Skia from 43f135735152 to aeed11c35004 (11 revisions) (flutter/flutter#187721) 2026-06-09 jason-simmons@users.noreply.github.com Use workspace resolution for the meta package in dev/integration_tests/record_use_test_package (flutter/flutter#187733) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Part of flutter#177412 Refs flutter#177028 This removes the package:flutter/material.dart dependency from the widgets implicit animation tests by replacing the Material Switch toggle with a widgets-only gesture target and using explicit Color values. It also moves the Material-specific AnimatedTheme onEnd coverage into packages/flutter/test/material/animated_theme_test.dart, keeping widgets/implicit_animations_test.dart free of Material dependencies. Validation: - bin/cache/dart-sdk/bin/dart --enable-asserts dev/bots/check_tests_cross_imports.dart - dart analyze packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart dev/bots/check_tests_cross_imports.dart - ./bin/flutter test packages/flutter/test/widgets/implicit_animations_test.dart packages/flutter/test/material/animated_theme_test.dart --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com> Co-authored-by: Kishan Rathore <34465683+rkishan516@users.noreply.github.com>

Remove Material import from implicit animation tests

a6fd5f1

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. labels May 18, 2026

gemini-code-assist Bot reviewed May 18, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/implicit_animations_test.dart Outdated

Use const color values in implicit animation test

e411aa7

MarlonJD changed the base branch from main to master May 18, 2026 18:28

MarlonJD mentioned this pull request May 18, 2026

(Test cross-imports) No legacy Material imports in tests #177412

Open

55 tasks

victorsanni added this to Test cross-imports Review Queue May 18, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue May 18, 2026

Merge branch 'master' into implicit-animations-no-material

182ec7e

victorsanni added the CICD Run CI/CD label May 18, 2026

victorsanni requested changes May 18, 2026

View reviewed changes

Remove implicit animations cross-import allowlist entry

c2588f7

github-actions Bot removed the CICD Run CI/CD label May 19, 2026

Merge remote-tracking branch 'upstream/master' into implicit-animatio…

a3f4969

…ns-no-material

victorsanni moved this from Todo to In Progress in Test cross-imports Review Queue May 19, 2026

Merge branch 'master' into implicit-animations-no-material

9084267

victorsanni added CICD Run CI/CD override code freeze Override an active code freeze. labels May 19, 2026

victorsanni reviewed May 19, 2026

View reviewed changes

Comment thread packages/flutter/test/material/animated_theme_test.dart Outdated

Merge branch 'master' into implicit-animations-no-material

fe4f754

github-actions Bot removed the CICD Run CI/CD label May 20, 2026

Inline AnimatedTheme onEnd test taps

101d088

Merge branch 'master' into implicit-animations-no-material

668cbdb

MarlonJD requested a review from victorsanni May 22, 2026 12:25

victorsanni previously approved these changes May 29, 2026

View reviewed changes

Merge branch 'master' into implicit-animations-no-material

391fe0c

github-actions Bot removed the CICD Run CI/CD label Jun 7, 2026

rkishan516 added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 7, 2026

auto-submit Bot added this pull request to the merge queue Jun 7, 2026

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jun 7, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2026

Merge remote-tracking branch 'upstream/master' into implicit-animatio…

dcc0b22

…ns-no-material # Conflicts: # dev/bots/check_tests_cross_imports.dart

MarlonJD dismissed stale reviews from victorsanni and rkishan516 via dcc0b22 June 7, 2026 18:10

github-actions Bot removed the CICD Run CI/CD label Jun 7, 2026

MarlonJD requested review from rkishan516 and victorsanni June 7, 2026 18:14

rkishan516 added the CICD Run CI/CD label Jun 9, 2026

rkishan516 approved these changes Jun 9, 2026

View reviewed changes

victorsanni approved these changes Jun 9, 2026

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2026

auto-submit Bot added this pull request to the merge queue Jun 9, 2026

Merged via the queue into flutter:master with commit 1d5ce4c Jun 9, 2026
174 checks passed

github-project-automation Bot moved this from In Progress to Done in Test cross-imports Review Queue Jun 9, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2026

MarlonJD deleted the implicit-animations-no-material branch June 9, 2026 20:39

engine-flutter-autoroll mentioned this pull request Jun 10, 2026

Roll Flutter from 66aaa9adb000 to c0a11291aa8c (17 revisions) flutter/packages#11881

Merged

justinmc mentioned this pull request Jun 23, 2026

[Decoupling] Copy over to flutter/packages any PRs that have landed in flutter/flutter since the main code copy #188441

Open

Renzo-Olivares mentioned this pull request Jun 24, 2026

(Test cross-imports) Tests should go in the library that they're testing #177414

Open

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove Material import from implicit animation tests#186673

Remove Material import from implicit animation tests#186673
auto-submit[bot] merged 11 commits into
flutter:masterfrom
MarlonJD:implicit-animations-no-material

MarlonJD commented May 18, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

MarlonJD commented May 18, 2026

Uh oh!

victorsanni left a comment

Uh oh!

Uh oh!

MarlonJD commented May 20, 2026

Uh oh!

MarlonJD commented May 22, 2026

Uh oh!

auto-submit Bot commented Jun 7, 2026

Uh oh!

MarlonJD commented Jun 7, 2026 •

edited

Loading

Uh oh!

rkishan516 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MarlonJD commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

MarlonJD commented May 18, 2026

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MarlonJD commented May 20, 2026

Uh oh!

MarlonJD commented May 22, 2026

Uh oh!

auto-submit Bot commented Jun 7, 2026

Uh oh!

MarlonJD commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rkishan516 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MarlonJD commented May 18, 2026 •

edited

Loading

MarlonJD commented Jun 7, 2026 •

edited

Loading