docs: Fix doubled-word typos in framework dartdoc#186319
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request fixes various typographical errors in documentation, specifically removing duplicate words like 'the the' and 'to to' across multiple files. Reviewer feedback identifies further opportunities to improve grammatical correctness and idiomatic phrasing in the documentation for rendering phases within object.dart.
| /// each [_RenderObjectSemantics] plus the sibling nodes. | ||
| /// | ||
| /// Phase 2, 3, 4 each depends on previous step to finished updating the the | ||
| /// Phase 2, 3, 4 each depends on previous step to finished updating the |
There was a problem hiding this comment.
The phrase 'to finished' is grammatically incorrect and should be 'to finish'. Additionally, adding 'the' before 'previous step' improves the flow and readability of the sentence.
/// Phase 2, 3, 4 each depends on the previous step to finish updating theReferences
- Optimize for readability: Code (and documentation) is read more often than it is written. (link)
| /// are stored in [_children]. | ||
| /// | ||
| /// This method does the the phase 1 and 2 of the four phases documented on | ||
| /// This method does the phase 1 and 2 of the four phases documented on |
There was a problem hiding this comment.
Using 'phases 1 and 2' (plural) is more grammatically correct than 'the phase 1 and 2'. Also, 'performs' is a more precise verb than 'does' for describing the execution of logic phases.
/// This method performs phases 1 and 2 of the four phases documented onReferences
- Optimize for readability: Code (and documentation) is read more often than it is written. (link)
| /// children's subtree in [_children]. | ||
| /// | ||
| /// This method does the the phase 3 of the four phases documented on | ||
| /// This method does the phase 3 of the four phases documented on |
There was a problem hiding this comment.
Using 'performs phase 3' is more idiomatic and concise than 'does the phase 3'.
/// This method performs phase 3 of the four phases documented onReferences
- Optimize for readability: Code (and documentation) is read more often than it is written. (link)
| /// generated and up to date. | ||
| /// | ||
| /// This method does the the phase 4 of the four phases documented on | ||
| /// This method does the phase 4 of the four phases documented on |
There was a problem hiding this comment.
Using 'performs phase 4' is more idiomatic and concise than 'does the phase 4'.
/// This method performs phase 4 of the four phases documented onReferences
- Optimize for readability: Code (and documentation) is read more often than it is written. (link)
59c26c5 to
73b0b9e
Compare
## Summary
Removes accidentally repeated words ("the the", "is is") in dartdoc and
inline comments across lutter and lutter_tools. Comment-only follow-up
to flutter#186319.
No code, public API, or behavior is touched. The fix is mechanical and
was verified by re-grepping the modified files.
## Changes
- `packages/flutter/lib/src/widgets/text_selection.dart`: `the the start
handle` -> `the start handle`; `the the end handle` -> `the end handle`
- `packages/flutter_tools/lib/src/ios/lldb.dart`: dartdoc on
`_LLDBProcess` — `[Process] that is is running LLDB` -> `[Process] that
is running LLDB`
-
`packages/flutter_tools/test/host_cross_arch.shard/ios_content_validation_test.dart`:
`This is is the default for CocoaPods` -> `This is the default for
CocoaPods`
## Tests
No tests added. This is a comment-only change with no executable lines
touched. Verified locally by grepping the touched files for residual
`the the` / `is is` / `to to` / similar doubled tokens — none remain.
## Notes for maintainers
- Pre-launch checklist read; no engineering doc rewrite needed
(docs-only).
- No Material or Cupertino source paths are modified, so the active code
freeze is not impacted.
- Authored by a human (Nicoreia) with AI tooling assistance, in line
with Flutter's AI contribution policy: scope is small, mechanical, and
reviewable; no generated logic.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page and followed its process for
submitting this PR.
- [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
## Summary Fixes a handful of single-word typos found in `///` dartdoc and `//` inline comments inside `flutter_tools`. Comment-only — no public API, no behavior, no test logic touched. ## Changes - `packages/flutter_tools/lib/src/android/gradle_utils.dart` - `space sytax` -> `space syntax` - `This vesion is NOT` -> `This version is NOT` - `dynamiclly added` -> `dynamically added` - `gradle can run successfuly` -> `gradle can run successfully` - `Documenation is non continuous` -> `Documentation is non continuous` (2 occurrences) - `KGP version handling is prefered` -> `KGP version handling is preferred` (2 occurrences) - `packages/flutter_tools/lib/src/features.dart` - dartdoc: `Wether riscv64 support is enabled` -> `Whether riscv64 support is enabled` - inline: `This member is overriden in google3` -> `This member is overridden in google3` - `packages/flutter_tools/lib/src/linux/linux_doctor.dart` - dartdoc: `Requires tha [binary]` -> `Requires that [binary]` ## Tests No tests added or modified. The change does not touch any executable line. Verified locally by re-grepping the modified files for residual instances of each typo — none remain. ## Notes for maintainers - Comment-only, mechanical fix. The author is human (Nicoreia) using AI tooling assistance, in line with Flutter's AI contribution policy: scope is small, reviewable, and contains no AI-generated logic. - No `material/` or `cupertino/` paths are touched, so the active code freeze is not impacted. - Companion to flutter#186319 and flutter#186320, which fix related typos in framework docs and other comments. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page and followed its process for submitting this PR. - [x] I read and followed the [Flutter Style Guide]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation. - [x] All existing and new tests are passing. [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/
…ter#186322) ## Summary Fixes a single-word typo (`tha` -> `that`) in an inline comment inside `widget_inspector_test.dart`. Comment-only — no test logic, expectations, or fixtures are modified. ## Changes - `packages/flutter/test/widgets/widget_inspector_test.dart` line 3120: - `// Verify tha the regular getSelectedWidget method still returns` -> `// Verify that the regular getSelectedWidget method still returns` ## Tests No tests added or modified. Comment-only change; no executable code touched. ## Notes for maintainers - Mechanical typo fix in a comment. Human-authored (Nicoreia) with AI tooling assistance; scope is intentionally minimal per Flutter's AI contribution policy. - Companion to flutter#186319, flutter#186320, and the gradle/features/linux typo PR opened in parallel. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page and followed its process for submitting this PR. - [x] I read and followed the [Flutter Style Guide]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation. - [x] All existing and new tests are passing. [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/
…186323) ## Summary Fixes three `overriden` -> `overridden` typos in the `MediaQueryData` dartdoc inside `media_query.dart`. Dartdoc-only — no public API or behavior is touched. ## Changes - `packages/flutter/lib/src/widgets/media_query.dart` - line 710: `[TextStyle.height] and [StrutStyle.height] are overriden by` -> `... are overridden by` - line 725: `[TextStyle.letterSpacing] is overriden by` -> `... is overridden by` - line 739: `[TextStyle.wordSpacing] is overriden by` -> `... is overridden by` ## Tests No tests added or modified. Comment-only change; no executable code touched. ## Notes for maintainers - Mechanical typo fix in dartdoc. Human-authored (Nicoreia) with AI tooling assistance; scope is intentionally minimal per Flutter's AI contribution policy. - No `material/` or `cupertino/` paths are touched, so the active code freeze is not impacted. - Companion to flutter#186319, flutter#186320, and the parallel typo PRs in `flutter_tools` and `widget_inspector_test`. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page and followed its process for submitting this PR. - [x] I read and followed the [Flutter Style Guide]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation. - [x] All existing and new tests are passing. [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/
…11713) Manual roll requested by bmparr@google.com flutter/flutter@23f6f58...0541913 2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492) 2026-05-13 srawlins@google.com [dev] Use super parameters in missed spots (flutter/flutter#186193) 2026-05-13 loic.peron@inetum.com [Windows] Propagate the enabled accessibility state (flutter/flutter#184501) 2026-05-13 matt.boetger@gmail.com [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079) 2026-05-13 engine-flutter-autoroll@skia.org Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464) 2026-05-13 mdebbar@google.com [web] Fix untriaged issues link label (flutter/flutter#186465) 2026-05-13 bdero@google.com [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332) 2026-05-13 1063596+reidbaker@users.noreply.github.com [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731) 2026-05-13 jason-simmons@users.noreply.github.com Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268) 2026-05-13 jason-simmons@users.noreply.github.com [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228) 2026-05-13 engine-flutter-autoroll@skia.org Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444) 2026-05-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442) 2026-05-13 engine-flutter-autoroll@skia.org Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441) 2026-05-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429) 2026-05-13 engine-flutter-autoroll@skia.org Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428) 2026-05-13 164032450+AlexEduV@users.noreply.github.com Docs/improving docs for semantics UI lib (flutter/flutter#186125) 2026-05-12 jason-simmons@users.noreply.github.com [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715) 2026-05-12 nico.reiab@gmail.com docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323) 2026-05-12 brackenavaron@gmail.com [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144) 2026-05-12 nico.reiab@gmail.com docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322) 2026-05-12 nico.reiab@gmail.com docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319) 2026-05-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186418) 2026-05-12 30870216+gaaclarke@users.noreply.github.com Bumped required mediatek vender sdk version. (flutter/flutter#186405) 2026-05-12 magder@google.com Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903) 2026-05-12 66727653+ishaq2321@users.noreply.github.com Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076) 2026-05-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186274) 2026-05-12 bdero@google.com [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890) 2026-05-12 zhongliu88889@gmail.com [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#11713) Manual roll requested by bmparr@google.com flutter/flutter@23f6f58...0541913 2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492) 2026-05-13 srawlins@google.com [dev] Use super parameters in missed spots (flutter/flutter#186193) 2026-05-13 loic.peron@inetum.com [Windows] Propagate the enabled accessibility state (flutter/flutter#184501) 2026-05-13 matt.boetger@gmail.com [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079) 2026-05-13 engine-flutter-autoroll@skia.org Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464) 2026-05-13 mdebbar@google.com [web] Fix untriaged issues link label (flutter/flutter#186465) 2026-05-13 bdero@google.com [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332) 2026-05-13 1063596+reidbaker@users.noreply.github.com [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731) 2026-05-13 jason-simmons@users.noreply.github.com Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268) 2026-05-13 jason-simmons@users.noreply.github.com [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228) 2026-05-13 engine-flutter-autoroll@skia.org Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444) 2026-05-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442) 2026-05-13 engine-flutter-autoroll@skia.org Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441) 2026-05-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429) 2026-05-13 engine-flutter-autoroll@skia.org Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428) 2026-05-13 164032450+AlexEduV@users.noreply.github.com Docs/improving docs for semantics UI lib (flutter/flutter#186125) 2026-05-12 jason-simmons@users.noreply.github.com [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715) 2026-05-12 nico.reiab@gmail.com docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323) 2026-05-12 brackenavaron@gmail.com [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144) 2026-05-12 nico.reiab@gmail.com docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322) 2026-05-12 nico.reiab@gmail.com docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319) 2026-05-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186418) 2026-05-12 30870216+gaaclarke@users.noreply.github.com Bumped required mediatek vender sdk version. (flutter/flutter#186405) 2026-05-12 magder@google.com Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903) 2026-05-12 66727653+ishaq2321@users.noreply.github.com Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076) 2026-05-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#186274) 2026-05-12 bdero@google.com [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890) 2026-05-12 zhongliu88889@gmail.com [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Description
Removes accidentally duplicated words in
///dartdoc comments in theframework (
the the,to to). These strings appear in the public APIdocs on api.flutter.dev. No runtime or API behavior change.
Affected files:
packages/flutter/lib/src/material/stepper.dart(1 line)packages/flutter/lib/src/rendering/object.dart(4 lines)packages/flutter/lib/src/semantics/semantics.dart(1 line)packages/flutter/lib/src/widgets/form.dart(1 line)packages/flutter/lib/src/widgets/layout_builder.dart(2 lines)packages/flutter/lib/src/widgets/overlay.dart(1 line)Related issues
Doc-only cleanup; not tied to a specific GitHub issue.
Tests
flutter analyzeon the six touched files:No issues found!.Pre-launch Checklist
AI / tooling disclosure
This PR was prepared with the assistance of an AI-powered editor (Cursor).
The diff is a mechanical fix of duplicated words in dartdoc comments; I
reviewed every changed line before committing.