Unpin sdk package dependencies by sigurdm · Pull Request #184821 · flutter/flutter

sigurdm · 2026-04-09T14:53:05Z

Fixes #158050
Design: https://flutter.dev/go/unpin-flutter-sdk-dependencies

test_api and matcher are not unpinned, as they are still depended upon with src-imports making unpinning unsound.

material_color_utilities is also not unpinned yet, see the design doc for discussion.

gemini-code-assist

Code Review

This pull request updates several pubspec.yaml files across the repository to use caret versioning for various dependencies, including characters, collection, meta, vector_math, intl, path, fake_async, clock, stack_trace, leak_tracker_flutter_testing, and stream_channel. Additionally, the pubspec.lock file is updated to reflect version increments for meta (1.18.2) and vector_math (2.3.0). I have no feedback to provide.

flutter-dashboard · 2026-04-13T14:28:57Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

stuartmorgan-g · 2026-04-13T15:17:55Z

/cc @jtmcdole @Piinks for awareness that this change is landing shortly.

stuartmorgan-g

LGTM

auto-submit · 2026-04-16T12:17:15Z

autosubmit label was removed for flutter/flutter/184821, because This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan-g}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

stuartmorgan-g · 2026-04-16T13:24:42Z

(Unfortunately, as of recently, pushing new commits will remove approvals in flutter/flutter.)

loic-sharma · 2026-04-17T00:40:02Z

Reason for revert: this appears to have broken the tree.

Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_4_10/157/overview

14:17 +15: test/integration.shard/dependencies_test.dart: All dependencies are locked to their lower bound
14:17 +15 -1: test/integration.shard/dependencies_test.dart: All dependencies are locked to their lower bound [E]
  Dependency "characters" in "C:\b\s\w\ir\x\w\flutter\packages\flutter\pubspec.yaml" is not locked at its lower bound.
  
  package:matcher                                       fail
  test\integration.shard\dependencies_test.dart 185:11  main.<fn>

This reverts commit 8ec03cf.

flutteractionsbot · 2026-04-17T00:41:06Z

Successfully created revert PR: #185186

@loic-sharma

Reverts: [Unpin sdk package dependencies](#184821) Initiated by: @loic-sharma Reason for reverting: this appears to have broken the tree. Original PR Author: @sigurdm Reviewed By: @stuartmorgan-g The original PR description is provided below: Fixes #158050 Design: https://flutter.dev/go/unpin-flutter-sdk-dependencies test_api and matcher are not unpinned, as they are still depended upon with src-imports making unpinning unsound. material_color_utilities is also not unpinned yet, see the design doc for discussion.

flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 chris@bracken.jp [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 pewpewstol@gmail.com [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 nate.w5687@gmail.com `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 karan@solvejet.net Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 154381524+flutteractionsbot@users.noreply.github.com Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 116356835+AbdeMohlbi@users.noreply.github.com Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 1063596+reidbaker@users.noreply.github.com Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 flar@google.com [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 katelovett@google.com Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 152433210+mozammal-hossain@users.noreply.github.com [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 bkonyi@google.com [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 sigurdm@google.com Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 68919043+Istiak-Ahmed78@users.noreply.github.com Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11523) flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 chris@bracken.jp [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 pewpewstol@gmail.com [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 nate.w5687@gmail.com `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 karan@solvejet.net Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 154381524+flutteractionsbot@users.noreply.github.com Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 116356835+AbdeMohlbi@users.noreply.github.com Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 1063596+reidbaker@users.noreply.github.com Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 flar@google.com [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 katelovett@google.com Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 152433210+mozammal-hossain@users.noreply.github.com [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 bkonyi@google.com [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 sigurdm@google.com Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 68919043+Istiak-Ahmed78@users.noreply.github.com Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Unpin sdk package dependencies

12ebee9

github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) labels Apr 9, 2026

sigurdm marked this pull request as ready for review April 13, 2026 14:25

gemini-code-assist Bot reviewed Apr 13, 2026

View reviewed changes

sigurdm requested a review from stuartmorgan-g April 13, 2026 14:29

stuartmorgan-g requested changes Apr 13, 2026

View reviewed changes

Comment thread packages/flutter/pubspec.yaml

Comment thread packages/flutter_test/pubspec.yaml

Add issue references

86d4dfd

stuartmorgan-g previously approved these changes Apr 14, 2026

View reviewed changes

stuartmorgan-g added the CICD Run CI/CD label Apr 14, 2026

sigurdm dismissed stuartmorgan-g’s stale review via c9465cc April 14, 2026 14:33

sigurdm requested review from a team as code owners April 14, 2026 14:33

sigurdm commented Apr 14, 2026

View reviewed changes

Comment thread pubspec.lock Outdated

jtmcdole added the CICD Run CI/CD label Apr 14, 2026

Piinks added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 14, 2026

sigurdm added 2 commits April 16, 2026 11:42

Merge remote-tracking branch 'origin/main' into unpin_deps

46695ae

Undo upgrade of vector_math

bdcf72f

github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026

sigurdm added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2026

stuartmorgan-g approved these changes Apr 16, 2026

View reviewed changes

stuartmorgan-g added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 16, 2026

auto-submit Bot added this pull request to the merge queue Apr 16, 2026

Merged via the queue into flutter:master with commit 8ec03cf Apr 16, 2026
93 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2026

loic-sharma added the revert_wf Revert using Github Workflow label Apr 17, 2026

flutteractionsbot added a commit to flutteractionsbot/flutter that referenced this pull request Apr 17, 2026

Revert "Unpin sdk package dependencies (flutter#184821)"

6198015

This reverts commit 8ec03cf.

flutteractionsbot mentioned this pull request Apr 17, 2026

Revert "Unpin sdk package dependencies" #185186

Merged

flutteractionsbot removed the revert_wf Revert using Github Workflow label Apr 17, 2026

loic-sharma mentioned this pull request Apr 17, 2026

Stop pinning dependencies #158050

Closed

2 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026

8ec03cfed Unpin sdk package dependencies (flutter/flutter#184821)

a88299a

engine-flutter-autoroll mentioned this pull request Apr 17, 2026

Roll Flutter from 31f1802cb859 to 8e8a194923dc (22 revisions) flutter/packages#11523

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unpin sdk package dependencies#184821

Unpin sdk package dependencies#184821
auto-submit[bot] merged 5 commits into
flutter:masterfrom
sigurdm:unpin_deps

sigurdm commented Apr 9, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

flutter-dashboard Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Apr 13, 2026

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

auto-submit Bot commented Apr 16, 2026

Uh oh!

stuartmorgan-g commented Apr 16, 2026

Uh oh!

Uh oh!

loic-sharma commented Apr 17, 2026

Uh oh!

flutteractionsbot commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

sigurdm commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

flutter-dashboard Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Apr 13, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit Bot commented Apr 16, 2026

Uh oh!

stuartmorgan-g commented Apr 16, 2026

Uh oh!

Uh oh!

loic-sharma commented Apr 17, 2026

Uh oh!

flutteractionsbot commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sigurdm commented Apr 9, 2026 •

edited

Loading