Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) by Istiak-Ahmed78 · Pull Request #184643 · flutter/flutter

Istiak-Ahmed78 · 2026-04-05T17:11:36Z

Fixes a bug in ImageInfo.isCloneOf where the scale property was being compared to itself (scale == scale) instead of comparing against the other object's scale (other.scale == scale). This caused the method to always return true for scale comparisons, incorrectly identifying ImageInfo objects with different scales as clones.

Root Cause

In packages/flutter/lib/src/painting/image_stream.dart, line 104:

// Before (bug)
return other.image.isCloneOf(image) && scale == scale && other.debugLabel == debugLabel;

// After (fix)
return other.image.isCloneOf(image) && other.scale == scale && other.debugLabel == debugLabel;

The scale == scale comparison is a typo that always evaluates to true, making the scale check ineffective.

Impact

This bug could cause:

Images not repainting when their scale changes
Incorrect caching behavior in ImageCache
Visual bugs where images render at wrong sizes
RawImage and DecorationImage widgets skipping necessary repaints

Tests

Added two regression tests to packages/flutter/test/painting/image_stream_test.dart:

ImageInfo.isCloneOf returns false when scales differ - verifies the fix
ImageInfo.isCloneOf returns true when all properties match - verifies correct behavior

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I added/updated tests for this change.
I used self-descriptive commit messages.

Fixes #184626

gemini-code-assist

Code Review

This pull request fixes a bug in ImageInfo.isCloneOf where the scale property was incorrectly compared against itself instead of the other object's scale. Unit tests were added to verify the fix. The review feedback suggests using addTearDown for resource disposal in the new tests to ensure cleanup even if assertions fail, preventing potential memory leaks.

Hari-07

LGTM

Istiak-Ahmed78 · 2026-04-07T04:49:13Z

@Hari-07, I apologize for the unrelated commit that was accidentally pushed to this branch. I have reverted it in the latest commit. This PR now only contains the intended changes for the ImageInfo.isCloneOf fix.

Since the accidental commit may have dismissed your previous approval, I'd appreciate it if you could review the PR again at your convenience. Thank you!

gemini-code-assist

Code Review

This pull request corrects a logic error in the ImageInfo.isCloneOf method by ensuring the scale property is compared against the other object's scale instead of itself. It also introduces unit tests to verify the method's behavior when scales differ and when all properties match. I have no feedback to provide.

justinmc

LGTM 👍 . Thanks for fixing this! Very clear bug now that it's pointed out. I hope this didn't cause any problems for anyone in the 2+ years it's been in the framework...

justinmc · 2026-04-07T21:50:43Z

+    final imageInfo1 = ImageInfo(image: image.clone());
+    addTearDown(imageInfo1.dispose);
+    final imageInfo2 = ImageInfo(image: image.clone());


Nit: Would it be more clear if you added a matching scale: 2.0 or something to these?

Right! Adding the matching scale: 2.0 to both ImageInfo objects makes the test much clearer. I've updated both lines 1117 and 1119. Thanks for the suggestion!

Piinks

LGTM! Thank you!

chunhtai

LGTM

auto-submit · 2026-04-15T18:18:50Z

autosubmit label was removed for flutter/flutter/184643, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

auto-submit · 2026-04-15T18:18:51Z

autosubmit label was removed for flutter/flutter/184643, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

QuncCccccc

LGTM. Nice catch!

justinmc

Re LGTM 👍

Istiak-Ahmed78 · 2026-04-16T11:23:54Z

@Hari-07, Can you please add auto submit label if everything is okay? I think this PR is ready to be merged.

cbracken · 2026-04-17T11:53:23Z

This appears to have closed the tree in a sneaky, delayed time-bomb sort of way.

The fix itself looks good but the tests are (surprisingly and not at all obviously) non-hermetic. Specifically, the createTestImage() call directly inside a testWidgets block is problematic. createTestImage() (sometimes) involves actual async work (ui.decodeImageFromPixels), which violates testWidgets's contract and can cause tests to hang indefinitely depending on luck of the draw/execution order due to its internal caching. Specifically, there are two cases:

cache hit: if a test with the same width/height ran before this test, the image would be in _cache and we'd immediately return the cached value with no real async call. Test passes.
cache miss: If we don't have an image from previous test, we call ui.decodeImageFromPixels which requires a real async callback from the engine. FakeAsync will hang. Test times out and fails.

See the code and the note in the docs here:

flutter/packages/flutter_test/lib/src/image.dart

Lines 29 to 48 in 7e31a5b

    
           /// This method requires real async work, and will not work properly in the 
        
           /// [FakeAsync] zones set up by [testWidgets]. Typically, it should be invoked 
        
           /// as a setup step before [testWidgets] are run, such as [setUp] or [setUpAll]. 
        
           /// If needed, it can be invoked using [WidgetTester.runAsync]. 
        
           Future<ui.Image> createTestImage({int width = 1, int height = 1, bool cache = true}) => 
        
               TestAsyncUtils.guard(() async { 
        
                 assert(width > 0); 
        
                 assert(height > 0); 
        
                 final int cacheKey = Object.hash(width, height); 
        
                 if (cache && _cache.containsKey(cacheKey)) { 
        
                   return _cache[cacheKey]!.clone(); 
        
                 } 
        
                 final ui.Image image = await _createImage(width, height); 
        
                 if (cache) { 
        
                   _cache[cacheKey] = image.clone(); 
        
                 } 
        
                 return image; 
        
               });

The random seed for the tests is just the date, and it changed from 20260416 to 20260417 when the date rolled over. You can repro with:

Fails with today's seed:

bin/flutter test --test-randomize-ordering-seed=20260417 --track-widget-creation ./packages/flutter/test/painting/image_stream_test.dart

Passes with yesterday's seed:

bin/flutter test --test-randomize-ordering-seed=20260416 --track-widget-creation ./packages/flutter/test/painting/image_stream_test.dart

This is a super subtle bug; it was missed by 4 long-time Flutter experts and I 100% guarantee I would have missed this too in review.

Edit: I've added a patch that should fix this for you below. Patch that in and you should be able to reland the fix. There are probably other ways you could fix it too, but I verified locally that it "works for me" :)

cbracken · 2026-04-17T11:55:05Z

Reason for revert: tests added are order dependent and break depending on random seed.

#184626) (#184643)" This reverts commit ed9f5d7.

cbracken · 2026-04-17T12:04:31Z

I poked around at this a little. Instead of calling createTestImage() inside the test, we can use the image20x10 from the setUp block, clone it (yeah I know... putting even more use of the word "clone" in an already cloneful test isn't ideal), then scale it.

Something like this:

diff --git a/packages/flutter/test/painting/image_stream_test.dart b/packages/flutter/test/painting/image_stream_test.dart
index cebe89ace0..46e9138b80 100644
--- a/packages/flutter/test/painting/image_stream_test.dart
+++ b/packages/flutter/test/painting/image_stream_test.dart
@@ -1096,7 +1096,7 @@
   });

   testWidgets('ImageInfo.isCloneOf returns false when scales differ', (WidgetTester tester) async {
-    final Image image = await createTestImage(width: 10, height: 10);
+    final Image image = image20x10.clone();
     addTearDown(image.dispose);

     final imageInfo1 = ImageInfo(image: image.clone());
@@ -1111,7 +1111,7 @@
   testWidgets('ImageInfo.isCloneOf returns true when all properties match', (
     WidgetTester tester,
   ) async {
-    final Image image = await createTestImage(width: 10, height: 10);
+    final Image image = image20x10.clone();
     addTearDown(image.dispose);

     final imageInfo1 = ImageInfo(image: image.clone(), scale: 2.0);

cbracken · 2026-04-17T12:05:44Z

Sorry about the revert, everyone. :(

/cc @Istiak-Ahmed78 to trigger a notification just in case.

…ixes #184626) (#184643)" (#185203)  Reverts: #184643   Initiated by: cbracken   Reason for reverting: tests added are order dependent and break depending on random seed.   Original PR Author: Istiak-Ahmed78   Reviewed By: {justinmc, QuncCccccc, chunhtai, Piinks}   This change reverts the following previous change: Fixes a bug in `ImageInfo.isCloneOf` where the `scale` property was being compared to itself (`scale == scale`) instead of comparing against the other object's scale (`other.scale == scale`). This caused the method to always return `true` for scale comparisons, incorrectly identifying `ImageInfo` objects with different scales as clones. ## Root Cause In `packages/flutter/lib/src/painting/image_stream.dart`, line 104: ```dart // Before (bug) return other.image.isCloneOf(image) && scale == scale && other.debugLabel == debugLabel; // After (fix) return other.image.isCloneOf(image) && other.scale == scale && other.debugLabel == debugLabel; ``` The `scale == scale` comparison is a typo that always evaluates to `true`, making the scale check ineffective. ## Impact This bug could cause: - Images not repainting when their scale changes - Incorrect caching behavior in `ImageCache` - Visual bugs where images render at wrong sizes - `RawImage` and `DecorationImage` widgets skipping necessary repaints ## Tests Added two regression tests to `packages/flutter/test/painting/image_stream_test.dart`: 1. `ImageInfo.isCloneOf returns false when scales differ` - verifies the fix 2. `ImageInfo.isCloneOf returns true when all properties match` - verifies correct behavior ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added/updated tests for this change. - [x] I used self-descriptive commit messages. Fixes #184626  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

Hari-07 · 2026-04-17T14:33:18Z

Damn thats a sneaky one

…fixes #184626) (flutter/flutter#184643)

cbracken · 2026-04-17T15:25:16Z

This is subtle enough it'll probably happen again. We should probably have some automated means of catching these.

Istiak-Ahmed78 · 2026-04-17T15:30:21Z

This appears to have closed the tree in a sneaky, delayed time-bomb sort of way.

The fix itself looks good but the tests are (surprisingly and not at all obviously) non-hermetic. Specifically, the createTestImage() call directly inside a testWidgets block is problematic. createTestImage() involves actual async work (ui.decodeImageFromPixels), which violates testWidgets's contract and can cause tests to hang indefinitely depending on luck of the draw/execution order due to its internal caching. Specifically, there are two cases:

cache hit: if a test with the same width/height ran before this test, the image would be in _cache and we'd immediately return the cached value with no real async call. Test passes.

cache miss: If we don't have an image from previous test, we call ui.decodeImageFromPixels which requires a real async callback from the engine. FakeAsync will hang. Test times out and fails.

See the code and the note in the docs here:

flutter/packages/flutter_test/lib/src/image.dart

Lines 29 to 48 in 7e31a5b

/// This method requires real async work, and will not work properly in the

/// [FakeAsync] zones set up by [testWidgets]. Typically, it should be invoked

/// as a setup step before [testWidgets] are run, such as [setUp] or [setUpAll].

/// If needed, it can be invoked using [WidgetTester.runAsync].

Future<ui.Image> createTestImage({int width = 1, int height = 1, bool cache = true}) =>

TestAsyncUtils.guard(() async {

assert(width > 0);

assert(height > 0);

final int cacheKey = Object.hash(width, height);

if (cache && _cache.containsKey(cacheKey)) {

return _cache[cacheKey]!.clone();

}

final ui.Image image = await _createImage(width, height);

if (cache) {

_cache[cacheKey] = image.clone();

}

return image;

});

The random seed for the tests is just the date, and it changed from 20260416 to 20260417 when the date rolled over. You can repro with:

Fails with today's seed:
bin/flutter test --test-randomize-ordering-seed=20260417 --track-widget-creation ./packages/flutter/test/painting/image_stream_test.dart
Passes with yesterday's seed:
bin/flutter test --test-randomize-ordering-seed=20260416 --track-widget-creation ./packages/flutter/test/painting/image_stream_test.dart
This is a super subtle bug; it was missed by 4 long-time Flutter experts and I 100% guarantee I would have missed this too in review.

Edit: I've added a patch that should fix this for you below. Patch that in and you should be able to reland the fix. There are probably other ways you could fix it too, but I verified locally that it "works for me" :)

"Wow! What a catch. I didn't think of this. Whatever,
Shall I push the new changes after separating the real async
operation from the fake async?"

cbracken · 2026-04-17T15:36:06Z

Shall I push the new changes after separating the real async operation from the fake async?"

If you resend your original PR but make the changes from my diff above, the patch should be good to land. I tested that locally to confirm.

flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 chris@bracken.jp [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 pewpewstol@gmail.com [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 nate.w5687@gmail.com `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 karan@solvejet.net Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 154381524+flutteractionsbot@users.noreply.github.com Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 116356835+AbdeMohlbi@users.noreply.github.com Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 1063596+reidbaker@users.noreply.github.com Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 flar@google.com [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 katelovett@google.com Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 152433210+mozammal-hossain@users.noreply.github.com [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 bkonyi@google.com [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 sigurdm@google.com Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 68919043+Istiak-Ahmed78@users.noreply.github.com Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Istiak-Ahmed78 · 2026-04-17T16:28:57Z

I have pushed the changes you suggested to this branch fix linked to this PR. But looks like, the changes are not landing on this PR. Asking me to create another PR. Here's the changes a2560da
Can you help @cbracken ?

cbracken · 2026-04-18T01:36:26Z

@Istiak-Ahmed78 Since this PR was previously merged you'll need to send a new one. Maybe easiest is to sync your master local branch to tip-of-tree flutter master branch, then something like:

# Check out new branch.
% git checkout -b fix-iscloneof

# Revert my revert.
% git revert 8e8a194923dc579beb7fe83b363903e30d79243c

# Patch in the fix described above in comment
# https://github.com/flutter/flutter/pull/184643#issuecomment-4267815665
% [your edits here]

# Squash the fix into the previous commit and clean up the
# commit description so it's not revert: revert: ...
% git add packages/flutter/test/painting/image_stream_test.dart
% git commit --amend
% git push -u origin fix-iscloneof

then send the new PR from the GitHub web UI. Add @justinmc and the original reviewers back for the reland and it should go pretty quick :)

Istiak-Ahmed78 · 2026-04-18T06:25:57Z

@Istiak-Ahmed78 Since this PR was previously merged you'll need to send a new one. Maybe easiest is to sync your master local branch to tip-of-tree flutter master branch, then something like:
# Check out new branch.
% git checkout -b fix-iscloneof

# Revert my revert.
% git revert 8e8a194923dc579beb7fe83b363903e30d79243c

# Patch in the fix described above in comment
# https://github.com/flutter/flutter/pull/184643#issuecomment-4267815665
% [your edits here]

# Squash the fix into the previous commit and clean up the
# commit description so it's not revert: revert: ...
% git add packages/flutter/test/painting/image_stream_test.dart
% git commit --amend
% git push -u origin fix-iscloneof
then send the new PR from the GitHub web UI. Add @justinmc and the original reviewers back for the reland and it should go pretty quick :)

Thank you for the suggestion. However, I will be unavailable at my desk for a day. If it’s not urgent, I’ll be able to provide feedback after a day. Sorry for the inconvenience.

…alues (fixes flutter#184626) (flutter#184643)" (flutter#185203)" This reverts commit 8e8a194.

…185254) This PR fixes the non-hermetic tests in `ImageInfo.isCloneOf` by separating real async operations from the FakeAsync zone. ### Problem The original tests were calling `await createTestImage()` directly inside `testWidgets()`, which runs in a FakeAsync zone. This caused: - Non-deterministic failures dependent on random seed - Timing-dependent issues - Non-hermetic tests ### Solution Move the real async work (`createTestImage()`) to `setUp()` (outside FakeAsync) and use pre-created images in the test cases. ### Changes - Added `setUp()` to create test images before tests run - Replaced `await createTestImage()` with `image20x10.clone()` in test cases - Ensures tests are hermetic and deterministic ### Related Issues Reland of flutter#184643 (which was reverted due to the FakeAsync issue) Fixes the issue identified in the revert commit: 8e8a194 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [x] All existing and new tests are passing.

…r#11523) flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 chris@bracken.jp [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 pewpewstol@gmail.com [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 nate.w5687@gmail.com `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 karan@solvejet.net Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 154381524+flutteractionsbot@users.noreply.github.com Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 116356835+AbdeMohlbi@users.noreply.github.com Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 1063596+reidbaker@users.noreply.github.com Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 flar@google.com [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 katelovett@google.com Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 152433210+mozammal-hossain@users.noreply.github.com [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 bkonyi@google.com [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 sigurdm@google.com Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 68919043+Istiak-Ahmed78@users.noreply.github.com Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 5, 2026

gemini-code-assist Bot reviewed Apr 5, 2026

View reviewed changes

Comment thread packages/flutter/test/painting/image_stream_test.dart Outdated

Comment thread packages/flutter/test/painting/image_stream_test.dart Outdated

Hari-07 added the CICD Run CI/CD label Apr 6, 2026

Hari-07 previously approved these changes Apr 6, 2026

View reviewed changes

github-actions Bot removed the CICD Run CI/CD label Apr 6, 2026

Istiak-Ahmed78 dismissed Hari-07’s stale review via 6b361d0 April 6, 2026 20:15

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2026

Istiak-Ahmed78 force-pushed the fix branch from 6b361d0 to 784e0ad Compare April 6, 2026 20:25

Istiak-Ahmed78 marked this pull request as draft April 6, 2026 21:43

github-actions Bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 7, 2026

Istiak-Ahmed78 marked this pull request as ready for review April 7, 2026 04:49

Istiak-Ahmed78 requested a review from Hari-07 April 7, 2026 04:50

gemini-code-assist Bot reviewed Apr 7, 2026

View reviewed changes

justinmc previously approved these changes Apr 7, 2026

View reviewed changes

justinmc requested a review from Piinks April 7, 2026 22:14

Istiak-Ahmed78 dismissed justinmc’s stale review via 8c0b3df April 8, 2026 04:32

Istiak-Ahmed78 requested a review from justinmc April 8, 2026 04:51

Piinks approved these changes Apr 15, 2026

View reviewed changes

chunhtai approved these changes Apr 15, 2026

View reviewed changes

chunhtai added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Apr 15, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2026

QuncCccccc approved these changes Apr 15, 2026

View reviewed changes

github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026

justinmc approved these changes Apr 15, 2026

View reviewed changes

Hari-07 added the CICD Run CI/CD label Apr 16, 2026

auto-submit Bot added this pull request to the merge queue Apr 16, 2026

Merged via the queue into flutter:master with commit ed9f5d7 Apr 16, 2026
87 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2026

cbracken added the revert Autorevert PR (with "Reason for revert:" comment) label Apr 17, 2026

auto-submit Bot pushed a commit that referenced this pull request Apr 17, 2026

Revert "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes

38d1e40

#184626) (#184643)" This reverts commit ed9f5d7.

auto-submit Bot mentioned this pull request Apr 17, 2026

Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" #185203

Merged

7 tasks

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Apr 17, 2026

This was referenced Apr 17, 2026

Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... #185192

Merged

Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" #185199

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026

ed9f5d741 Fix ImageInfo.isCloneOf to correctly compare scale values (…

d995cdf

…fixes #184626) (flutter/flutter#184643)

engine-flutter-autoroll mentioned this pull request Apr 17, 2026

Roll Flutter from 31f1802cb859 to 8e8a194923dc (22 revisions) flutter/packages#11523

Merged

Istiak-Ahmed78 added a commit to Istiak-Ahmed78/flutter that referenced this pull request Apr 19, 2026

Revert "Reverts "Fix ImageInfo.isCloneOf to correctly compare scale v…

824e98f

…alues (fixes flutter#184626) (flutter#184643)" (flutter#185203)" This reverts commit 8e8a194.

Istiak-Ahmed78 mentioned this pull request Apr 19, 2026

Fix ImageInfo.isCloneOf tests by moving async work to setUp #185254

Merged

11 tasks

cbracken mentioned this pull request May 8, 2026

[material] Reduce flakiness in ink_paint_test #186245

Closed

10 tasks

Uh oh!

Conversation

Istiak-Ahmed78 commented Apr 5, 2026

Root Cause

Impact

Tests

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Hari-07 left a comment

Choose a reason for hiding this comment

Uh oh!

Istiak-Ahmed78 commented Apr 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Istiak-Ahmed78 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 15, 2026

Uh oh!

auto-submit Bot commented Apr 15, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Istiak-Ahmed78 commented Apr 16, 2026

Uh oh!

Uh oh!

cbracken commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbracken commented Apr 17, 2026

Uh oh!

cbracken commented Apr 17, 2026

Uh oh!

cbracken commented Apr 17, 2026

Uh oh!

Hari-07 commented Apr 17, 2026

Uh oh!

cbracken commented Apr 17, 2026

Uh oh!

Istiak-Ahmed78 commented Apr 17, 2026

Uh oh!

cbracken commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Istiak-Ahmed78 commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbracken commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Istiak-Ahmed78 commented Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

cbracken commented Apr 17, 2026 •

edited

Loading

cbracken commented Apr 17, 2026 •

edited

Loading

Istiak-Ahmed78 commented Apr 17, 2026 •

edited

Loading

cbracken commented Apr 18, 2026 •

edited

Loading