Skip to content

[flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule#183463

Merged
srawlins merged 2 commits into
flutter:masterfrom
srawlins:file-exists
Mar 16, 2026
Merged

[flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule#183463
srawlins merged 2 commits into
flutter:masterfrom
srawlins:file-exists

Conversation

@srawlins

@srawlins srawlins commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

avoid_slow_async_io is already enforced, but there was a bug where it wasn't catching File.exists and File.stat. This PR prepares flutter/flutter for a fix.

The fix is landing to support extension types: dart-lang/sdk#58838.
The fix will be a re-landing of https://dart-review.googlesource.com/c/sdk/+/486420.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@srawlins srawlins requested review from a team as code owners March 10, 2026 18:18
@flutter-dashboard

flutter-dashboard Bot commented Mar 10, 2026

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: desktop Running on desktop team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Mar 10, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates numerous instances of File.exists() and File.stat() to their synchronous counterparts, File.existsSync() and File.statSync(), respectively. This change aligns with the avoid_slow_async_io lint rule and prepares the codebase for an upcoming Dart SDK fix. The modifications are consistent across all affected files and directly address the stated objective of the pull request.

Note: Security Review did not run due to the size of the PR.

@srawlins srawlins added this pull request to the merge queue Mar 16, 2026
Merged via the queue into flutter:master with commit 66fd677 Mar 16, 2026
143 checks passed
@srawlins srawlins deleted the file-exists branch March 16, 2026 16:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
80f8422 
…orced lint rule (flutter/flutter#183463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
528014e 
…orced lint rule (flutter/flutter#183463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
787e119 
…orced lint rule (flutter/flutter#183463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
e982c6c 
…orced lint rule (flutter/flutter#183463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
0ce9d55 
…orced lint rule (flutter/flutter#183463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
07854bb 
…orced lint rule (flutter/flutter#183463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
66fd67755 [flutter_tools] Avoid File.exists and File.stat, as per enf…
6a71563 
…orced lint rule (flutter/flutter#183463)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Mar 18, 2026
@engine-flutter-autoroll
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (#11276)
afa1a1c 
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
nateshmbhat pushed a commit to nateshmbhat/flutter_packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (flutte…
e312fb7 
…r#11276)

Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
@engine-flutter-autoroll @okorohelijah
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (flutte…
8c900f2 
…r#11276)

Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@srawlins @mboetger
[flutter_tools] Avoid File.exists and File.stat, as per enforced lint…
8bbf052 
… rule (flutter#183463)

`avoid_slow_async_io` is already enforced, but there was a bug where it
wasn't catching `File.exists` and `File.stat`. This PR prepares
flutter/flutter for a fix.

The fix is landing to support extension types:
dart-lang/sdk#58838.
The fix will be a re-landing of
https://dart-review.googlesource.com/c/sdk/+/486420.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Apr 14, 2026
@srawlins @ahmedsameha1
[flutter_tools] Avoid File.exists and File.stat, as per enforced lint…
f09da78 
… rule (flutter#183463)

`avoid_slow_async_io` is already enforced, but there was a bug where it
wasn't catching `File.exists` and `File.stat`. This PR prepares
flutter/flutter for a fix.

The fix is landing to support extension types:
dart-lang/sdk#58838.
The fix will be a re-landing of
https://dart-review.googlesource.com/c/sdk/+/486420.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (flutte…
df1c19b 
…r#11276)

Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. team-ios Owned by iOS platform team team-macos Owned by the macOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srawlins @bkonyi