-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Extension type] linter support #58838
Copy link
Copy link
Closed
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.area-metaCross-cutting, high-level issues (for tracking many other implementation issues, ...).Cross-cutting, high-level issues (for tracking many other implementation issues, ...).devexp-linterIssues with the analyzer's support for the linter packageIssues with the analyzer's support for the linter packagelinter-new-language-featurelinter-set-corelinter-set-flutterlinter-set-recommendedtype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Description
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.area-metaCross-cutting, high-level issues (for tracking many other implementation issues, ...).Cross-cutting, high-level issues (for tracking many other implementation issues, ...).devexp-linterIssues with the analyzer's support for the linter packageIssues with the analyzer's support for the linter packagelinter-new-language-featurelinter-set-corelinter-set-flutterlinter-set-recommendedtype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Type
Fields
Give feedbackNo fields configured for issues without a type.
A meta-issue to discuss and track work on linter support for extension types.
Feature Spec
Existing Lints
Some existing lints will need tests (minimally) and possibly enhanced implementations.
annotate_overridessupport for extension types #59263avoid_catching_errors, see [Extension type] linter support #58838avoid_setters_without_getterssupport for extension types #59264avoid_shadowing_type_parameterssupport for extension types #59253avoid_slow_async_io, see [Extension type] linter support #58838avoid_types_as_parameter_types, see [Extension type] linter support #58838avoid_type_to_stringsupport for extension types #59326avoid_types_as_parameter_namessupport for extension types #59294await_only_futuressupport for extension types #59252cancel_subscriptions, see [Extension type] linter support #58838camel_case_typessupport for extension types #59272collection_methods_unrelated_type, see [Extension type] linter support #58838close_sinks, see [Extension type] linter support #58838deprecated_member_use_from_same_packagesupport for extension types #59271diagnostic_describe_all_propertiessupport for extension typesdiscarded_futures, see [Extension type] linter support #58838hash_and_equalssupport for extension types #59247library_private_types_in_public_apisupport for extension types #59242non_constant_identifier_namessupport for extension types #59254only_throw_errors, see [Extension type] linter support #58838overridden_fieldssupport for extension typespackage_api_docssupport for extension typesprefer_asserts_in_initializer_listssupport for extension types #59324prefer_const_constructorssupport for extension types #59274prefer_const_constructors_in_immutablessupport for extension types #59275prefer_const_declarationssupport for extension typesprefer_const_literals_to_create_immutablessupport for extension types #59276prefer_constructors_over_static_methodssupport for extension types #59250prefer_final_fieldssupport for extension types #59243prefer_void_to_nullfalse positive for extension types #59308public_member_api_docssupport for extension types #59239sort_constructors_firstsupport for extension types #59245sort_unnamed_constructors_firstsupport for extension types #59246type_annotate_public_apissupport for extension types #59270unnecessary_constructor_namesupport for extension types #59249unnecessary_getters_setterssupport for extension types #59266unnecessary_overridessupport for extension typesunnecessary_thissupport for extension types #59248unreachable_from_main, see [Extension type] linter support #58838unrelated_type_equality_checks] Missing report for unrelated extension types #59373unsafe_html, see [Extension type] linter support #58838use_key_in_widget_constructorssupport for extension typesuse_late_for_private_fields_and_variablessupport for extension types #59251🚧 Incomplete list: feedback welcome! 🚧
New Lints
Users of extension types might benefit from some new lints.
annotate_redeclares#59297See also: #53121
...