Skip to content

Add a platform OpenGL context.#183715

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
robert-ancell:linux-platform-context
Mar 16, 2026
Merged

Add a platform OpenGL context.#183715
auto-submit[bot] merged 2 commits into
flutter:masterfrom
robert-ancell:linux-platform-context

Conversation

@robert-ancell

@robert-ancell robert-ancell commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Switch the compositor from using the engine OpenGL context to a new context for the platform thread. When creating windows with the new multi-window API (calls come from Dart code) the FlView would try and make shaders but fail since the engine context was already current.

This would show when running the multiple_windows example as: ** (com.example.multiple_windows:1244082): WARNING **: 14:09:30.400: Failed to setup compositor shaders, unable to make OpenGL context current

@robert-ancell
Add a platform OpenGL context.
1eba5ca 
Switch the compositor from using the engine OpenGL context to a new
context for the platform thread. When creating windows with the new
multi-window API (calls come from Dart code) the FlView would try
and make shaders but fail since the engine context was already current.

This would show when running the multiple_windows example as:
** (com.example.multiple_windows:1244082): WARNING **: 14:09:30.400: Failed to setup compositor shaders, unable to make OpenGL context current
@robert-ancell robert-ancell requested a review from a team as a code owner March 16, 2026 01:10
@flutter-dashboard

flutter-dashboard Bot commented Mar 16, 2026

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop team-linux Owned by the Linux platform team labels Mar 16, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a dedicated OpenGL context for the platform thread to address context contention issues in multi-window scenarios. The changes involve creating a new platform_context in FlOpenGLManager, providing a function to make it current, and utilizing this new context within FlCompositorOpenGL for shader operations. The approach is sound and directly resolves the issue described. I have one suggestion to enhance robustness by adding error handling for the new context's creation.

Comment thread engine/src/flutter/shell/platform/linux/fl_opengl_manager.cc
@robert-ancell robert-ancell requested a review from mattkae March 16, 2026 02:04
@mattkae mattkae added the CICD Run CI/CD label Mar 16, 2026
mattkae
mattkae approved these changes Mar 16, 2026
View reviewed changes

@mattkae mattkae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robert-ancell robert-ancell added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Mar 16, 2026
Merged via the queue into flutter:master with commit cbf31c8 Mar 16, 2026
189 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2026
@loic-sharma

loic-sharma commented Mar 17, 2026

Copy link
Copy Markdown
Member

@robert-ancell Sorry for the late review. On Windows we structured things such that all platform thread work on the engine's OpenGL context is done before the engine is initialized. Is that approach not feasible for Linux?

@robert-ancell robert-ancell deleted the linux-platform-context branch March 17, 2026 00:33
@robert-ancell

robert-ancell commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

This is occurring when we make the FFI calls from Dart. The engine has made the render context current, but not cleared it. So when _window_linux.dart creates a view it tries to access the same render context from another thread and fails. Views can be created at any point so this has to be done after the engine is initialized. We have to perform some OpenGL shader setup for each GTK view, I suspect this is not required in the Windows embedder.

@loic-sharma

loic-sharma commented Mar 17, 2026

Copy link
Copy Markdown
Member

We have to perform some OpenGL shader setup for each GTK view, I suspect this is not required in the Windows embedder.

@robert-ancell Just curious, why can't we use the same shader for all views?

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
cbf31c802 Add a platform OpenGL context. (flutter/flutter#183715)
f373ff3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
cbf31c802 Add a platform OpenGL context. (flutter/flutter#183715)
9ae0760
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
cbf31c802 Add a platform OpenGL context. (flutter/flutter#183715)
6a85900
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2026
@engine-flutter-autoroll
cbf31c802 Add a platform OpenGL context. (flutter/flutter#183715)
e3dca11
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Mar 18, 2026
@engine-flutter-autoroll
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (#11276)
afa1a1c 
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
@robert-ancell robert-ancell mentioned this pull request Mar 19, 2026
Open
@robert-ancell

robert-ancell commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

@robert-ancell Just curious, why can't we use the same shader for all views?

That's a good point - I think we just ended up this way due to the single view history. We should change this: #183911

@Piinks Piinks mentioned this pull request Mar 20, 2026
Open
nateshmbhat pushed a commit to nateshmbhat/flutter_packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (flutte…
e312fb7 
…r#11276)

Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
@engine-flutter-autoroll @okorohelijah
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (flutte…
8c900f2 
…r#11276)

Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@robert-ancell @mboetger
Add a platform OpenGL context. (flutter#183715)
d23dcae 
Switch the compositor from using the engine OpenGL context to a new
context for the platform thread. When creating windows with the new
multi-window API (calls come from Dart code) the FlView would try and
make shaders but fail since the engine context was already current.

This would show when running the multiple_windows example as: **
(com.example.multiple_windows:1244082): WARNING **: 14:09:30.400: Failed
to setup compositor shaders, unable to make OpenGL context current
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Apr 14, 2026
@robert-ancell @ahmedsameha1
Add a platform OpenGL context. (flutter#183715)
f181a12 
Switch the compositor from using the engine OpenGL context to a new
context for the platform thread. When creating windows with the new
multi-window API (calls come from Dart code) the FlView would try and
make shaders but fail since the engine context was already current.

This would show when running the multiple_windows example as: **
(com.example.multiple_windows:1244082): WARNING **: 14:09:30.400: Failed
to setup compositor shaders, unable to make OpenGL context current
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions) (flutte…
df1c19b 
…r#11276)

Roll Flutter from 732e05dd483c to d117642c18e0 (47 revisions)

flutter/flutter@732e05d...d117642

2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa3bb1f60d99 to dba893a44d7a (1 revision) (flutter/flutter#183783)
2026-03-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]fix admob banner scrollable on ios 18.2 (flutter/flutter#183274)
2026-03-17 engine-flutter-autoroll@skia.org Roll Packages from 0f2eeae to a9d36fb (2 revisions) (flutter/flutter#183782)
2026-03-17 mdebbar@google.com Update goldctl version (flutter/flutter#183538)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69be1087807b to fa3bb1f60d99 (1 revision) (flutter/flutter#183779)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 38dedf00c2cd to 30cdd2634429 (1 revision) (flutter/flutter#183778)
2026-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from s7rq9m8tH2aZtX-kP... to zYBvfzIH95BY3cCzL... (flutter/flutter#183777)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from 4ea039236580 to 69be1087807b (2 revisions) (flutter/flutter#183772)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from fb402093cfb5 to 4ea039236580 (1 revision) (flutter/flutter#183770)
2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from d6bc6d17d637 to fb402093cfb5 (8 revisions) (flutter/flutter#183765)
2026-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ff50ab8ecea4 to 38dedf00c2cd (2 revisions) (flutter/flutter#183764)
2026-03-17 robert.ancell@canonical.com Wrap EGL image usage in a GObject (flutter/flutter#183539)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds platform_view_test_macos_impeller (flutter/flutter#183760)
2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds flush to metal screenshotter. (flutter/flutter#183758)
2026-03-16 robert.ancell@canonical.com Add a platform OpenGL context. (flutter/flutter#183715)
2026-03-16 123626410+sanketudaypatil@users.noreply.github.com Fix formatting, capitalization, and grammar in activation issue template (flutter/flutter#183061)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4a6febbf882e to ff50ab8ecea4 (2 revisions) (flutter/flutter#183739)
2026-03-16 kevin.lamenzo@gmail.com docs: add code review guidance to CONTRIBUTING.md (flutter/flutter#182778)
2026-03-16 737941+loic-sharma@users.noreply.github.com Filter 'waiting for customer response' issues from macOS triage (flutter/flutter#183552)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds github action to reset cicd when new branches come (flutter/flutter#183675)
2026-03-16 30870216+gaaclarke@users.noreply.github.com Adds macos impeller complex layout performance test (flutter/flutter#183669)
2026-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from b74e5b537d71 to 4a6febbf882e (2 revisions) (flutter/flutter#183695)
2026-03-16 jason-simmons@users.noreply.github.com Use properties to configure leak_tracking and test_randomization_off in .ci.yaml (flutter/flutter#183605)
2026-03-16 srawlins@google.com [flutter_tools] Avoid File.exists and File.stat, as per enforced lint rule (flutter/flutter#183463)
2026-03-16 eyas.sharaiha@gmail.com Properly parse URIs for testPath when the host is running on Windows. (flutter/flutter#176881)
2026-03-16 engine-flutter-autoroll@skia.org Roll Packages from 91f7c33 to 0f2eeae (6 revisions) (flutter/flutter#183730)
2026-03-16 engine-flutter-autoroll@skia.org Roll Skia from a6ccaf95c6e0 to d6bc6d17d637 (5 revisions) (flutter/flutter#183726)
2026-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WOfyEFkxf9JX26VS-... to s7rq9m8tH2aZtX-kP... (flutter/flutter#183723)
2026-03-15 engine-flutter-autoroll@skia.org Roll Skia from 34ace196b838 to a6ccaf95c6e0 (2 revisions) (flutter/flutter#183712)
2026-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAWG8mRvsQHblDBsy... to WOfyEFkxf9JX26VS-... (flutter/flutter#183694)
2026-03-14 engine-flutter-autoroll@skia.org Roll Skia from 06106120c6bf to 34ace196b838 (1 revision) (flutter/flutter#183677)
2026-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a3dc9d4f881 to b74e5b537d71 (2 revisions) (flutter/flutter#183676)
2026-03-14 jacksongardner@google.com Add some quality of life improvements to the release GitHub workflows. (flutter/flutter#183658)
2026-03-14 ishaquehassan@gmail.com Fix RouteAware.didPushNext documentation inaccuracy (flutter/flutter#183097)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds complex layout impeller startup benchmark (flutter/flutter#183655)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Adds switch for sdf rendering plus golden tests (flutter/flutter#183543)
2026-03-13 30870216+gaaclarke@users.noreply.github.com Made complex_layout_scroll_perf explicitly skia (flutter/flutter#183663)
2026-03-13 47866232+chunhtai@users.noreply.github.com Update android integration test to match the current android semantics (flutter/flutter#183548)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 6c0346103c24 to 06106120c6bf (3 revisions) (flutter/flutter#183654)
2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d5f6d3c17499 to 6a3dc9d4f881 (1 revision) (flutter/flutter#183652)
2026-03-13 108678139+manu-sncf@users.noreply.github.com Fix PinnedHeaderSliver semantics focus capture (flutter/flutter#179023)
2026-03-13 jhy03261997@gmail.com [a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes (flutter/flutter#183606)
2026-03-13 1063596+reidbaker@users.noreply.github.com Update gradle utils to know about kgp 2.3.10 constraints (flutter/flutter#183416)
2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 029229d8be91 to 6c0346103c24 (5 revisions) (flutter/flutter#183648)
2026-03-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJbpv4J_tjW-wuKDq... to vAWG8mRvsQHblDBsy... (flutter/flutter#183646)
2026-03-13 mengyanshou@gmail.com [flutter_tools] Support flavors and transformers for shaders (flutter/flutter#181889)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes
@loic-sharma loic-sharma Awaiting requested review from loic-sharma
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mattkae mattkae

Labels

a: desktop Running on desktop CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically team-linux Owned by the Linux platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robert-ancell @loic-sharma @mattkae