Skip to content

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jan 8, 2026

Dart tests now also run against the metal backend on platforms where that is supported.

test exempt: it is a test

issue: #180601

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 8, 2026
@gaaclarke gaaclarke force-pushed the flutter-tester-metal branch from 27bb348 to d5b28c0 Compare January 8, 2026 21:22
@gaaclarke gaaclarke marked this pull request as ready for review January 8, 2026 22:49
@gaaclarke gaaclarke added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jan 8, 2026
@gaaclarke
Copy link
Member Author

It might be worth waiting for

to be removed before landing this. I'm looking into that now.

@gaaclarke
Copy link
Member Author

don't land until #180759

@gaaclarke
Copy link
Member Author

don't land until #180759

#180788 now which has landed

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Jan 13, 2026
Merged via the queue into flutter:master with commit 1418863 Jan 13, 2026
181 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 15, 2026
Manual roll requested by tarrinneal@google.com

flutter/flutter@793b0b8...b45a73b

2026-01-13 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#180900)
2026-01-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 34318de9874b to ebaf52c13799 (1 revision) (flutter/flutter#180870)
2026-01-13 ahmedsameha1@gmail.com Make sure that an ErrorWidget doesn't crash in 0x0 environment (flutter/flutter#180830)
2026-01-13 ahmedsameha1@gmail.com Make sure that a Banner doesn't crash in 0x0 environment (flutter/flutter#180254)
2026-01-13 30870216+gaaclarke@users.noreply.github.com Adds metal background to engine dart tests (flutter/flutter#180700)
2026-01-13 huy@nevercode.io Add TabBar API example for scroll notification integration (flutter/flutter#180728)
2026-01-13 engine-flutter-autoroll@skia.org Roll Skia from 714d0af2eda7 to 8f3134206e8d (1 revision) (flutter/flutter#180874)
2026-01-13 97480502+b-luk@users.noreply.github.com Add build-time checks for ImpellerC's SkSL compiler (flutter/flutter#180861)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ikramhasan pushed a commit to ikramhasan/flutter that referenced this pull request Jan 15, 2026
Dart tests now also run against the metal backend on platforms where
that is supported.

test exempt: it is a test

issue: flutter#180601

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants