Make sure that an ErrorWidget doesn't crash in 0x0 environment #180830
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new widget test for ErrorWidget. The test verifies that ErrorWidget does not crash when it is rendered within a zero-sized area. It does this by placing an ErrorWidget inside a SizedBox.shrink() and asserting that its size is Size.zero after pumping the widget. My review of the new test code did not find any issues.
victorsanni
approved these changes
Jan 12, 2026
dkwingsmt
approved these changes
Jan 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 15, 2026
Manual roll requested by tarrinneal@google.com flutter/flutter@793b0b8...b45a73b 2026-01-13 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#180900) 2026-01-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 34318de9874b to ebaf52c13799 (1 revision) (flutter/flutter#180870) 2026-01-13 ahmedsameha1@gmail.com Make sure that an ErrorWidget doesn't crash in 0x0 environment (flutter/flutter#180830) 2026-01-13 ahmedsameha1@gmail.com Make sure that a Banner doesn't crash in 0x0 environment (flutter/flutter#180254) 2026-01-13 30870216+gaaclarke@users.noreply.github.com Adds metal background to engine dart tests (flutter/flutter#180700) 2026-01-13 huy@nevercode.io Add TabBar API example for scroll notification integration (flutter/flutter#180728) 2026-01-13 engine-flutter-autoroll@skia.org Roll Skia from 714d0af2eda7 to 8f3134206e8d (1 revision) (flutter/flutter#180874) 2026-01-13 97480502+b-luk@users.noreply.github.com Add build-time checks for ImpellerC's SkSL compiler (flutter/flutter#180861) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ikramhasan
pushed a commit
to ikramhasan/flutter
that referenced
this pull request
Jan 15, 2026
…er#180830) This is my attempt to handle flutter#6537 for the ErrorWidget widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the ErrorWidget widget.