Skip to content

Update window settings as they change rather than the more outdated "Apply" pattern. #179861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Dec 15, 2025
Merged

Update window settings as they change rather than the more outdated "Apply" pattern. #179861

auto-submit merged 3 commits into from
Dec 15, 2025

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Dec 15, 2025

No description provided.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 15, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the d: examples Sample code and demos label Dec 15, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the window settings dialog to update settings in real-time as the user types, replacing the old 'Apply' button pattern. While this improves the user experience, the implementation has a couple of issues. There is a memory leak due to not disposing of TextEditingControllers and their listeners. Additionally, there's an underlying architectural issue where state changes are not correctly propagated to the rest of the UI because a mutable object is used with an InheritedWidget. I've provided suggestions to address both of these high-severity issues.

examples/multiple_windows/lib/app/window_settings_dialog.dart
Comment on lines +119 to +126
void _updateRegularSize() {
widget.settings.regularSize = Size(
double.tryParse(_regularWidthController.text) ??
widget.settings.regularSize.width,
double.tryParse(_regularHeightController.text) ??
widget.settings.regularSize.height,
);
}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

You are directly mutating widget.settings. However, WindowSettingsAccessor is an InheritedWidget whose updateShouldNotify method performs a simple reference check on the windowSettings object. This means that mutating the object's properties will not cause dependent widgets to rebuild, which can lead to an inconsistent UI state.

With the new live-update behavior, it's crucial that changes are propagated correctly. A better approach would be to make WindowSettings a ChangeNotifier and use an InheritedNotifier for WindowSettingsAccessor. This would ensure that dependent widgets are notified and rebuilt when settings change.

Copy link
Contributor

@mattkae mattkae Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably for another PR, as this was preexisting

mattkae
mattkae reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take Gemini's feedback into consideration

@robert-ancell @gemini-code-assist
Update examples/multiple_windows/lib/app/window_settings_dialog.dart
a0834b0 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mattkae
mattkae approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio 👍

@robert-ancell
Copy link
Contributor Author

robert-ancell commented Dec 15, 2025

I wondered if the missing whitespace line would trigger the formatter, and it did. Gemini you need to improve your style :)

@robert-ancell robert-ancell added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2025
@robert-ancell
Copy link
Contributor Author

robert-ancell commented Dec 15, 2025

I'm ignoring the missing tests warning as this clearly doesn't require them as an example.

@auto-submit auto-submit bot added this pull request to the merge queue Dec 15, 2025
Merged via the queue into flutter:master with commit 1ff8352 Dec 15, 2025
39 of 40 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
4f9bbbf 
…tdated "Apply" pattern. (flutter/flutter#179861)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
5958e07 
…tdated "Apply" pattern. (flutter/flutter#179861)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
31b2449 
…tdated "Apply" pattern. (flutter/flutter#179861)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
c054eea 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
b7e70d2 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
66cc460 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
7ed4411 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
9174db3 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
aff38ae 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
ccc1c40 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
b9a5137 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
2efb7ca 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
32feb07 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
dd9f781 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
d0d8895 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
c654b1a 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
de9a786 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
7c58b1f 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
ef077fc 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
f3f765f 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
84382d6 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
5a0c6a8 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
559d6b5 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
93397ef 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
3464334 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
6af2359 
…tdated "Apply" pattern. (flutter/flutter#179861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
1ff8352 Update window settings as they change rather than the more ou…
a4190e0 
…tdated "Apply" pattern. (flutter/flutter#179861)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
Roll Flutter from 6e1aa823523d to d81baabfec4c (47 revisions) (#10637)
d9ed827 
Roll Flutter from 6e1aa82 to d81baab (47 revisions)

flutter/flutter@6e1aa82...d81baab

2025-12-16 68449066+zijiehe-google-com@users.noreply.github.com Revert "chore: linux fuchsia tests are flaking" (flutter/flutter#179897)
2025-12-15 planetmarshall@users.noreply.github.com add default-linux-sysroot to gn frontend args (flutter/flutter#179303)
2025-12-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#179751)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 783ce2077e46 to 6903a4e65c3f (2 revisions) (flutter/flutter#179903)
2025-12-15 adilhanney@disroot.org Add `Adwaita Sans` as a font fallback on Linux (flutter/flutter#179144)
2025-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unmodified android sdk bundle (#179647)" (flutter/flutter#179904)
2025-12-15 robert.ancell@canonical.com Update window settings as they change rather than the more outdated "Apply" pattern. (flutter/flutter#179861)
2025-12-15 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 5.0.1 to 6.0.0 in the all-github-actions group (flutter/flutter#179901)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 9decbd4c216b to 783ce2077e46 (2 revisions) (flutter/flutter#179896)
2025-12-15 34871572+gmackall@users.noreply.github.com Unmodified android sdk bundle (flutter/flutter#179647)
2025-12-15 mdebbar@google.com [web] Fix `resizeToAvoidBottomInset` on Android web (flutter/flutter#179581)
2025-12-15 iliyazelenkog@gmail.com Suppress deprecation warning for AChoreographer_postFrameCallback (flutter/flutter#178580)
2025-12-15 planetmarshall@users.noreply.github.com remove unnecessary virtual destructor from VertexDescriptor (flutter/flutter#178682)
2025-12-15 engine-flutter-autoroll@skia.org Roll Dart SDK from b245f6022727 to 20d114f951db (1 revision) (flutter/flutter#179893)
2025-12-15 jason-simmons@users.noreply.github.com [Impeller] Delete GLES framebuffer objects only on the thread where they were created (flutter/flutter#179768)
2025-12-15 jason-simmons@users.noreply.github.com [Impeller] Convert paths in ImpellerC command line flags to std::filesystem::path objects (flutter/flutter#179717)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 5e1ff611b36b to 9decbd4c216b (2 revisions) (flutter/flutter#179890)
2025-12-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DtfDWAx6t_CsD2e1W... to 433KtmJvbMyaDMJvD... (flutter/flutter#179889)
2025-12-15 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary unboxing in `FlutterLoader.java‎` (flutter/flutter#179869)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from f04f8ca3b284 to 5e1ff611b36b (1 revision) (flutter/flutter#179882)
2025-12-15 engine-flutter-autoroll@skia.org Roll Packages from 0ac7a03 to 2cd921c (1 revision) (flutter/flutter#179885)
2025-12-15 bkonyi@google.com [ Widget Preview ] Pass DTD URI as a constant in a generated file (flutter/flutter#179821)
2025-12-15 116356835+AbdeMohlbi@users.noreply.github.com Bump minSdk to `24` in `engine` (flutter/flutter#175508)
2025-12-15 engine-flutter-autoroll@skia.org Roll Dart SDK from bca8bb37d95f to b245f6022727 (1 revision) (flutter/flutter#179879)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from eb1347d18957 to f04f8ca3b284 (1 revision) (flutter/flutter#179876)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 41bcfb848b13 to eb1347d18957 (1 revision) (flutter/flutter#179871)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from d194c3b7a9a9 to 41bcfb848b13 (6 revisions) (flutter/flutter#179866)
2025-12-14 robert.ancell@canonical.com Remove obsolete windowing channel (flutter/flutter#179718)
2025-12-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SCLq31whvg8nJvuYE... to DtfDWAx6t_CsD2e1W... (flutter/flutter#179856)
2025-12-14 engine-flutter-autoroll@skia.org Roll Skia from 5d98ce0af031 to d194c3b7a9a9 (1 revision) (flutter/flutter#179854)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from f9b242d9a365 to 5d98ce0af031 (1 revision) (flutter/flutter#179843)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from abe90c72cf56 to f9b242d9a365 (1 revision) (flutter/flutter#179838)
2025-12-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fppT9ZrwbFx7iYrIh... to SCLq31whvg8nJvuYE... (flutter/flutter#179836)
2025-12-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 34654f2a3baa to bca8bb37d95f (1 revision) (flutter/flutter#179835)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from 9e7c893bb593 to abe90c72cf56 (1 revision) (flutter/flutter#179830)
2025-12-13 engine-flutter-autoroll@skia.org Roll Dart SDK from f105c2168574 to 34654f2a3baa (1 revision) (flutter/flutter#179823)
2025-12-13 97480502+b-luk@users.noreply.github.com Add FilterQuality parameter to FragmentShader.setImageSampler (flutter/flutter#179760)
2025-12-13 evanwall@buffalo.edu Add profiling counts to pipeline uses (flutter/flutter#179374)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from edf52cb27f29 to 9e7c893bb593 (3 revisions) (flutter/flutter#179819)
2025-12-12 jacksongardner@google.com Update Skwasm to engine style guidelines. (flutter/flutter#179756)
2025-12-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 9a65db770758 to f105c2168574 (5 revisions) (flutter/flutter#179814)
2025-12-12 engine-flutter-autoroll@skia.org Roll Skia from f23b00a407a4 to edf52cb27f29 (5 revisions) (flutter/flutter#179807)
2025-12-12 97480502+b-luk@users.noreply.github.com Use depth buffer to implement geometry overdraw protection (flutter/flutter#179426)
2025-12-12 nshahan@google.com [flutter_tool] Force UTF-8 character set for dev (flutter/flutter#179419)
2025-12-12 engine-flutter-autoroll@skia.org Roll Skia from e66816c3645e to f23b00a407a4 (2 revisions) (flutter/flutter#179798)
2025-12-12 30870216+gaaclarke@users.noreply.github.com Implements decodeImageFromPixelsSync (flutter/flutter#179519)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-ancell @mattkae