Skip to content

[flutter_tool] Force UTF-8 character set for dev #179419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Dec 12, 2025
Merged

[flutter_tool] Force UTF-8 character set for dev #179419

auto-submit merged 5 commits into from
Dec 12, 2025

Conversation

@nshahan
Copy link
Contributor

@nshahan nshahan commented Dec 3, 2025

  • Set the character set on the response for the index.html
    when running the app with flutter tool.
  • Add expectation to existing test that verifies the character
    set on the requested index.html reponse.

Fixes: dart-lang/sdk#62090

@nshahan
[flutter_tool] Force UTF-8 character set for dev
6c15d52 
Sets the character set on the response for the index.html
when running the app with flutter tool.

Fixes: dart-lang/sdk#62090
@nshahan
Add charset check to exisitng index.html test
9d43900
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 3, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly forces the UTF-8 character set for index.html responses from the development server, which helps prevent encoding issues. The change is simple and effective, and it's accompanied by a test that verifies the Content-Type header now includes charset=utf-8. I have one minor suggestion to improve the robustness of the implementation.

packages/flutter_tools/lib/src/isolated/web_asset_server.dart Outdated
flutterJsFile: _flutterJsFile,
flutterBootstrapJs: _flutterBootstrapJsContent,
),
encoding: Encoding.getByName('utf-8'),
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For robustness and clarity, it's better to use the utf8 constant from dart:convert instead of looking up the encoding by name with Encoding.getByName('utf-8'). Using the constant avoids a string-based lookup that could fail at runtime if there's a typo, and it's more idiomatic in Dart.

Suggested change
encoding: Encoding.getByName('utf-8'),
encoding: utf8,

Copy link
Contributor Author

@nshahan nshahan Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nshahan nshahan requested a review from bkonyi December 3, 2025 22:33
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 11, 2025

autosubmit label was removed for flutter/flutter/179419, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2025
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 11, 2025

autosubmit label was removed for flutter/flutter/179419, because - The status or check suite Linux tool_integration_tests_5_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 12, 2025
Merged via the queue into flutter:master with commit 43f3f92 Dec 12, 2025
141 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
caac25f 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
1a57f86 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
a69e5d2 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
c88ec76 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
1720cb7 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
fe66e3e 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
f7e27c7 
…tter#179419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
754d520 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
571b3c5 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
67902e7 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
07012b1 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
395161b 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
66e67a5 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
43f3f920a [flutter_tool] Force UTF-8 character set for dev (flutter/f…
ddef30d 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
d324812 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
7512aee 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
e82d43d 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
37bf503 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
dbbc0c9 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
d061208 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
c5cded0 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
d26bd20 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
7fa26d3 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
9eda5b4 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
fc9e136 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
6400393 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
ae7fde3 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
eac522a 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
502bc38 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
13612dc 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
f6ad3fc 
…tter#179419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
43f3f92 [flutter_tool] Force UTF-8 character set for dev (flutter/flu…
852d3f1 
…tter#179419)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
Roll Flutter from 6e1aa823523d to d81baabfec4c (47 revisions) (#10637)
d9ed827 
Roll Flutter from 6e1aa82 to d81baab (47 revisions)

flutter/flutter@6e1aa82...d81baab

2025-12-16 68449066+zijiehe-google-com@users.noreply.github.com Revert "chore: linux fuchsia tests are flaking" (flutter/flutter#179897)
2025-12-15 planetmarshall@users.noreply.github.com add default-linux-sysroot to gn frontend args (flutter/flutter#179303)
2025-12-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#179751)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 783ce2077e46 to 6903a4e65c3f (2 revisions) (flutter/flutter#179903)
2025-12-15 adilhanney@disroot.org Add `Adwaita Sans` as a font fallback on Linux (flutter/flutter#179144)
2025-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unmodified android sdk bundle (#179647)" (flutter/flutter#179904)
2025-12-15 robert.ancell@canonical.com Update window settings as they change rather than the more outdated "Apply" pattern. (flutter/flutter#179861)
2025-12-15 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 5.0.1 to 6.0.0 in the all-github-actions group (flutter/flutter#179901)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 9decbd4c216b to 783ce2077e46 (2 revisions) (flutter/flutter#179896)
2025-12-15 34871572+gmackall@users.noreply.github.com Unmodified android sdk bundle (flutter/flutter#179647)
2025-12-15 mdebbar@google.com [web] Fix `resizeToAvoidBottomInset` on Android web (flutter/flutter#179581)
2025-12-15 iliyazelenkog@gmail.com Suppress deprecation warning for AChoreographer_postFrameCallback (flutter/flutter#178580)
2025-12-15 planetmarshall@users.noreply.github.com remove unnecessary virtual destructor from VertexDescriptor (flutter/flutter#178682)
2025-12-15 engine-flutter-autoroll@skia.org Roll Dart SDK from b245f6022727 to 20d114f951db (1 revision) (flutter/flutter#179893)
2025-12-15 jason-simmons@users.noreply.github.com [Impeller] Delete GLES framebuffer objects only on the thread where they were created (flutter/flutter#179768)
2025-12-15 jason-simmons@users.noreply.github.com [Impeller] Convert paths in ImpellerC command line flags to std::filesystem::path objects (flutter/flutter#179717)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 5e1ff611b36b to 9decbd4c216b (2 revisions) (flutter/flutter#179890)
2025-12-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DtfDWAx6t_CsD2e1W... to 433KtmJvbMyaDMJvD... (flutter/flutter#179889)
2025-12-15 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary unboxing in `FlutterLoader.java‎` (flutter/flutter#179869)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from f04f8ca3b284 to 5e1ff611b36b (1 revision) (flutter/flutter#179882)
2025-12-15 engine-flutter-autoroll@skia.org Roll Packages from 0ac7a03 to 2cd921c (1 revision) (flutter/flutter#179885)
2025-12-15 bkonyi@google.com [ Widget Preview ] Pass DTD URI as a constant in a generated file (flutter/flutter#179821)
2025-12-15 116356835+AbdeMohlbi@users.noreply.github.com Bump minSdk to `24` in `engine` (flutter/flutter#175508)
2025-12-15 engine-flutter-autoroll@skia.org Roll Dart SDK from bca8bb37d95f to b245f6022727 (1 revision) (flutter/flutter#179879)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from eb1347d18957 to f04f8ca3b284 (1 revision) (flutter/flutter#179876)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from 41bcfb848b13 to eb1347d18957 (1 revision) (flutter/flutter#179871)
2025-12-15 engine-flutter-autoroll@skia.org Roll Skia from d194c3b7a9a9 to 41bcfb848b13 (6 revisions) (flutter/flutter#179866)
2025-12-14 robert.ancell@canonical.com Remove obsolete windowing channel (flutter/flutter#179718)
2025-12-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SCLq31whvg8nJvuYE... to DtfDWAx6t_CsD2e1W... (flutter/flutter#179856)
2025-12-14 engine-flutter-autoroll@skia.org Roll Skia from 5d98ce0af031 to d194c3b7a9a9 (1 revision) (flutter/flutter#179854)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from f9b242d9a365 to 5d98ce0af031 (1 revision) (flutter/flutter#179843)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from abe90c72cf56 to f9b242d9a365 (1 revision) (flutter/flutter#179838)
2025-12-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fppT9ZrwbFx7iYrIh... to SCLq31whvg8nJvuYE... (flutter/flutter#179836)
2025-12-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 34654f2a3baa to bca8bb37d95f (1 revision) (flutter/flutter#179835)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from 9e7c893bb593 to abe90c72cf56 (1 revision) (flutter/flutter#179830)
2025-12-13 engine-flutter-autoroll@skia.org Roll Dart SDK from f105c2168574 to 34654f2a3baa (1 revision) (flutter/flutter#179823)
2025-12-13 97480502+b-luk@users.noreply.github.com Add FilterQuality parameter to FragmentShader.setImageSampler (flutter/flutter#179760)
2025-12-13 evanwall@buffalo.edu Add profiling counts to pipeline uses (flutter/flutter#179374)
2025-12-13 engine-flutter-autoroll@skia.org Roll Skia from edf52cb27f29 to 9e7c893bb593 (3 revisions) (flutter/flutter#179819)
2025-12-12 jacksongardner@google.com Update Skwasm to engine style guidelines. (flutter/flutter#179756)
2025-12-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 9a65db770758 to f105c2168574 (5 revisions) (flutter/flutter#179814)
2025-12-12 engine-flutter-autoroll@skia.org Roll Skia from f23b00a407a4 to edf52cb27f29 (5 revisions) (flutter/flutter#179807)
2025-12-12 97480502+b-luk@users.noreply.github.com Use depth buffer to implement geometry overdraw protection (flutter/flutter#179426)
2025-12-12 nshahan@google.com [flutter_tool] Force UTF-8 character set for dev (flutter/flutter#179419)
2025-12-12 engine-flutter-autoroll@skia.org Roll Skia from e66816c3645e to f23b00a407a4 (2 revisions) (flutter/flutter#179798)
2025-12-12 30870216+gaaclarke@users.noreply.github.com Implements decodeImageFromPixelsSync (flutter/flutter#179519)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WEB] app will not start if index.html is missing meta charset tag

2 participants

@nshahan @bkonyi