-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add FAQ entry about our attempts to remove Skia image codecs. #177947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new entry to the Impeller FAQ about the investigation into removing Skia image codecs. The new section explains that while this would reduce binary size, the effort to achieve parity with Skia's codecs in performance and reliability was found to be too significant. It links to the relevant GitHub issues for iOS and Android for further details. My review includes a suggestion to improve the readability of these links.
| The results of our investigation are documented in | ||
| https://github.com/flutter/flutter/issues/144438 for removing codecs on iOS and | ||
| in https://github.com/flutter/flutter/issues/177863 for removing codecs on | ||
| Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, consider using a list to present the links to the GitHub issues. This makes them easier to scan and click. Using descriptive link text instead of raw URLs also improves readability. 1
| The results of our investigation are documented in | |
| https://github.com/flutter/flutter/issues/144438 for removing codecs on iOS and | |
| in https://github.com/flutter/flutter/issues/177863 for removing codecs on | |
| Android. | |
| The results of our investigation are documented in the following GitHub issues: | |
| * [#144438: removing codecs on iOS](https://github.com/flutter/flutter/issues/144438) | |
| * [#177863: removing codecs on Android](https://github.com/flutter/flutter/issues/177863) |
Style Guide References
Footnotes
-
The style guide emphasizes optimizing for readability. Using markdown link syntax and a list format improves the readability of the documentation. ↩
gaaclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) flutter/flutter@027f2e4...e5d5c01 2025-11-04 mdebbar@google.com [web] Upgrade Chrome to 141 (for engine tests) (flutter/flutter#177743) 2025-11-04 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated withOpacity in `chip_animation_style.0.dart` example (flutter/flutter#177834) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from 03612114a36d to c89b6118266b (1 revision) (flutter/flutter#177991) 2025-11-04 mdebbar@google.com [web] Delete unused futurize util (flutter/flutter#177861) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from 1a179581af75 to 03612114a36d (1 revision) (flutter/flutter#177984) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from 150f844e83fb to 1a179581af75 (3 revisions) (flutter/flutter#177979) 2025-11-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 6f1bd8d05b1d to 156bf665dba4 (2 revisions) (flutter/flutter#177976) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from 3990fc40acdf to 150f844e83fb (1 revision) (flutter/flutter#177964) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from 85adfd3b8e75 to 3990fc40acdf (1 revision) (flutter/flutter#177962) 2025-11-04 34871572+gmackall@users.noreply.github.com Fix `isHeif` crash (flutter/flutter#177944) 2025-11-04 engine-flutter-autoroll@skia.org Roll Dart SDK from ac065fcd782e to 6f1bd8d05b1d (1 revision) (flutter/flutter#177955) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from 001516d132f0 to 85adfd3b8e75 (4 revisions) (flutter/flutter#177958) 2025-11-04 bkonyi@google.com [ Widget Preview ] Add analytic event that's reported when the previewer is opened (flutter/flutter#177949) 2025-11-04 fluttergithubbot@gmail.com Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#171144) 2025-11-03 engine-flutter-autoroll@skia.org Roll Skia from da9b8fb01101 to 001516d132f0 (6 revisions) (flutter/flutter#177951) 2025-11-03 97480502+b-luk@users.noreply.github.com Add FAQ entry about our attempts to remove Skia image codecs. (flutter/flutter#177947) 2025-11-03 jhy03261997@gmail.com Add blockAccessibilityFocus flag (flutter/flutter#175551) 2025-11-03 ahmedsameha1@gmail.com Make sure that a SnackBarAction doesn't crash in 0x0 environment (flutter/flutter#177899) 2025-11-03 ahmedsameha1@gmail.com Make sure that a SelectionArea doesn't crash in 0x0 environment (flutter/flutter#177876) 2025-11-03 34871572+gmackall@users.noreply.github.com Speculative fix for android_verified_input_test (flutter/flutter#177937) 2025-11-03 kjlubick@users.noreply.github.com [skia] Explicitly disable XPS backend (flutter/flutter#177050) 2025-11-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2d3aa1d5cb9f to ac065fcd782e (2 revisions) (flutter/flutter#177927) 2025-11-03 737941+loic-sharma@users.noreply.github.com Improve Impeller's docs in the top-level docs folder (flutter/flutter#177848) 2025-11-03 ahmedsameha1@gmail.com Make sure that GridTile doesn't crash in 0x0 environment (flutter/flutter#175321) 2025-11-03 ahmedsameha1@gmail.com Make sure that a Slider doesn't crash in 0x0 environment (flutter/flutter#177882) 2025-11-03 planetmarshall@users.noreply.github.com fix(impeller): fix params to glDiscardFrameBufferEXT (flutter/flutter#175589) 2025-11-03 engine-flutter-autoroll@skia.org Roll Skia from 56a10bf56ee0 to da9b8fb01101 (5 revisions) (flutter/flutter#177928) 2025-11-03 47866232+chunhtai@users.noreply.github.com wires up set application locale to web engine (flutter/flutter#177284) 2025-11-03 jesswon@google.com [Android 16] Update `linux_android_emu_unstable` to use avd rev 7 (flutter/flutter#177854) 2025-11-03 ahmedsameha1@gmail.com Make sure that a CheckedPopupMenuItem doesn't crash in 0x0 environment (flutter/flutter#177545) 2025-11-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ynp3qiXocK8WLTjlb... to vxK5obzfr1X9P2kSh... (flutter/flutter#177917) 2025-11-03 130006795+Spivak-adam@users.noreply.github.com Update pubspec.yaml.tmpl build version tracker on line 5 (flutter/flutter#173600) 2025-11-03 jason-simmons@users.noreply.github.com [Impeller] Fix the source rectangle used when rendering an AtlasContents with the strict mode for nine-patch images (flutter/flutter#177860) 2025-11-03 git@reb0.org docs: Default Splash / Loading screen for web app in index.html (flutter/flutter#177084) 2025-11-03 engine-flutter-autoroll@skia.org Roll Skia from 25e1e4e96980 to 56a10bf56ee0 (6 revisions) (flutter/flutter#177910) 2025-11-03 ahmedsameha1@gmail.com Make sure that a PopupMenuItem doesn't crash in 0x0 environment (flutter/flutter#177533) 2025-11-03 ahmedsameha1@gmail.com Make sure that a RefreshProgressIndicator doesn't crash in 0x0 enviro… (flutter/flutter#177556) 2025-11-03 ahmedsameha1@gmail.com Make sure that a PopupMenuButton doesn't crash in 0x0 environment (flutter/flutter#177493) 2025-11-03 ahmedsameha1@gmail.com Make sure that a CircularProgressIndicator doesn't crash in 0x0 envir… (flutter/flutter#177555) 2025-11-02 ahmedsameha1@gmail.com Make sure that a Radio doesn't crash in 0x0 environment (flutter/flutter#177580) 2025-11-02 ahmedsameha1@gmail.com Make sure that a RadioListTile doesn't crash in 0x0 environment (flutter/flutter#177576) 2025-11-02 ahmedsameha1@gmail.com Make sure that an ExpandIcon doesn't crash in 0x0 envrionment (flutter/flutter#175042) 2025-11-02 ahmedsameha1@gmail.com Make sure that a RangeSlider doesn't crash in 0x0 environment (flutter/flutter#177642) 2025-11-02 ahmedsameha1@gmail.com Make sure that a GridTileBar doesn't crash in 0x0 environment (flutter/flutter#177546) 2025-11-02 ahmedsameha1@gmail.com Make sure that a LinearProgressIndicator doesn't crash in 0x0 environ… (flutter/flutter#177553) 2025-11-02 ahmedsameha1@gmail.com Make sure that a PopupMenuDivider doesn't crash in 0x0 environment (flutter/flutter#177445) ...
…r#177947) Adds a FAQ entry referencing our investigations into removing Skia image codecs in flutter#144438 and flutter#177863.
…r#177947) Adds a FAQ entry referencing our investigations into removing Skia image codecs in flutter#144438 and flutter#177863.
Adds a FAQ entry referencing our investigations into removing Skia image codecs in #144438 and #177863.