Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout #176811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… x64 machines and extend its timeout The "Mac build_ios_framework_module_test" builder was being scheduled on either x64 or arm64 machines. The test takes longer when run on an x64 machine and would sometimes exceed the default 30 minute timeout. This PR changes that builder to only run on x64 and use a 45 minute timeout. (There is already a separate "Mac_arm64 build_ios_framework_module_test" that runs only on arm64)
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .ci.yaml configuration file to address test timeouts. The CI target Mac build_ios_framework_module_test is renamed to Mac_x64 build_ios_framework_module_test to specifically target x64 machines. Additionally, the test timeout for this target is increased to 2700 seconds (45 minutes) by adding the test_timeout_secs property. My feedback includes one suggestion to improve the readability of the new timeout value.
| tags: > | ||
| ["devicelab", "hostonly", "mac"] | ||
| task_name: build_ios_framework_module_test | ||
| test_timeout_secs: "2700" |
Contributor
There was a problem hiding this comment.
To improve readability, consider adding a comment explaining that 2700 seconds is 45 minutes. This helps other developers understand the value without having to do the calculation themselves and aligns with the style guide's principle of optimizing for readability.1
# 45 minutes
test_timeout_secs: "2700"Style Guide References
Footnotes
jtmcdole
approved these changes
Oct 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
Member
|
@jmagman @vashworth Do we still need this test to run on both intel and arm? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2025
…ly runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
Contributor
I don't see any particular reason that this test specifically needs to run on both. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2025
… runs on x64 machines and extend its timeout (flutter/flutter#176811)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 15, 2025
Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e11e2c1...7cd821c 2025-10-14 bruno.leroux@gmail.com Fix computeDistanceToActualBaseline throws when accessing child size (flutter/flutter#176906) 2025-10-14 47866232+chunhtai@users.noreply.github.com iOS can set application locale before view controller is set (flutter/flutter#176592) 2025-10-14 jason-simmons@users.noreply.github.com Roll ANGLE to a branch based on d9fa255a5c22 (flutter/flutter#176747) 2025-10-14 47866232+chunhtai@users.noreply.github.com Relands "Fixes keyboard selects disabled radio" (flutter/flutter#176977) 2025-10-14 huy@nevercode.io Fix expansion tile is missing state announcement on non-Apple platforms (flutter/flutter#175480) 2025-10-14 30870216+gaaclarke@users.noreply.github.com impeller: allows access of float uniforms by name (flutter/flutter#176728) 2025-10-14 aam@google.com Roll dart sdk to 3.11.0-17.0.dev (flutter/flutter#176947) 2025-10-13 okorohelijah@google.com Move iOS integration tests (flutter/flutter#176940) 2025-10-13 ahmedsameha1@gmail.com Make sure that an InputDatePickerFormField doesn't crash in 0x0 envir… (flutter/flutter#176047) 2025-10-13 jason-simmons@users.noreply.github.com [web] Match the behavior of other platforms in Web Locale.toString if the country code is an empty string (flutter/flutter#176862) 2025-10-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes keyboard selects disabled radio (#176727)" (flutter/flutter#176958) 2025-10-13 47866232+chunhtai@users.noreply.github.com Fixes keyboard selects disabled radio (flutter/flutter#176727) 2025-10-13 engine-flutter-autoroll@skia.org Roll Packages from e319c40 to d062181 (2 revisions) (flutter/flutter#176916) 2025-10-13 jason-simmons@users.noreply.github.com Roll SwiftShader to 794b0cfce1d8 (flutter/flutter#176806) 2025-10-13 32538273+ValentinVignal@users.noreply.github.com Make DropdownMenu generic type non nullable (flutter/flutter#176711) 2025-10-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BWGpRvpdQh-HJpq1c... to _dd0Jv50H0oUI2Ad8... (flutter/flutter#176895) 2025-10-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JpiUsek1hU5r9QVKP... to BWGpRvpdQh-HJpq1c... (flutter/flutter#176880) 2025-10-11 codefu@google.com fix: content hash check for LUCI_CONTEXT (flutter/flutter#176867) 2025-10-11 34465683+rkishan516@users.noreply.github.com Feat: make tooltip position customizeable (flutter/flutter#175047) 2025-10-11 engine-flutter-autoroll@skia.org Roll Dart SDK from d88d8bf2b53c to 65b171958c93 (3 revisions) (flutter/flutter#176871) 2025-10-11 34465683+rkishan516@users.noreply.github.com feat: apply radioGroup role to segmented control widgets (flutter/flutter#176157) 2025-10-10 ahmedsameha1@gmail.com Make sure that a CheckboxMenuButton doesn't crash in 0x0 environment (flutter/flutter#176450) 2025-10-10 Rusino@users.noreply.github.com [WebParagraph] Support for more styles, placeholders, decorations, etc (flutter/flutter#172853) 2025-10-10 jason-simmons@users.noreply.github.com Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout (flutter/flutter#176811) 2025-10-10 engine-flutter-autoroll@skia.org Roll Packages from 0b41de3 to e319c40 (1 revision) (flutter/flutter#176833) 2025-10-10 danny@tuppeny.com [tool/dap] Forward app.warning events from Flutter to DAP client (flutter/flutter#176827) 2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 70c00d3ceb3a to d88d8bf2b53c (1 revision) (flutter/flutter#176830) 2025-10-10 sokolovskyi.konstantin@gmail.com Remove unnecessary nullable types in examples. (flutter/flutter#176713) 2025-10-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xArtL4DH0FsdwSqG_... to JpiUsek1hU5r9QVKP... (flutter/flutter#176822) 2025-10-10 bruno.leroux@gmail.com Cleanup OutlinedButton.icon documentation and implementation (flutter/flutter#176630) 2025-10-10 34871572+gmackall@users.noreply.github.com [HCPP] Properly remove hcpp views that are no longer visible (flutter/flutter#176742) 2025-10-10 ahmedsameha1@gmail.com Make sure that an InputChip doesn't crash in 0x0 environment (flutter/flutter#175930) 2025-10-10 737941+loic-sharma@users.noreply.github.com Update Flutter templates' Dart style (flutter/flutter#175963) 2025-10-10 ahmedsameha1@gmail.com Make sure that a DropdownButtonFormField doesn't crash in 0x0 environ… (flutter/flutter#174958) 2025-10-10 ahmedsameha1@gmail.com Make sure that an InkWell doesn't crash in 0x0 environment (flutter/flutter#175871) 2025-10-10 ahmedsameha1@gmail.com Handle#6537 end drawer button (flutter/flutter#173026) 2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from a9b7bd4b0b32 to 70c00d3ceb3a (4 revisions) (flutter/flutter#176815) 2025-10-10 robert.ancell@canonical.com Change default Linux thread policy to merge platform and UI threads. (flutter/flutter#176759) 2025-10-09 bkonyi@google.com [ Tool ] Roll package:dwds to 26.0.0 (flutter/flutter#176808) 2025-10-09 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` to include 3.35.6 notes (flutter/flutter#176803) 2025-10-09 36861262+QuncCccccc@users.noreply.github.com Announce text and button together when DropdownMenu is treated as a button (flutter/flutter#176428) 2025-10-09 gregorysconrad@gmail.com [native_assets] create macOS CCompilerConfig via xcrun --find (flutter/flutter#175717) 2025-10-09 chinmaygarde@google.com [Impeller] Fix broken links in README. (flutter/flutter#176770) 2025-10-09 chinmaygarde@google.com Fix links to Custom Flutter Engine Embedders in README. (flutter/flutter#175807) ...
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Oct 16, 2025
This is redundant with the arm64 version of that test. See flutter#176811
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Oct 16, 2025
This is redundant with the arm64 version of that test. See flutter#176811
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Oct 16, 2025
The test is running on arm64 and does not need to run on x64. See flutter#176811
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
The test is running on arm64 and does not need to run on x64. See #176811
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
… x64 machines and extend its timeout (flutter#176811) The "Mac build_ios_framework_module_test" builder was being scheduled on either x64 or arm64 machines. The test takes longer when run on an x64 machine and would sometimes exceed the default 30 minute timeout. This PR changes that builder to only run on x64 and use a 45 minute timeout. (There is already a separate "Mac_arm64 build_ios_framework_module_test" that runs only on arm64)
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…7136) The test is running on arm64 and does not need to run on x64. See flutter#176811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Mac build_ios_framework_module_test" builder was being scheduled on either x64 or arm64 machines. The test takes longer when run on an x64 machine and would sometimes exceed the default 30 minute timeout.
This PR changes that builder to only run on x64 and use a 45 minute timeout. (There is already a separate "Mac_arm64 build_ios_framework_module_test" that runs only on arm64)