Fix expansion tile is missing state announcement on non-Apple platforms #175480

huycozy · 2025-09-17T06:54:55Z

Fix [VPAT][A11y] expansion tile is missing state announcement #173060
The reason of the issue is that semanticsHint is null in Semantics.hint for non iOS/macOS platforms, see:

flutter/packages/flutter/lib/src/material/expansion_tile.dart

Lines 592 to 607 in 7ec7baf

    
           String? semanticsHint; 
        
           switch (theme.platform) { 
        
             case TargetPlatform.iOS: 
        
             case TargetPlatform.macOS: 
        
               semanticsHint = _tileController.isExpanded 
        
                   ? '${localizations.collapsedHint}\n ${localizations.expansionTileExpandedHint}' 
        
                   : '${localizations.expandedHint}\n ${localizations.expansionTileCollapsedHint}'; 
        
             case TargetPlatform.android: 
        
             case TargetPlatform.fuchsia: 
        
             case TargetPlatform.linux: 
        
             case TargetPlatform.windows: 
        
               break; 
        
           } 
        
           return Semantics( 
        
             hint: semanticsHint,

Demo of the fix

Demo video

Screen.Recording.2025-09-16.at.18.56.33.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

packages/flutter/lib/src/material/expansion_tile.dart

Signed-off-by: huycozy <huy@nevercode.io> # Conflicts: # packages/flutter/lib/src/material/expansion_tile.dart # packages/flutter/test/material/expansion_tile_test.dart

chunhtai

LGTM

… platforms (flutter/flutter#175480)

Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e11e2c1...7cd821c 2025-10-14 bruno.leroux@gmail.com Fix computeDistanceToActualBaseline throws when accessing child size (flutter/flutter#176906) 2025-10-14 47866232+chunhtai@users.noreply.github.com iOS can set application locale before view controller is set (flutter/flutter#176592) 2025-10-14 jason-simmons@users.noreply.github.com Roll ANGLE to a branch based on d9fa255a5c22 (flutter/flutter#176747) 2025-10-14 47866232+chunhtai@users.noreply.github.com Relands "Fixes keyboard selects disabled radio" (flutter/flutter#176977) 2025-10-14 huy@nevercode.io Fix expansion tile is missing state announcement on non-Apple platforms (flutter/flutter#175480) 2025-10-14 30870216+gaaclarke@users.noreply.github.com impeller: allows access of float uniforms by name (flutter/flutter#176728) 2025-10-14 aam@google.com Roll dart sdk to 3.11.0-17.0.dev (flutter/flutter#176947) 2025-10-13 okorohelijah@google.com Move iOS integration tests (flutter/flutter#176940) 2025-10-13 ahmedsameha1@gmail.com Make sure that an InputDatePickerFormField doesn't crash in 0x0 envir… (flutter/flutter#176047) 2025-10-13 jason-simmons@users.noreply.github.com [web] Match the behavior of other platforms in Web Locale.toString if the country code is an empty string (flutter/flutter#176862) 2025-10-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes keyboard selects disabled radio (#176727)" (flutter/flutter#176958) 2025-10-13 47866232+chunhtai@users.noreply.github.com Fixes keyboard selects disabled radio (flutter/flutter#176727) 2025-10-13 engine-flutter-autoroll@skia.org Roll Packages from e319c40 to d062181 (2 revisions) (flutter/flutter#176916) 2025-10-13 jason-simmons@users.noreply.github.com Roll SwiftShader to 794b0cfce1d8 (flutter/flutter#176806) 2025-10-13 32538273+ValentinVignal@users.noreply.github.com Make DropdownMenu generic type non nullable (flutter/flutter#176711) 2025-10-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BWGpRvpdQh-HJpq1c... to _dd0Jv50H0oUI2Ad8... (flutter/flutter#176895) 2025-10-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JpiUsek1hU5r9QVKP... to BWGpRvpdQh-HJpq1c... (flutter/flutter#176880) 2025-10-11 codefu@google.com fix: content hash check for LUCI_CONTEXT (flutter/flutter#176867) 2025-10-11 34465683+rkishan516@users.noreply.github.com Feat: make tooltip position customizeable (flutter/flutter#175047) 2025-10-11 engine-flutter-autoroll@skia.org Roll Dart SDK from d88d8bf2b53c to 65b171958c93 (3 revisions) (flutter/flutter#176871) 2025-10-11 34465683+rkishan516@users.noreply.github.com feat: apply radioGroup role to segmented control widgets (flutter/flutter#176157) 2025-10-10 ahmedsameha1@gmail.com Make sure that a CheckboxMenuButton doesn't crash in 0x0 environment (flutter/flutter#176450) 2025-10-10 Rusino@users.noreply.github.com [WebParagraph] Support for more styles, placeholders, decorations, etc (flutter/flutter#172853) 2025-10-10 jason-simmons@users.noreply.github.com Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout (flutter/flutter#176811) 2025-10-10 engine-flutter-autoroll@skia.org Roll Packages from 0b41de3 to e319c40 (1 revision) (flutter/flutter#176833) 2025-10-10 danny@tuppeny.com [tool/dap] Forward app.warning events from Flutter to DAP client (flutter/flutter#176827) 2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 70c00d3ceb3a to d88d8bf2b53c (1 revision) (flutter/flutter#176830) 2025-10-10 sokolovskyi.konstantin@gmail.com Remove unnecessary nullable types in examples. (flutter/flutter#176713) 2025-10-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xArtL4DH0FsdwSqG_... to JpiUsek1hU5r9QVKP... (flutter/flutter#176822) 2025-10-10 bruno.leroux@gmail.com Cleanup OutlinedButton.icon documentation and implementation (flutter/flutter#176630) 2025-10-10 34871572+gmackall@users.noreply.github.com [HCPP] Properly remove hcpp views that are no longer visible (flutter/flutter#176742) 2025-10-10 ahmedsameha1@gmail.com Make sure that an InputChip doesn't crash in 0x0 environment (flutter/flutter#175930) 2025-10-10 737941+loic-sharma@users.noreply.github.com Update Flutter templates' Dart style (flutter/flutter#175963) 2025-10-10 ahmedsameha1@gmail.com Make sure that a DropdownButtonFormField doesn't crash in 0x0 environ… (flutter/flutter#174958) 2025-10-10 ahmedsameha1@gmail.com Make sure that an InkWell doesn't crash in 0x0 environment (flutter/flutter#175871) 2025-10-10 ahmedsameha1@gmail.com Handle#6537 end drawer button (flutter/flutter#173026) 2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from a9b7bd4b0b32 to 70c00d3ceb3a (4 revisions) (flutter/flutter#176815) 2025-10-10 robert.ancell@canonical.com Change default Linux thread policy to merge platform and UI threads. (flutter/flutter#176759) 2025-10-09 bkonyi@google.com [ Tool ] Roll package:dwds to 26.0.0 (flutter/flutter#176808) 2025-10-09 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` to include 3.35.6 notes (flutter/flutter#176803) 2025-10-09 36861262+QuncCccccc@users.noreply.github.com Announce text and button together when DropdownMenu is treated as a button (flutter/flutter#176428) 2025-10-09 gregorysconrad@gmail.com [native_assets] create macOS CCompilerConfig via xcrun --find (flutter/flutter#175717) 2025-10-09 chinmaygarde@google.com [Impeller] Fix broken links in README. (flutter/flutter#176770) 2025-10-09 chinmaygarde@google.com Fix links to Custom Flutter Engine Embedders in README. (flutter/flutter#175807) ...

…ms (flutter#175480) - Fix flutter#173060 - The reason of the issue is that `semanticsHint` is null in `Semantics.hint` for non iOS/macOS platforms, see: https://github.com/flutter/flutter/blob/7ec7baf3a24ecb055b6cb8874ae38e9c8dac3f86/packages/flutter/lib/src/material/expansion_tile.dart#L592-L607 #### Demo of the fix <details open> <summary>Demo video</summary> https://github.com/user-attachments/assets/7604d65c-1f31-4e12-adcd-bf85290efd28 </details> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

huycozy self-assigned this Sep 17, 2025

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 17, 2025

huycozy marked this pull request as ready for review September 17, 2025 08:25

dkwingsmt requested a review from chunhtai September 17, 2025 18:39

chunhtai reviewed Sep 19, 2025

View reviewed changes

packages/flutter/lib/src/material/expansion_tile.dart Show resolved Hide resolved

huycozy requested a review from chunhtai October 1, 2025 02:58

huycozy closed this Oct 13, 2025

huycozy force-pushed the expansion-tile-is-missing-state-173060 branch from b92e44d to 0205d4e Compare October 13, 2025 08:55

This comment was marked as resolved.

Sign in to view

Fix expansion tile is missing state announcement on non-Apple platforms

cb53e60

Signed-off-by: huycozy <huy@nevercode.io> # Conflicts: # packages/flutter/lib/src/material/expansion_tile.dart # packages/flutter/test/material/expansion_tile_test.dart

huycozy reopened this Oct 13, 2025

This comment was marked as resolved.

Sign in to view

chunhtai approved these changes Oct 13, 2025

View reviewed changes

huycozy added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2025

auto-submit bot added this pull request to the merge queue Oct 14, 2025

Merged via the queue into flutter:master with commit c63c6b0 Oct 14, 2025
78 of 79 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2025

huycozy deleted the expansion-tile-is-missing-state-173060 branch October 14, 2025 04:08

engine-flutter-autoroll mentioned this pull request Oct 14, 2025

Roll Flutter from e11e2c11288b to c63c6b08a711 (69 revisions) flutter/packages#10225

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

d14715b

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 14, 2025

Roll Flutter from e11e2c11288b to 55712c460fb8 (71 revisions) flutter/packages#10226

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

283556d

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 14, 2025

Roll Flutter from e11e2c11288b to 48d5d48b5d90 (72 revisions) flutter/packages#10227

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

b950265

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 14, 2025

Roll Flutter from e11e2c11288b to 7cd821c21093 (73 revisions) flutter/packages#10228

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

0ea7f1e

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 14, 2025

Manual roll Flutter from e11e2c11288b to 7cd821c21093 (73 revisions) flutter/packages#10229

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

dd013bd

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 14, 2025

Roll Flutter from e11e2c11288b to 56ce192dc679 (74 revisions) flutter/packages#10230

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

080a622

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 15, 2025

Roll Flutter from e11e2c11288b to cb94cc070574 (75 revisions) flutter/packages#10233

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

8d18a1d

… platforms (flutter/flutter#175480)

engine-flutter-autoroll mentioned this pull request Oct 15, 2025

Roll Flutter from e11e2c11288b to cb94cc070574 (75 revisions) flutter/packages#10234

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2025

c63c6b0 Fix expansion tile is missing state announcement on non-Apple…

080962c

… platforms (flutter/flutter#175480)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix expansion tile is missing state announcement on non-Apple platforms #175480

Fix expansion tile is missing state announcement on non-Apple platforms #175480

huycozy commented Sep 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

chunhtai left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	String? semanticsHint;
	switch (theme.platform) {
	case TargetPlatform.iOS:
	case TargetPlatform.macOS:
	semanticsHint = _tileController.isExpanded
	? '${localizations.collapsedHint}\n ${localizations.expansionTileExpandedHint}'
	: '${localizations.expandedHint}\n ${localizations.expansionTileCollapsedHint}';
	case TargetPlatform.android:
	case TargetPlatform.fuchsia:
	case TargetPlatform.linux:
	case TargetPlatform.windows:
	break;
	}

	return Semantics(
	hint: semanticsHint,

Fix expansion tile is missing state announcement on non-Apple platforms #175480

Fix expansion tile is missing state announcement on non-Apple platforms #175480

Conversation

huycozy commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo of the fix

Pre-launch Checklist

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huycozy commented Sep 17, 2025 •

edited

Loading