[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. #172592

bdero · 2025-07-22T23:12:40Z

We haven't been able to reproduce #169203. We should log the error so that future repros are more useful.

We've already started doing this for other usages (flutter/engine#46692).

flutter-dashboard · 2025-07-22T23:12:43Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

bdero · 2025-07-22T23:33:01Z

This is one of those defensive checks that should theoretically never trigger, but may if there's a GL state isolation issue between impeller and another native renderer (or possibly an issue related to a specific device driver in the wild).

stuartmorgan-g · 2025-07-23T11:53:41Z

test-exempt: Only affects debug build logging

auto-submit · 2025-07-23T22:13:26Z

autosubmit label was removed for flutter/flutter/172592, because - The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

…in blit pass. (flutter/flutter#172592)

…pass. (flutter#172592) We haven't been able to reproduce flutter#169203. We should log the error so that future repros are more useful. We've already started doing this for other usages (flutter/engine#46692).

…in blit pass. (flutter/flutter#172592)

Roll Flutter from 20788c0 to cfbaa18 (43 revisions) flutter/flutter@20788c0...cfbaa18 2025-07-28 git@reki.re Remove shortner (flutter/flutter#172844) 2025-07-28 matanlurey@users.noreply.github.com Update `flutter pub get` to use `flutter.version.json` (instead of `version`) (flutter/flutter#172798) 2025-07-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i7RS-4iBtdndwa3Jy... to tK_PAaLeo0pUxi8hv... (flutter/flutter#172827) 2025-07-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4IewCwqcEm7r4QsXd... to i7RS-4iBtdndwa3Jy... (flutter/flutter#172808) 2025-07-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: get content hash for master on local engine branches (#172792)" (flutter/flutter#172805) 2025-07-26 codefu@google.com fix: build size_exp artifacts in post (flutter/flutter#172802) 2025-07-26 codefu@google.com fix: get content hash for master on local engine branches (flutter/flutter#172792) 2025-07-25 matanlurey@users.noreply.github.com Update `main`/`master` repoExceptions analysis set (flutter/flutter#172796) 2025-07-25 matanlurey@users.noreply.github.com Remove deprecated `--[no-]-disable-dds` (flutter/flutter#172791) 2025-07-25 matanlurey@users.noreply.github.com `last_engine_commit.ps1`: Use `$flutterRoot` instead of `$gitTopLevel` (flutter/flutter#172786) 2025-07-25 matanlurey@users.noreply.github.com Check file contents, remove tests that are now invalid (`: 'none'`) (flutter/flutter#172788) 2025-07-25 loic.peron@inetum.com windows: allow pwsh.bat wrapper (flutter/flutter#171778) 2025-07-25 bdero@google.com [Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. (flutter/flutter#172592) 2025-07-25 matanlurey@users.noreply.github.com Remove deprecated `AssetManifest.json` file (flutter/flutter#172594) 2025-07-25 matanlurey@users.noreply.github.com Refactor `verifyVersion` into typed `Version` object, use it (flutter/flutter#172780) 2025-07-25 jmccandless@google.com Bump the customer tests to pick up an update to Zulip's tests, for th… (flutter/flutter#172733) 2025-07-25 matanlurey@users.noreply.github.com Rename `AppRunLogger`, stop writing status messages that break JSON (flutter/flutter#172591) 2025-07-25 matanlurey@users.noreply.github.com Add `--dart-define`, `-D` to `assemble`, deprecate `--define`, `-d`. (flutter/flutter#172510) 2025-07-25 rmolivares@renzo-olivares.dev Fix previous text input connection interrupts enter/space (flutter/flutter#171973) 2025-07-25 1063596+reidbaker@users.noreply.github.com Update CHANGELOG.md for 3.32.8 (flutter/flutter#172779) 2025-07-25 matanlurey@users.noreply.github.com Fix an `omit-type` lint that is breaking the tree (flutter/flutter#172776) 2025-07-25 reynaldots@gmail.com feat(tool): Respect user-data-dir flag from web-browser-flag (flutter/flutter#169445) 2025-07-25 mdebbar@google.com [web] Fix empty first frame in multiview mode (flutter/flutter#172493) 2025-07-25 jssaadeh@outlook.com Migrate to null aware elements - Part 3 (flutter/flutter#172307) 2025-07-25 mdebbar@google.com Update few links in docs (flutter/flutter#172166) 2025-07-25 engine-flutter-autoroll@skia.org Roll Skia from 768ace3fd144 to 409e1c7ba09b (1 revision) (flutter/flutter#172745) 2025-07-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a_55b5hqpRnigzuNC... to 4IewCwqcEm7r4QsXd... (flutter/flutter#172742) 2025-07-25 engine-flutter-autoroll@skia.org Roll Skia from 094ac350125f to 768ace3fd144 (18 revisions) (flutter/flutter#172735) 2025-07-25 matanlurey@users.noreply.github.com Remove 2023 deprecated `'platforms'` key from daemon output (flutter/flutter#172593) 2025-07-24 a-siva@users.noreply.github.com Manual roll of Dart from 26dece893751 to 5ede85aff798 (flutter/flutter#172731) 2025-07-24 ievdokdm@gmail.com 169108 ci debug (flutter/flutter#172589) 2025-07-24 31685655+SalehTZ@users.noreply.github.com Improve assertion message in `_MixedBorderRadius.resolve()` (flutter/flutter#172100) 2025-07-24 ahmedsameha1@gmail.com Make sure that a BottomAppBar doesn't crash in 0x0 environment (flutter/flutter#172097) 2025-07-24 ahmedsameha1@gmail.com Handle#6537 bottom navigation bar (flutter/flutter#172404) 2025-07-24 ahmedsameha1@gmail.com Make sure that a MaterialBanner doesn't crash in 0x0 environment (flutter/flutter#172074) 2025-07-24 matanlurey@users.noreply.github.com Remove support for `pluginClass: none` (on `master`; `> 3.35.0`) (flutter/flutter#172579) 2025-07-24 ahmedsameha1@gmail.com Make sure that a Card doesn't crash in 0x0 environment (flutter/flutter#172373) 2025-07-24 ahmedsameha1@gmail.com Make sure that an AboutDialog doesn't crash in 0x0 environment (flutter/flutter#172444) 2025-07-24 ahmedsameha1@gmail.com Make sure that an ActionChip doesn't crash in 0x0 environment (flutter/flutter#172684) 2025-07-24 matanlurey@users.noreply.github.com Delete (unused) `dev/checks_tool` directory (flutter/flutter#172715) 2025-07-24 34871572+gmackall@users.noreply.github.com [Android] Add missing ci configuration for `Linux android_java17_tool_integration_tests` (flutter/flutter#172702) 2025-07-24 srawlins@google.com Flutter-Cherrypick-Process.md - Spell cherry-pick consistently (flutter/flutter#172697) 2025-07-24 matanlurey@users.noreply.github.com Bringup `linux_web_engine_tests`; failing 4+ times in a row (flutter/flutter#172714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…pass. (flutter#172592) We haven't been able to reproduce flutter#169203. We should log the error so that future repros are more useful. We've already started doing this for other usages (flutter/engine#46692).

…in blit pass. (flutter/flutter#172592)

…pass. (flutter#172592) We haven't been able to reproduce flutter#169203. We should log the error so that future repros are more useful. We've already started doing this for other usages (flutter/engine#46692).

bdero requested a review from chinmaygarde July 22, 2025 23:12

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jul 22, 2025

bdero force-pushed the bdero/fbostatus branch from 9eaee0d to e7dbdd9 Compare July 22, 2025 23:39

chinmaygarde approved these changes Jul 23, 2025

View reviewed changes

bdero force-pushed the bdero/fbostatus branch from e7dbdd9 to 41cd009 Compare July 23, 2025 21:15

bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2025

[Impeller] Print glCheckFrameBufferStatus output when it fails.

2d0c863

bdero force-pushed the bdero/fbostatus branch from 41cd009 to 2d0c863 Compare July 25, 2025 19:43

bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2025

auto-submit bot added this pull request to the merge queue Jul 25, 2025

Merged via the queue into flutter:master with commit 500684c Jul 25, 2025
177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2025

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to a9f310a4c91a (39 revisions) flutter/packages#9680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

41ce851

…in blit pass. (flutter/flutter#172592)

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

c81ec66

…in blit pass. (flutter/flutter#172592)

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9682

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

fe55f9d

…in blit pass. (flutter/flutter#172592)

engine-flutter-autoroll mentioned this pull request Jul 27, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9683

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

f1f7ad7

…in blit pass. (flutter/flutter#172592)

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to 0125d95f7eb0 (42 revisions) flutter/packages#9686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

9ac3f00

…in blit pass. (flutter/flutter#172592)

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to cfbaa18bdecc (43 revisions) flutter/packages#9688

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

e45de21

…in blit pass. (flutter/flutter#172592)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

500684c [Impeller] Log glCheckFrameBufferStatus output when it fails …

6d44bcf

…in blit pass. (flutter/flutter#172592)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. #172592

[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. #172592

Uh oh!

bdero commented Jul 22, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 22, 2025

Uh oh!

bdero commented Jul 22, 2025

Uh oh!

stuartmorgan-g commented Jul 23, 2025

Uh oh!

auto-submit bot commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. #172592

[Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. #172592

Uh oh!

Conversation

bdero commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Jul 22, 2025

Uh oh!

bdero commented Jul 22, 2025

Uh oh!

stuartmorgan-g commented Jul 23, 2025

Uh oh!

auto-submit bot commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bdero commented Jul 22, 2025 •

edited

Loading