Make sure that a Card doesn't crash in 0x0 environment #172373

ahmedsameha1 · 2025-07-18T15:39:43Z

This is my attempt to handle #6537 for the Card UI control.

dkwingsmt

LGTM

ahmedsameha1 · 2025-07-24T19:50:38Z

Thank you for reviewing.

MitchellGoodwin

LGTM!

…er/flutter#172373)

This is my attempt to handle flutter#6537 for the Card UI control. Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

…er/flutter#172373)

Roll Flutter from 20788c0 to cfbaa18 (43 revisions) flutter/flutter@20788c0...cfbaa18 2025-07-28 git@reki.re Remove shortner (flutter/flutter#172844) 2025-07-28 matanlurey@users.noreply.github.com Update `flutter pub get` to use `flutter.version.json` (instead of `version`) (flutter/flutter#172798) 2025-07-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i7RS-4iBtdndwa3Jy... to tK_PAaLeo0pUxi8hv... (flutter/flutter#172827) 2025-07-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4IewCwqcEm7r4QsXd... to i7RS-4iBtdndwa3Jy... (flutter/flutter#172808) 2025-07-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: get content hash for master on local engine branches (#172792)" (flutter/flutter#172805) 2025-07-26 codefu@google.com fix: build size_exp artifacts in post (flutter/flutter#172802) 2025-07-26 codefu@google.com fix: get content hash for master on local engine branches (flutter/flutter#172792) 2025-07-25 matanlurey@users.noreply.github.com Update `main`/`master` repoExceptions analysis set (flutter/flutter#172796) 2025-07-25 matanlurey@users.noreply.github.com Remove deprecated `--[no-]-disable-dds` (flutter/flutter#172791) 2025-07-25 matanlurey@users.noreply.github.com `last_engine_commit.ps1`: Use `$flutterRoot` instead of `$gitTopLevel` (flutter/flutter#172786) 2025-07-25 matanlurey@users.noreply.github.com Check file contents, remove tests that are now invalid (`: 'none'`) (flutter/flutter#172788) 2025-07-25 loic.peron@inetum.com windows: allow pwsh.bat wrapper (flutter/flutter#171778) 2025-07-25 bdero@google.com [Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. (flutter/flutter#172592) 2025-07-25 matanlurey@users.noreply.github.com Remove deprecated `AssetManifest.json` file (flutter/flutter#172594) 2025-07-25 matanlurey@users.noreply.github.com Refactor `verifyVersion` into typed `Version` object, use it (flutter/flutter#172780) 2025-07-25 jmccandless@google.com Bump the customer tests to pick up an update to Zulip's tests, for th… (flutter/flutter#172733) 2025-07-25 matanlurey@users.noreply.github.com Rename `AppRunLogger`, stop writing status messages that break JSON (flutter/flutter#172591) 2025-07-25 matanlurey@users.noreply.github.com Add `--dart-define`, `-D` to `assemble`, deprecate `--define`, `-d`. (flutter/flutter#172510) 2025-07-25 rmolivares@renzo-olivares.dev Fix previous text input connection interrupts enter/space (flutter/flutter#171973) 2025-07-25 1063596+reidbaker@users.noreply.github.com Update CHANGELOG.md for 3.32.8 (flutter/flutter#172779) 2025-07-25 matanlurey@users.noreply.github.com Fix an `omit-type` lint that is breaking the tree (flutter/flutter#172776) 2025-07-25 reynaldots@gmail.com feat(tool): Respect user-data-dir flag from web-browser-flag (flutter/flutter#169445) 2025-07-25 mdebbar@google.com [web] Fix empty first frame in multiview mode (flutter/flutter#172493) 2025-07-25 jssaadeh@outlook.com Migrate to null aware elements - Part 3 (flutter/flutter#172307) 2025-07-25 mdebbar@google.com Update few links in docs (flutter/flutter#172166) 2025-07-25 engine-flutter-autoroll@skia.org Roll Skia from 768ace3fd144 to 409e1c7ba09b (1 revision) (flutter/flutter#172745) 2025-07-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a_55b5hqpRnigzuNC... to 4IewCwqcEm7r4QsXd... (flutter/flutter#172742) 2025-07-25 engine-flutter-autoroll@skia.org Roll Skia from 094ac350125f to 768ace3fd144 (18 revisions) (flutter/flutter#172735) 2025-07-25 matanlurey@users.noreply.github.com Remove 2023 deprecated `'platforms'` key from daemon output (flutter/flutter#172593) 2025-07-24 a-siva@users.noreply.github.com Manual roll of Dart from 26dece893751 to 5ede85aff798 (flutter/flutter#172731) 2025-07-24 ievdokdm@gmail.com 169108 ci debug (flutter/flutter#172589) 2025-07-24 31685655+SalehTZ@users.noreply.github.com Improve assertion message in `_MixedBorderRadius.resolve()` (flutter/flutter#172100) 2025-07-24 ahmedsameha1@gmail.com Make sure that a BottomAppBar doesn't crash in 0x0 environment (flutter/flutter#172097) 2025-07-24 ahmedsameha1@gmail.com Handle#6537 bottom navigation bar (flutter/flutter#172404) 2025-07-24 ahmedsameha1@gmail.com Make sure that a MaterialBanner doesn't crash in 0x0 environment (flutter/flutter#172074) 2025-07-24 matanlurey@users.noreply.github.com Remove support for `pluginClass: none` (on `master`; `> 3.35.0`) (flutter/flutter#172579) 2025-07-24 ahmedsameha1@gmail.com Make sure that a Card doesn't crash in 0x0 environment (flutter/flutter#172373) 2025-07-24 ahmedsameha1@gmail.com Make sure that an AboutDialog doesn't crash in 0x0 environment (flutter/flutter#172444) 2025-07-24 ahmedsameha1@gmail.com Make sure that an ActionChip doesn't crash in 0x0 environment (flutter/flutter#172684) 2025-07-24 matanlurey@users.noreply.github.com Delete (unused) `dev/checks_tool` directory (flutter/flutter#172715) 2025-07-24 34871572+gmackall@users.noreply.github.com [Android] Add missing ci configuration for `Linux android_java17_tool_integration_tests` (flutter/flutter#172702) 2025-07-24 srawlins@google.com Flutter-Cherrypick-Process.md - Spell cherry-pick consistently (flutter/flutter#172697) 2025-07-24 matanlurey@users.noreply.github.com Bringup `linux_web_engine_tests`; failing 4+ times in a row (flutter/flutter#172714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

This is my attempt to handle flutter#6537 for the Card UI control. Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

…er/flutter#172373)

This is my attempt to handle flutter#6537 for the Card UI control. Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

Make sure that a Card doesn't crash in 0x0 environment

6478f26

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 18, 2025

dkwingsmt self-requested a review July 23, 2025 18:20

Merge branch 'master' into handle#6537-Card

541cdc8

dkwingsmt approved these changes Jul 24, 2025

View reviewed changes

MitchellGoodwin approved these changes Jul 24, 2025

View reviewed changes

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2025

auto-submit bot added this pull request to the merge queue Jul 24, 2025

Merged via the queue into flutter:master with commit 4778560 Jul 24, 2025
73 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

f65c109

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 25, 2025

Roll Flutter from 20788c07fcb8 to 6937b0c35ac1 (20 revisions) flutter/packages#9673

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

d175b7b

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 25, 2025

Roll Flutter from 20788c07fcb8 to c1c38adec6c5 (21 revisions) flutter/packages#9675

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

dcbdb7c

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 25, 2025

Roll Flutter from 20788c07fcb8 to aea660d5cd59 (22 revisions) flutter/packages#9676

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

4e92fbf

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 25, 2025

Roll Flutter from 20788c07fcb8 to 7d13988ceebb (23 revisions) flutter/packages#9678

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

4bc6067

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to a9f310a4c91a (39 revisions) flutter/packages#9680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

f99717a

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

249ddad

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9682

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

61595e8

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 27, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9683

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

f79721a

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to 0125d95f7eb0 (42 revisions) flutter/packages#9686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

7bccbaa

…er/flutter#172373)

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to cfbaa18bdecc (43 revisions) flutter/packages#9688

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

4778560 Make sure that a Card doesn't crash in 0x0 environment (flutt…

6d0145c

…er/flutter#172373)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make sure that a Card doesn't crash in 0x0 environment #172373

Make sure that a Card doesn't crash in 0x0 environment #172373

Uh oh!

ahmedsameha1 commented Jul 18, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

ahmedsameha1 commented Jul 24, 2025

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Make sure that a Card doesn't crash in 0x0 environment #172373

Make sure that a Card doesn't crash in 0x0 environment #172373

Uh oh!

Conversation

ahmedsameha1 commented Jul 18, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedsameha1 commented Jul 24, 2025

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants